D-Bus API for storage issues#548
Merged
joseivanlopez merged 7 commits intoagama-project:issuesfrom Apr 27, 2023
Merged
Conversation
50a5c79 to
0a77681
Compare
Pull Request Test Coverage Report for Build 4817478639
💛 - Coveralls |
0a77681 to
d832985
Compare
imobachgs
approved these changes
Apr 26, 2023
dgdavid
approved these changes
Apr 26, 2023
Contributor
dgdavid
left a comment
There was a problem hiding this comment.
LGTM, but I'd wait for another review from someone with more D-Bus background.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Agama D-Bus API has the validation concept, which is provided by the
org.opensuse.Agama1.Validationinterface. That validation is used by clients to check if there is any error. But a more generic mechanishm is required to report diffirent kind of issues, for example warnings. This would be useful, for example, to get the list of issues reported by the storage probing.Solution
Add a new
org.opensuse.Agama1.Issuesinterface. That interface would replace the previousorg.opensuse.Agama1.Validationinterface. Now, services can report different types of issues (warn and error for now). Clients can subscribe to changes in the issues.This PR only adapts the storage service to use the issues interface instead of validations. The rest of services will be adapted later in a serparate PR.
Note: Failures in the integration tests are expected. They will be fixed after adapting the web UI, see #540.
Testing