[web] Do not show group options name until needed#555
Merged
Conversation
Since it can be confusing
Pull Request Test Coverage Report for Build 4859591904
💛 - Coveralls |
dgdavid
changed the title
dgdavid
force-pushed
the
improve-storage-options
branch
from
b1bda09 to
517ce97
Compare
dgdavid
force-pushed
the
improve-storage-options
branch
from
517ce97 to
48dfa5b
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During a review meeting, we've spot that displaying the group options name when there is only a single group of options can be more confusing than helpful.
Solution
Display the group name only when needed. I.e., when really having more than one group of actions for a set of page options.
Testing
Notes
Since it's related with #545 and it has not been merged to master yet, this PR belongs to the same changelog entry. No extra one needed, IMHO.
Screenshots