Adds userChrome.css to remove the "Chrome" from the UI in firefox#3343
Adds userChrome.css to remove the "Chrome" from the UI in firefox#3343ancorgs merged 7 commits intoagama-project:masterfrom
Conversation
Hide the UI when only one tab is present Removes the close button
Enables userChrome.css Open links in new windows Hide bookmarks Disable "Sponsored" content on new tabs Disable firefox first-run welcome page Disable popup blocker notification Allow extlink protocol
dgdavid
left a comment
There was a problem hiding this comment.
Hi @sfalken,
First of all, thanks for this useful contribution!
I've reviewed it, and it looks great. It improves the ISO experience without breaking any critical browser features.
Just two small things:
- I'd keep links opening in tabs rather than forcing new windows. It's better to see the “Agama” tab than a new window on top. Moreover, almost a year ago the team stopped using the kiosk mode and committed to easing user experience while being transparent that it is running in a browser.
- As a side effect of displaying nothing when there is only one tab, users dont get feedback when downloading config or logs. That is not ideal :( One way to address this could be to always prompt the user for the download location. If I'm not wrong, this can be achieved by setting
browser.download.useDownloadDirtofalse. If you also know how to force the download panel to show, that would be even better. Would you mind updating the PR to at least include the first?
Thanks in adavance!
| // Open links in new windows, rather than tabs | ||
| user_pref("browser.link.open_newwindow", 2); | ||
| user_pref("browser.link.open_newwindow.restriction", 1); |
In my opinion, that would indeed make a lot of sense. It makes sense in general and even more with the rest of the changes in this pull request. |
What does this even mean? The biggest complaint I had when trying out this ISO was that Agama provides no feedback when it is working or loading pages. This is in contrast to the Anaconda web UI, which presents a spinner indicating the installer is starting up while the pile of web pages loads. |
It means that while we are open to tweaks in the ISO browser to provide a cleaner, less cluttered UI, we are not actively trying to hide the fact that the user is interacting with the web interface of the installer or that it is running in a browser. Thus, we avoid changes that could interfere with or hinder the normal interaction of a user with the browser. Nothing more than that.
IMHO, this has no relation to either the PR or the clarification I added about the browser tweaks scope we are open to accept. In any case, the Agama web interface has always provided active feedback, including spinners and skeletons, to make users aware that some action is in progress. Recent improvements have made it even better: pages and operations now load faster, some processes can run in the background without blocking user interaction, and, when needed, a blocking, informative overlay appears to let them know that something is in progress and they have to wait a little bit. Of course, the team will continue working to make the experience pleasant and smoother. If you have a workflow where the Agama web interface sometimes gets stuck silently without giving feedback to users, we would really appreciate it if you could open a separate issue with clear steps to reproduce it. This will help us investigate and fix the problem more efficiently. Otherwise, it would be difficult to address it in a cross-PR comment. Thanks! |
|
New test image, with requested changes, for demonstration. Fired it up in a VM, and it appears to do what was requested. |
ancorgs
left a comment
There was a problem hiding this comment.
New test image, with requested changes, for demonstration.
Fired it up in a VM, and it appears to do what was requested.
I tested and it indeed works as requested. So I'm approving this.
Nevertheless, it would be even cooler if you can add a changelog entry to live/src/agama-installer.changes. If that's inconvenient, I could also merge and add the changelog later myself.
I'll take care of it. I completely forgot to update the changelog before PR'ing. |
|
Thanks a lot @sfalken! |
Prepare to release version 20. * #3294 * #3295 * #3296 * #3297 * #3298 * #3299 * #3300 * #3301 * #3302 * #3303 * #3304 * #3305 * #3306 * #3307 * #3308 * #3309 * #3310 * #3311 * #3312 * #3313 * #3315 * #3316 * #3317 * #3318 * #3319 * #3320 * #3322 * #3323 * #3325 * #3326 * #3327 * #3329 * #3330 * #3331 * #3333 * #3334 * #3336 * #3338 * #3339 * #3342 * #3343 * #3349 * #3351 * #3352 * #3353 * #3354 * #3356 * #3357 * #3358 * #3359 * #3360 * #3361 * #3362 * #3363 * #3364 * #3365 * #3366 * #3367 * #3368 * #3371 * #3372 * #3373 * #3375 * #3376 * #3378 * #3379 * #3380 * #3381 * #3382 * #3385 * #3386
Problem
In agama, the browser still contains all of the "Chrome" such as the tab bar, close button, etc and makes for a messy UX
Solution
Add userChrome.css, and minor changes to usr.js.template, to remove the "Chrome" from the UI by default.
Testing
Test image, with changes enabled @ https://download.opensuse.org/repositories/home:/sfalken:/agamatest/images/iso/agama-installer.x86_64-19.0.0-openSUSE-Build10.2.iso
Disclosure:
ASSISTED-BY: Claude(claude-sonnet-4-6) for some lookup and research. This PR contains No LLM generated/written code