Adapt agama config to return error code when no validates

[teclator]

Problem

When running agama config load, agama config generate or agama config validate it always returns 0 even when the profile is invalid.

• bsc#1256951

Solution

Return Err (return code 1) in case of invalid profile.

Testing

• Tested manually

agama config generate

suse@vikingo-laptop:~$ ~/agama_not_fix/agama config generate profile.jsonnet || echo $?
{
   "hostname": {
      "static": "Agama"
   },
   "product": {
      "ID": "Tumbleweed"
   },
   "scripts": {
      "post": [
         {
            "chroot": true,
            "content": "#!/usr/bin/env bash\necho 'PermitRootLogin yes' > /etc/ssh/sshd_config.d/root.conf\nsystemctl enable sshd\n",
            "name": "enable root login"
         }
      ]
   }
}
✗ The profile is not valid. Please, check the following errors:

        * Additional properties are not allowed ('ID' was unexpected). /product
        * "id" is a required property. /product

suse@vikingo-laptop:~$ ~/agama_fix/agama config generate profile.jsonnet || echo $?
{
   "hostname": {
      "static": "Agama"
   },
   "product": {
      "ID": "Tumbleweed"
   },
   "scripts": {
      "post": [
         {
            "chroot": true,
            "content": "#!/usr/bin/env bash\necho 'PermitRootLogin yes' > /etc/ssh/sshd_config.d/root.conf\nsystemctl enable sshd\n",
            "name": "enable root login"
         }
      ]
   }
}
✗ The profile is not valid. Please, check the following errors:

        * Additional properties are not allowed ('ID' was unexpected). /product
        * "id" is a required property. /product

The profile is not valid
1

agama config load

suse@vikingo-laptop:~$ ~/agama_not_fix/agama config load profile.json || echo $?
✗ The profile is not valid. Please, check the following errors:

        * Additional properties are not allowed ('ID' was unexpected). /product
        * "id" is a required property. /product

suse@vikingo-laptop:~$ ~/agama_fix/agama config load profile.json || echo $?
✗ The profile is not valid. Please, check the following errors:

        * Additional properties are not allowed ('ID' was unexpected). /product
        * "id" is a required property. /product

The profile is not valid
1

agama config validate

suse@vikingo-laptop:~$ ~/agama_not_fix/agama config validate profile.json || echo $?
✗ The profile is not valid. Please, check the following errors:

        * Additional properties are not allowed ('ID' was unexpected). /product
        * "id" is a required property. /product

suse@vikingo-laptop:~$ ~/agama_fix/agama config validate profile.json || echo $?
✗ The profile is not valid. Please, check the following errors:

        * Additional properties are not allowed ('ID' was unexpected). /product
        * "id" is a required property. /product

The profile is not valid
1

[imobachgs]

In general, it looks good. Please, remove the reference to InstallSettings.