service: Fix wrong check when searching or creating a storage device#3322
Merged
ancorgs merged 2 commits intoagama-project:masterfrom Mar 23, 2026
Merged
service: Fix wrong check when searching or creating a storage device#3322ancorgs merged 2 commits intoagama-project:masterfrom
ancorgs merged 2 commits intoagama-project:masterfrom
Conversation
ancorgs
force-pushed
the
create_if_not_found
branch
from
22b66f2 to
7a5a192
Compare
Contributor
joseivanlopez
left a comment
joseivanlopez
left a comment
There was a problem hiding this comment.
Looks good. Please, add a changelog entry.
Merged
imobachgs
added a commit
that referenced
this pull request
Apr 14, 2026
Prepare to release version 20. * #3294 * #3295 * #3296 * #3297 * #3298 * #3299 * #3300 * #3301 * #3302 * #3303 * #3304 * #3305 * #3306 * #3307 * #3308 * #3309 * #3310 * #3311 * #3312 * #3313 * #3315 * #3316 * #3317 * #3318 * #3319 * #3320 * #3322 * #3323 * #3325 * #3326 * #3327 * #3329 * #3330 * #3331 * #3333 * #3334 * #3336 * #3338 * #3339 * #3342 * #3343 * #3349 * #3351 * #3352 * #3353 * #3354 * #3356 * #3357 * #3358 * #3359 * #3360 * #3361 * #3362 * #3363 * #3364 * #3365 * #3366 * #3367 * #3368 * #3371 * #3372 * #3373 * #3375 * #3376 * #3378 * #3379 * #3380 * #3381 * #3382 * #3385 * #3386
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As reported at #2985.
When searching for a device with the setting
{ "ifNotFound": "create" }, Agama was reporting an error if the device was not found.Actually, the mechanism to create the missing device is in place, but the overzealous check was causing the rest of the process to be aborted so it was not even attempted.
Solution
This fixes #2985 by improving the check. Now it takes the case of
{ "ifNotFound": "create" }into account.Testing
In fact, this PR is a small fix... with several lines of extra tests to verify.