Skip to content

SLE-16: use always an empty array for optional_patterns#3295

Merged
imobachgs merged 3 commits intoSLE-16from
update-optional-patterns
Mar 19, 2026
Merged

SLE-16: use always an empty array for optional_patterns#3295
imobachgs merged 3 commits intoSLE-16from
update-optional-patterns

Conversation

@imobachgs
Copy link
Copy Markdown
Contributor

Problem

In order to use the products definition with newer Agama versions, we need to set the optional_patterns as an empty array instead of null.

Solution

Make the definition compatible with newer Agama versions.

@imobachgs imobachgs changed the title Use always an empty array for optional_patterns SLE-16: use always an empty array for optional_patterns Mar 18, 2026
Copy link
Copy Markdown
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change make sense according to the PR description. However, some Ruby tests are failing. Looks unrelated failure to changes to me, but worth having a look before merging.

@imobachgs
Copy link
Copy Markdown
Contributor Author

They are not related to this PR and it is not the first time that I see them. Most probably the container is missing a new version of yast2-storage-ng or libstorage-ng.

@imobachgs imobachgs merged commit 162828a into SLE-16 Mar 19, 2026
9 of 10 checks passed
@imobachgs imobachgs deleted the update-optional-patterns branch March 19, 2026 12:40
@imobachgs imobachgs mentioned this pull request Apr 14, 2026
imobachgs added a commit that referenced this pull request Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants