Skip to content

fix: service integration test, and IRC result reporting#3308

Merged
mvidner merged 3 commits intomasterfrom
fix-integration-tests
Mar 23, 2026
Merged

fix: service integration test, and IRC result reporting#3308
mvidner merged 3 commits intomasterfrom
fix-integration-tests

Conversation

@mvidner
Copy link
Copy Markdown
Contributor

@mvidner mvidner commented Mar 20, 2026

Problem

  1. The job https://github.com/agama-project/agama/actions/workflows/ci-integration-tests.yml has been failing
  2. We haven't noticed for 3 months because...? The IRC notification has been failing: LiberaChat started requiring the bot to log in

Solution

  1. Make the test more robust by matching structurally, not literally
  2. Create a Libera.Chat account for agama-team-bot, document it in our Confluence team space and use it

Testing

  • (With /test_using_container.sh) manually run what the CI job does: (cd service; bundle exec rspec --pattern 'test/integration/**_itest.rb')
  • modify the workflow file temporarily to trigger a failure that does send an IRC message
  • trigger the workflow to show that it does pass
  • oops it still fails but in a different repo than this one. done fixing here

Screenshots

No

Documentation

  • integration tests: no
  • failure reporting: added a Confluence page with the credentials of the new IRC bot

mvidner added 2 commits March 20, 2026 10:28
The failure is likely related to API v2 introduction but it's hard to tell
because the test has been failing for 3 months.

Keeping it simple with a literal match, no further normalization for now.
…d password

see also: Confluence / YaST Team / Internal Resources / IRC Bot
@mvidner mvidner force-pushed the fix-integration-tests branch from 3300a02 to 1ee8026 Compare March 20, 2026 13:37
"packages": []
},
"product": {
"id": "Tumbleweed"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be honest, for me more robust way would be to parse output and check its structure than just relying on certain output format or order

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, fixed now, thanks!

@mvidner
Copy link
Copy Markdown
Contributor Author

mvidner commented Mar 23, 2026

Latest manual run on this branch: https://github.com/agama-project/agama/actions/runs/23429593717/job/68152344619

  • fixed: backend test failure
  • fixed: IRC notifications
  • failing still: integration-tests at the frontend

I would still like to merge this, as I'd like to get back to my regular PBI :)

@mvidner mvidner changed the title fix: reorder integration test expected output to match reality fix: service integration test, and IRC result reporting Mar 23, 2026
@mvidner mvidner merged commit 3a58e07 into master Mar 23, 2026
15 of 16 checks passed
@mvidner mvidner deleted the fix-integration-tests branch March 23, 2026 09:23
@imobachgs imobachgs mentioned this pull request Apr 14, 2026
imobachgs added a commit that referenced this pull request Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants