web: stop using custom styles for PatternFly Alert#3305
Merged
Conversation
Custom CSS overrides for PF/Alert were added during a previous interface update. During the last UI reorganization, it was proposed to revert to PatternFly defaults (see PR #3050, review #3680245452), as they fit well and reduce maintenance overhead. This commit removes the overrides and simplifies Alert styling.
…ance The removed custom CSS overrides had previously forced all Alerts to render without shadow/elevation. Now that the overrides are gone, Alerts regain their default elevated style. To keep the previous visual "flat" appearance, this commit adds the `isInline` prop to Alert instances to flatten them. This does not imply that these Alerts were originally intended to be inline, the elevation simply did not work well with the custom styles. There is currently no Agama pattern or agreement for deciding when an Alert should be elevated versus inline, though one could be established in the future if needed.
imobachgs
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom CSS overrides for PF/Alert were added some time ago during the update to PatternFly 6, because the default styles at the time didn’t integrate well with the Agama interface at that point. During the last UI reorganization, it was proposed to revert to PatternFly defaults (check #3050 (review)), as they now fit well and help reduce maintenance overhead. Moreover, the default styles provide better text readability.
Some examples,
PR (re)born in the context of https://trello.com/c/mHQxVQ1t/ (protected link)