Unity-Technologies
diff --git a/‎com.unity.render-pipelines.high-definition/CHANGELOG.md‎
Lines changed: 10 additions & 0 deletions b/‎com.unity.render-pipelines.high-definition/CHANGELOG.md‎
Lines changed: 10 additions & 0 deletions
diff --git a/‎com.unity.render-pipelines.high-definition/Documentation~/Custom-Pass-Creating.md‎
Lines changed: 3 additions & 0 deletions b/‎com.unity.render-pipelines.high-definition/Documentation~/Custom-Pass-Creating.md‎
Lines changed: 3 additions & 0 deletions
diff --git a/‎com.unity.render-pipelines.high-definition/Documentation~/Images/Matcap1.png‎
Lines changed: 2 additions & 2 deletions b/‎com.unity.render-pipelines.high-definition/Documentation~/Images/Matcap1.png‎
Lines changed: 2 additions & 2 deletions
diff --git a/‎com.unity.render-pipelines.high-definition/Documentation~/MatCap.md‎
Lines changed: 9 additions & 9 deletions b/‎com.unity.render-pipelines.high-definition/Documentation~/MatCap.md‎
Lines changed: 9 additions & 9 deletions
diff --git a/‎com.unity.render-pipelines.high-definition/Documentation~/VR-Overview.md‎
Lines changed: 8 additions & 7 deletions b/‎com.unity.render-pipelines.high-definition/Documentation~/VR-Overview.md‎
Lines changed: 8 additions & 7 deletions
diff --git a/‎com.unity.render-pipelines.high-definition/Editor/AssetProcessors/FBXMaterialDescriptionPostprocessor.cs‎
Lines changed: 4 additions & 4 deletions b/‎com.unity.render-pipelines.high-definition/Editor/AssetProcessors/FBXMaterialDescriptionPostprocessor.cs‎
Lines changed: 4 additions & 4 deletions
diff --git a/‎com.unity.render-pipelines.high-definition/Editor/Lighting/HDLightExplorerExtension.cs‎
Lines changed: 2 additions & 1 deletion b/‎com.unity.render-pipelines.high-definition/Editor/Lighting/HDLightExplorerExtension.cs‎
Lines changed: 2 additions & 1 deletion
diff --git a/‎com.unity.render-pipelines.high-definition/Editor/Lighting/HDLightUI.cs‎
Lines changed: 2 additions & 1 deletion b/‎com.unity.render-pipelines.high-definition/Editor/Lighting/HDLightUI.cs‎
Lines changed: 2 additions & 1 deletion
diff --git a/‎com.unity.render-pipelines.high-definition/Editor/VFXGraph/Shaders/Templates/Mesh/PassDepthForwardOnly.template‎
Lines changed: 17 additions & 0 deletions b/‎com.unity.render-pipelines.high-definition/Editor/VFXGraph/Shaders/Templates/Mesh/PassDepthForwardOnly.template‎
Lines changed: 17 additions & 0 deletions
diff --git a/‎com.unity.render-pipelines.high-definition/Editor/VFXGraph/Shaders/Templates/Mesh/PassDepthForwardOnly.template.meta‎
Lines changed: 7 additions & 0 deletions b/‎com.unity.render-pipelines.high-definition/Editor/VFXGraph/Shaders/Templates/Mesh/PassDepthForwardOnly.template.meta‎
Lines changed: 7 additions & 0 deletions
@@ -81,6 +81,16 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed using the wrong coordinate to compute the sampling direction for the screen space global illumination.
 - Fixed an issue where forced sky update (like PBR sky amortized updated) would not update ambient probe.
 - Fixed static lighting sky update when using an HDRI sky with a render texture in parameter.
+- Fixed sky jittering when TAA is enabled.
+- Fixed Normal Map assiignation when importing FBX Materials.
+- Fixed issue with HDRI Sky and shadow filtering quality set to high.
+- Fixed the default custom pass buffer format from R8G8B8A8_SNorm to R8G8B8A8_UNorm. Additionally, an option in the custom pass buffer format settings is available to use the old format.
+- Fixed cached directional light shadows disappearing without reappearing when the going outside of the range of shadow validity.
+- Fixed an issue where sometimes full screen debug would cause render graph errors.
+- Fixed a nullref exception when creating a new scene while LightExplorer is open.
+- Fixed issue that caused the uber post process to run even if nothing is to be done, leading to different results when disabling every post process manually vs disabling the whole post-processing pipeline.
+- Fixed issue that placed an OnDemand shadow in the atlas before it was ever rendered.
+- Fixed issue at edge of screen on some platforms when SSAO is on.
 
 ## [14.0.0] - 2021-11-17
 
 
@@ -159,6 +159,8 @@ However, not all materials are supported by every injection point in a draw rend
 
 When Unity renders a material that is not supported by the current injection point, it results in an undefined behavior. For example, rendering GameObjects with lit shaders in the **After Opaque Depth And Normal** injection point produces unexpected results.
 
+Note: HDRP does not support decals on GameObjects rendered in the DrawRenderers pass.
+
 <a name="Object-ID-Custom-Pass"></a>
 
 ## Object ID Custom Pass
@@ -475,6 +477,7 @@ To change the buffer format of the Custom Pass component in your HDRP asset, go
 | **Format**   | **Bits Per Pixel** | **Description**                                              |
 | ------------ | ------------------ | ------------------------------------------------------------ |
 | R8G8B8A8     | 32                 | This format is the most resource efficient, but it might cause banding issues. HDRP uses this format by default. |
+| Signed R8G8B8A8 | 32              | This format is similar to R8G8B8A8 but you can store unsigned data. |
 | R11G11B10    | 32                 | This format has a higher precision than R8G8B8A8 but does not support alpha channels. |
 | R16G16B16A16 | 64                 | This format has the highest precision but uses twice as much memory as R8G8B8A8 and R11G11B10. |
 
 
@@ -1,23 +1,23 @@
 # MatCap mode
 
-In MatCap mode, the High Definition Render Pipeline (HDRP) replaces the functionality of the Scene window's Lighting button with a material capture (MatCap) view. MatCap mode uses an image that completely captures a Material, including baked-in lighting. When using MatCap mode, HDRP replaces all of the Materials and lighting in the Scene with what is in the MatCap.
+In MatCap mode, the High Definition Render Pipeline (HDRP) replaces the functionality of the Scene view's Lighting button with a material capture (MatCap) view. MatCap mode uses an image that completely captures a Material, including baked-in lighting. When using MatCap mode, HDRP replaces all the Materials and lighting in the Scene with what's in the MatCap.
 
-MatCap mode is particularly useful to navigate and get a sense of the Scene without setting up the Scene lighting. For example, if you were to edit a dark area, like the inside of a cave, it would be difficult to navigate with low lighting MatCap mode makes it much easier to navigate in such dark areas.
+MatCap mode is useful to navigate and get a sense of the Scene without setting up the Scene lighting. For example, if you were to edit a dark area, like the inside of a cave, MatCap mode makes it much easier to navigate in this low lighting.
 
 ## Using MatCap
 
-To activate MatCap mode, disable the Lighting toggle in the Scene window.
+To activate MatCap mode, disable the Lighting toggle in the Scene view.
 
 ![](Images/MatCap1.png)
 
-MatCap mode preserves the normal maps and you can use the original Material albedo. To configure MatCap mode, go to **Edit > Preferences > HD Render Pipeline** and use the following properties.
+MatCap mode preserves the normal maps and you can use the original Material albedo. To configure MatCap mode, go to **Edit** > **Preferences** > **HD Render Pipeline** and use the following properties.
 
 ## Properties
 
 | **Property**                  | **Description**                                              |
 | ----------------------------- | ------------------------------------------------------------ |
-| **Mix Albedo in MatCap Mode** | Enable the checkbox to make HDRP mix the albedo of the Material with its material capture. |
-| **MatCap Intensity Scale**    | Set the intensity of the material capture. This increases the brightness of the Scene. This is especially useful if the albedo darkens the Scene considerably. |
+| **Mix Albedo in MatCap Mode** | Enable to make HDRP mix the albedo of the Material with its material capture. |
+| **MatCap Intensity Scale**    | Set the intensity of the material capture. This increases the brightness of the Scene. This is useful if the albedo darkens the Scene considerably. |
 
 ## Default material captures
 
@@ -32,11 +32,11 @@ You can also activate MatCap view as a **Lighting Debug Mode** in the [Rendering
 
 ## MatCap examples
 
-MatCap off:
 ![](Images/MatCap2.png)
+MatCap off
 
-MatCap on:
 ![](Images/MatCap3.png)
+MatCap on
 
-MatCap on with albedo:
 ![](Images/MatCap4.png)
+MatCap on with albedo
@@ -6,8 +6,8 @@ Please refer to [Unity XR](https://docs.unity3d.com/Manual/XR.html) documentatio
 
 ## Recommended Settings
 
-HDRP has been designed to fully support Single-Pass Instanced mode. This mode gives you the best performance on all platforms.
-HDRP also supports multi-pass but this is slower on the CPU and some features, like Auto-Exposure, can cause issues.
+Unity has designed HDRP to fully support Single-Pass Instanced mode. This mode gives you the best performance on all platforms.
+HDRP also supports multi-pass but this is slower on the CPU and some features, like Auto Exposure, can cause issues.
 If you encounter a problem with a specific feature, you can disable it in your Project’s [HDRP Asset](HDRP-Asset.md).
 
 You can also watch the presentation from Unite Copenhagen (October 2019) to learn more tips: [Maximizing visual fidelity in VR: HDRP support](https://youtu.be/_WkSAn55EBM)
@@ -21,19 +21,20 @@ You can also watch the presentation from Unite Copenhagen (October 2019) to lear
   * PlayStationVR
   * Open VR*
 
-Note: Valve is currently developing their OpenVR Unity XR plugin for 2019.3 and beyond.
+**Note**: Valve is currently developing their OpenVR Unity XR plugin for 2019.3 and beyond.
 For more information, see [Unity XR platform updates](https://blogs.unity3d.com/2020/01/24/unity-xr-platform-updates/) on the Unity blog, and [XR Plugin Architecture](https://docs.unity3d.com/Manual/XRPluginArchitecture.html) in the Unity Manual.
 The XR Plugin architecture links to the OpenVR desktop package and has further info and recommendations.
 
 ## Resolution Control
-There are multiple methods that you can use to control the resolution of your render targets in HDRP, but be aware that HDRP does not support every method available in standard Unity using the built-in render pipeline. [XRSettings.renderViewportScale](https://docs.unity3d.com/ScriptReference/XR.XRSettings-renderViewportScale.html) has no effect in HDRP and generates a warning if you use it. Use one of the following methods instead:
+There are multiple methods that you can use to control the resolution of your render targets in HDRP, but be aware that HDRP doesn't support every method available in standard Unity using the built-in render pipeline. [XRSettings.renderViewportScale](https://docs.unity3d.com/ScriptReference/XR.XRSettings-renderViewportScale.html) has no effect in HDRP and generates a warning if you use it. Use one of the following methods instead:
 * **Dynamic Resolution**: You can use the [dynamic resolution system](Dynamic-Resolution.md) to change the resolution at runtime. This is the best method to use if you want to change the resolution at runtime.
 * **Eye Texture**: You can set the device back-buffer resolution by changing [XRSettings.eyeTextureResolutionScale](https://docs.unity3d.com/ScriptReference/XR.XRSettings-eyeTextureResolutionScale.html). This is a resource intensive operation that reallocates all render targets.
 
-Be aware that SteamVR will apply a default 150% supersampling value. You can change this value in the settings of SteamVR.?
+Be aware that SteamVR will apply a default 150% supersampling value. You can change this value in the settings of SteamVR.
+
 ## Enable VR single-pass after startup
 
-Due to some technical limitations that will be resolved in later versions, you need the following code in your script if your app does not boot directly in VR mode:
+**Note**: Due to some technical limitations that Unity will resolve in later versions of HDRP, you need the following code in your script if your app doesn't boot directly in VR mode:
 
 ```csharp
 private void Awake()
@@ -46,6 +47,6 @@ private void Awake()
 
 You can use the following defines to include or exclude code from your scripts.
 
-* ENABLE_VR: The C++ side of the engine sets this define to indicate if the platform supports VR.
+* ENABLE_VR: The C++ side of the engine sets this define to specify if the platform supports VR.
 * ENABLE_VR_MODULE: Unity sets this define if your Project includes the [built-in VR module com.unity.modules.vr](https://docs.unity3d.com/Manual/upm-ui-disable.html).
 * ENABLE_XR_MODULE: Unity sets this define if your Project includes the [built-in XR module com.unity.modules.xr](https://docs.unity3d.com/Manual/upm-ui-disable.html).
@@ -110,17 +110,17 @@ public void OnPreprocessMaterialDescription(MaterialDescription description, Mat
 
             if (description.TryGetProperty("Bump", out textureProperty) && textureProperty.texture != null)
             {
-                SetMaterialTextureProperty("_BumpMap", material, textureProperty);
+                SetMaterialTextureProperty("_NormalMap", material, textureProperty);
 
                 if (description.TryGetProperty("BumpFactor", out floatProperty))
-                    material.SetFloat("_BumpScale", floatProperty);
+                    material.SetFloat("_NormalScale", floatProperty);
             }
             else if (description.TryGetProperty("NormalMap", out textureProperty) && textureProperty.texture != null)
             {
-                SetMaterialTextureProperty("_BumpMap", material, textureProperty);
+                SetMaterialTextureProperty("_NormalMap", material, textureProperty);
 
                 if (description.TryGetProperty("BumpFactor", out floatProperty))
-                    material.SetFloat("_BumpScale", floatProperty);
+                    material.SetFloat("_NormalScale", floatProperty);
             }
 
             if (description.TryGetProperty("EmissiveColor", out textureProperty))
 
@@ -241,7 +241,8 @@ protected virtual LightingExplorerTableColumn[] GetHDLightColumns()
                 new LightingExplorerTableColumn(LightingExplorerTableColumn.DataType.Checkbox, HDStyles.ColorTemperatureMode, "m_UseColorTemperature", 150),        // 6: Color Temperature Mode
                 new LightingExplorerTableColumn(LightingExplorerTableColumn.DataType.Float, HDStyles.ColorTemperature, "m_ColorTemperature", 120, (r, prop, dep) => // 7: Color Temperature
                 {
-                    using (new EditorGUI.DisabledScope(!prop.serializedObject.FindProperty("m_UseColorTemperature").boolValue))
+                    // Sometimes during scene transition, the target object can be null, causing exceptions.
+                    using (new EditorGUI.DisabledScope(prop.serializedObject.targetObject == null || !prop.serializedObject.FindProperty("m_UseColorTemperature").boolValue))
                     {
                         EditorGUI.PropertyField(r, prop, GUIContent.none);
                     }
 
@@ -1051,7 +1051,8 @@ static void DrawShadowMapContent(SerializedHDLight serialized, Editor owner)
                     {
                         HDLightEditor editor = owner as HDLightEditor;
                         var additionalLightData = editor.GetAdditionalDataForTargetIndex(0);
-                        if (!HDCachedShadowManager.instance.LightHasBeenPlacedInAtlas(additionalLightData))
+                        // If the light was registered, but not placed it means it doesn't fit.
+                        if (additionalLightData.lightIdxForCachedShadows >= 0 && !HDCachedShadowManager.instance.LightHasBeenPlacedInAtlas(additionalLightData))
                         {
                             string warningMessage = "The shadow for this light doesn't fit the cached shadow atlas and therefore won't be rendered. Please ensure you have enough space in the cached shadow atlas. You can use the light explorer (Window->Rendering->Light Explorer) to see which lights fit and which don't.\nConsult HDRP Shadow documentation for more information about cached shadow management.";
                             // Loop backward in "tile" size to check
 
@@ -0,0 +1,17 @@
+Pass
+{		
+	Tags { "LightMode"="DepthForwardOnly" }
+
+	ZWrite On
+	Blend Off
+	
+	HLSLPROGRAM
+	#define VFX_PASSDEPTH VFX_PASSDEPTH_ACTUAL
+	#pragma multi_compile _ WRITE_NORMAL_BUFFER
+    #pragma multi_compile _ WRITE_DECAL_BUFFER
+    #pragma multi_compile _ WRITE_MSAA_DEPTH
+	${VFXIncludeRP("Templates/Mesh/PassDepthOrMV.template")}
+
+
+	ENDHLSL
+}
Original file line number	Diff line number	Diff line change
`@@ -110,17 +110,17 @@ public void OnPreprocessMaterialDescription(MaterialDescription description, Mat`
`110`	`110`
`111`	`111`	`if (description.TryGetProperty("Bump", out textureProperty) && textureProperty.texture != null)`
`112`	`112`	`{`
`113`		`- SetMaterialTextureProperty("_BumpMap", material, textureProperty);`
	`113`	`+ SetMaterialTextureProperty("_NormalMap", material, textureProperty);`
`114`	`114`
`115`	`115`	`if (description.TryGetProperty("BumpFactor", out floatProperty))`
`116`		`- material.SetFloat("_BumpScale", floatProperty);`
	`116`	`+ material.SetFloat("_NormalScale", floatProperty);`
`117`	`117`	`}`
`118`	`118`	`else if (description.TryGetProperty("NormalMap", out textureProperty) && textureProperty.texture != null)`
`119`	`119`	`{`
`120`		`- SetMaterialTextureProperty("_BumpMap", material, textureProperty);`
	`120`	`+ SetMaterialTextureProperty("_NormalMap", material, textureProperty);`
`121`	`121`
`122`	`122`	`if (description.TryGetProperty("BumpFactor", out floatProperty))`
`123`		`- material.SetFloat("_BumpScale", floatProperty);`
	`123`	`+ material.SetFloat("_NormalScale", floatProperty);`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`if (description.TryGetProperty("EmissiveColor", out textureProperty))`
Original file line number	Diff line number	Diff line change
`@@ -241,7 +241,8 @@ protected virtual LightingExplorerTableColumn[] GetHDLightColumns()`
`241`	`241`	`new LightingExplorerTableColumn(LightingExplorerTableColumn.DataType.Checkbox, HDStyles.ColorTemperatureMode, "m_UseColorTemperature", 150), // 6: Color Temperature Mode`
`242`	`242`	`new LightingExplorerTableColumn(LightingExplorerTableColumn.DataType.Float, HDStyles.ColorTemperature, "m_ColorTemperature", 120, (r, prop, dep) => // 7: Color Temperature`
`243`	`243`	`{`
`244`		`- using (new EditorGUI.DisabledScope(!prop.serializedObject.FindProperty("m_UseColorTemperature").boolValue))`
	`244`	`+ // Sometimes during scene transition, the target object can be null, causing exceptions.`
	`245`	`+ using (new EditorGUI.DisabledScope(prop.serializedObject.targetObject == null \|\| !prop.serializedObject.FindProperty("m_UseColorTemperature").boolValue))`
`245`	`246`	`{`
`246`	`247`	`EditorGUI.PropertyField(r, prop, GUIContent.none);`
`247`	`248`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1051,7 +1051,8 @@ static void DrawShadowMapContent(SerializedHDLight serialized, Editor owner)`
`1051`	`1051`	`{`
`1052`	`1052`	`HDLightEditor editor = owner as HDLightEditor;`
`1053`	`1053`	`var additionalLightData = editor.GetAdditionalDataForTargetIndex(0);`
`1054`		`- if (!HDCachedShadowManager.instance.LightHasBeenPlacedInAtlas(additionalLightData))`
	`1054`	`+ // If the light was registered, but not placed it means it doesn't fit.`
	`1055`	`+ if (additionalLightData.lightIdxForCachedShadows >= 0 && !HDCachedShadowManager.instance.LightHasBeenPlacedInAtlas(additionalLightData))`
`1055`	`1056`	`{`
`1056`	`1057`	`string warningMessage = "The shadow for this light doesn't fit the cached shadow atlas and therefore won't be rendered. Please ensure you have enough space in the cached shadow atlas. You can use the light explorer (Window->Rendering->Light Explorer) to see which lights fit and which don't.\nConsult HDRP Shadow documentation for more information about cached shadow management.";`
`1057`	`1058`	`// Loop backward in "tile" size to check`