-
Notifications
You must be signed in to change notification settings - Fork 13k
feat: Replace rc-scrollbars in favor of overlayscrollbars
#33796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: df52273 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33796 +/- ##
===========================================
- Coverage 59.46% 59.43% -0.03%
===========================================
Files 2830 2828 -2
Lines 68512 68200 -312
Branches 15163 15100 -63
===========================================
- Hits 40744 40538 -206
+ Misses 25107 25014 -93
+ Partials 2661 2648 -13
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
1bd09a3 to
2624f09
Compare
rc-scrollbars in favor of overlayscrollbars
7092d5f to
1e2775b
Compare
Proposed changes (including videos or screenshots)
Our current custom scrollbars doesn't have support to RTL. So this PR aims to replace the usage of
rc-scrollbarsin favor ofoverlayScrollbarswhich does support. So doing it we'll be able to fix some a11y when using RTL languagesTO-DO
rc-scrollbarsrc-scrollbarsCSS codeRoomHistoryManagerwill work removing the.rc-scrollbars-viewclassuseLegacyThreadMessageListScrollingwill work properly when replacing theScrollValuestypeCustomScrollbarsBefore
After
It also fixes such small annoying visual issues:
Issue(s)
Closes #30564
Closes #30095
Closes #29359
Steps to test or reproduce
Further comments
CORE-1008