Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Oct 25, 2024

Proposed changes (including videos or screenshots)

Our current custom scrollbars doesn't have support to RTL. So this PR aims to replace the usage of rc-scrollbars in favor of overlayScrollbars which does support. So doing it we'll be able to fix some a11y when using RTL languages

TO-DO

  • Remove rc-scrollbars
  • Remove rc-scrollbars CSS code
  • Make sure RoomHistoryManager will work removing the .rc-scrollbars-view class
  • Make sure useLegacyThreadMessageListScrolling will work properly when replacing the ScrollValues type
  • Run some brute force tests in all places that uses CustomScrollbars

Before

Kapture 2024-10-25 at 19 26 47

After

Kapture 2024-10-25 at 19 23 48

It also fixes such small annoying visual issues:

Issue(s)

Closes #30564
Closes #30095
Closes #29359

Steps to test or reproduce

Further comments

CORE-1008

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 25, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: df52273

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33796/

Built to branch gh-pages at 2025-03-07 18:15 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@dougfabris dougfabris added this to the 7.1.0 milestone Oct 25, 2024
@codecov
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.43%. Comparing base (d6a8fad) to head (df52273).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33796      +/-   ##
===========================================
- Coverage    59.46%   59.43%   -0.03%     
===========================================
  Files         2830     2828       -2     
  Lines        68512    68200     -312     
  Branches     15163    15100      -63     
===========================================
- Hits         40744    40538     -206     
+ Misses       25107    25014      -93     
+ Partials      2661     2648      -13     
Flag Coverage Δ
unit 75.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan modified the milestones: 7.1.0, 7.2.0 Nov 25, 2024
@dougfabris dougfabris modified the milestones: 7.2.0, 7.3.0 Dec 20, 2024
@dougfabris dougfabris removed this from the 7.3.0 milestone Jan 16, 2025
@dougfabris dougfabris added this to the 7.5.0 milestone Feb 28, 2025
@dougfabris dougfabris changed the title fix: Scrollbars not working properly in RTL languages feat: Replace rc-scrollbars in favor of overlayscrollbars Feb 28, 2025
@dougfabris dougfabris marked this pull request as ready for review February 28, 2025 14:03
@dougfabris dougfabris requested review from a team as code owners February 28, 2025 14:04
@MartinSchoeler MartinSchoeler self-requested a review March 7, 2025 17:12
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Mar 7, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Horizontal scrollbars does not work in RTL languages UI problems in RTL languages WHAT is Rocket.Chat doing with scrollbars? (a11y and UI problem)

4 participants