Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Mar 18, 2025

Proposed changes (including videos or screenshots)

Introduced here: #33796

Screenshot 2025-03-19 at 11 06 02

Issue(s)

Steps to test or reproduce

Further comments

CORE-1030

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 18, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2025

⚠️ No Changeset found

Latest commit: a13ceb4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35550/

Built to branch gh-pages at 2025-03-20 10:54 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.67%. Comparing base (4ce0038) to head (a13ceb4).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35550   +/-   ##
========================================
  Coverage    59.67%   59.67%           
========================================
  Files         2826     2826           
  Lines        68313    68313           
  Branches     15134    15134           
========================================
  Hits         40764    40764           
  Misses       24937    24937           
  Partials      2612     2612           
Flag Coverage Δ
unit 75.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris added this to the 7.5.0 milestone Mar 19, 2025
@dougfabris dougfabris marked this pull request as ready for review March 19, 2025 22:26
@dougfabris dougfabris requested a review from a team as a code owner March 19, 2025 22:26
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Mar 19, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 19, 2025
@kodiakhq kodiakhq bot merged commit c862926 into develop Mar 20, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the reg/wrong-scrollbar branch March 20, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants