Skip to content

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 14, 2025

introduced here #33796

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 14, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2025

⚠️ No Changeset found

Latest commit: 04d70aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo added this to the 7.5.0 milestone Mar 14, 2025
@ggazzo ggazzo marked this pull request as ready for review March 14, 2025 00:39
@ggazzo ggazzo requested a review from a team as a code owner March 14, 2025 00:39
@github-actions
Copy link
Contributor

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35496/

Built to branch gh-pages at 2025-03-14 00:40 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.64%. Comparing base (b53faf5) to head (04d70aa).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35496   +/-   ##
========================================
  Coverage    59.64%   59.64%           
========================================
  Files         2827     2827           
  Lines        68475    68475           
  Branches     15177    15177           
========================================
  Hits         40839    40839           
  Misses       24989    24989           
  Partials      2647     2647           
Flag Coverage Δ
unit 75.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo changed the title regression: fix scroll disappearing if list is empty regression: Scroll List not visible Mar 14, 2025
@ggazzo ggazzo merged commit d293d50 into develop Mar 14, 2025
46 of 50 checks passed
@ggazzo ggazzo deleted the regression/fix-scroll branch March 14, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants