Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Aug 23, 2025

Proposed changes (including videos or screenshots)

Introduced here: #33796

When we did the refactor, Virtuoso had a overflow: hidden, that was there for an unknown reason and with the implementation of overlayscrollbars this prop took an undesirable behavior of hidden the overflow

before

Kapture 2025-08-23 at 17 43 39

after

Kapture 2025-08-23 at 17 42 43

Issue(s)

Steps to test or reproduce

Further comments

CORE-1299

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 23, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.11.0, but it targets 7.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2025

🦋 Changeset detected

Latest commit: 50f626a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris added this to the 7.11.0 milestone Aug 23, 2025
@codecov
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.11%. Comparing base (80fbb2e) to head (50f626a).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36780      +/-   ##
===========================================
- Coverage    66.12%   66.11%   -0.02%     
===========================================
  Files         3301     3301              
  Lines       110939   110939              
  Branches     21044    21040       -4     
===========================================
- Hits         73362    73343      -19     
- Misses       34902    34920      +18     
- Partials      2675     2676       +1     
Flag Coverage Δ
e2e 57.29% <ø> (-0.03%) ⬇️
unit 71.44% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris marked this pull request as ready for review August 25, 2025 14:40
@dougfabris dougfabris requested a review from a team as a code owner August 25, 2025 14:40
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Aug 25, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 25, 2025
@kodiakhq kodiakhq bot merged commit cad0688 into develop Aug 25, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the fix/discussion-list-scroll branch August 25, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants