Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Mar 26, 2025

Proposed changes (including videos or screenshots)

Introduced here: #33796

Theres a ContextualbarScrollabeContent being used incorrectly in a loading state when editing a omnichannel room. As we recently changed how we handle our scrollbars, the GUI is crashing when accessing it.

Issue(s)

Steps to test or reproduce

  • Open a Omnichannel Room
  • Try to edit the room information
  • The GUI should not crash

Further comments

CORE-1046

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 26, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 26, 2025

⚠️ No Changeset found

Latest commit: 2009ee8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris changed the base branch from develop to release-7.5.0 March 26, 2025 12:55
@github-actions
Copy link
Contributor

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35624/

Built to branch gh-pages at 2025-03-26 13:10 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.74%. Comparing base (c862926) to head (2009ee8).
Report is 16 commits behind head on release-7.5.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.5.0   #35624      +/-   ##
=================================================
+ Coverage          59.67%   59.74%   +0.06%     
=================================================
  Files               2826     2830       +4     
  Lines              68313    68434     +121     
  Branches           15134    15177      +43     
=================================================
+ Hits               40764    40883     +119     
  Misses             24937    24937              
- Partials            2612     2614       +2     
Flag Coverage Δ
unit 75.92% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris added this to the 7.5.0 milestone Mar 26, 2025
@dougfabris dougfabris changed the title regression: ScrollableContent being rendered in loading state regression: GUI crashing when editing a OC room Mar 26, 2025
@dougfabris dougfabris marked this pull request as ready for review March 26, 2025 18:16
@dougfabris dougfabris requested a review from a team as a code owner March 26, 2025 18:16
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Mar 26, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 26, 2025
@kodiakhq kodiakhq bot merged commit 1df4ea9 into release-7.5.0 Mar 26, 2025
51 checks passed
@kodiakhq kodiakhq bot deleted the reg/oc-room-edit branch March 26, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants