fix: Text area only shows the last line of the message for very long texts #31252 #31257 by Sayan4444 · Pull Request #31262 · RocketChat/Rocket.Chat

Sayan4444 · 2023-12-18T04:54:56Z

Proposed changes (including videos or screenshots)

Video AFTER the fix made by me (My proposed changes):-
https://github.com/RocketChat/Rocket.Chat/assets/112304873/e2576610-c5d5-4d36-9d73-411512e2b3b1

Before when we wrote some long text in the textarea of the chat directory and go to someother page and comeback, we used to get a glitched textarea where we CANT EVEN SCROLL through the bigger texts and the textarea appears in ONE LINE.

Video BEFORE the fix made by me (Issue video):-
https://github.com/RocketChat/Rocket.Chat/assets/112304873/41a51600-6145-4fcf-8957-d4f6e9bfa05d

Now after the fix, when we leave the page where we had the big text and comeback, we get the SAME SIZE OF THE TEXTBOX we got when we initailly left it and can SEAMLESSLY SCROLL. It doesnot appear glitchy.

Issue(s)

This should close issues :-
fix #31252
fix #31257
fix #30965

Steps to test or reproduce

Go to a channel
Write some huge multiline text
Go to a separate channel/anywhere even refresh will work and comeback

Further comments

…hed to any other page

changeset-bot · 2023-12-18T04:55:00Z

⚠️ No Changeset found

Latest commit: f53b6cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

CLAassistant · 2023-12-18T04:55:02Z

All committers have signed the CLA.

hugocostadev · 2023-12-22T17:22:56Z

Thanks for your contribution, I'm going to review this PR

Questions? Help needed? Feature Requests?

Join our Open Server in the #support channel and feel free to raise a question
Join our Community Forum and search/create a post there
Feature Request: Open an issue in Feature Request repository

codecov · 2023-12-22T17:24:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d6cf47) 49.36% compared to head (f53b6cf) 49.33%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #31262      +/-   ##
===========================================
- Coverage    49.36%   49.33%   -0.04%     
===========================================
  Files         3310     3308       -2     
  Lines        81302    81299       -3     
  Branches     16651    16650       -1     
===========================================
- Hits         40138    40105      -33     
- Misses       36470    36498      +28     
- Partials      4694     4696       +2

Flag	Coverage Δ
e2e	`52.49% <100.00%> (-0.10%)`	⬇️
e2e-api	`40.65% <ø> (-0.02%)`	⬇️
unit	`76.64% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Sayan4444 · 2023-12-24T16:29:59Z

Is it still on check? or did I do something wrong? @hugocostadev

… into textarea-bug

hugocostadev

Looks good for me!

Thanks a lot for your contribution man! 🚀

…cacheStreams * 'develop' of github.com:RocketChat/Rocket.Chat: fix: Text area only shows the last line of the message for very long texts #31252 #31257 (#31262)

…hideUi * 'develop' of github.com:RocketChat/Rocket.Chat: (112 commits) chore: update yarn.lock chore: Replace `FramedIcon` in favor of fuselage component (#31356) chore: fix dep version Release 6.5.2 fix: wrong value used for workspace registration ci: update release PR description with change log fix: inquiries being limited to 50 items (#31267) fix: close image gallery on backdrop click (#31344) fix: No error message when uploading a file that is not allowed (#31346) fix: Text area only shows the last line of the message for very long texts #31252 #31257 (#31262) chore: adding new streamer event for imported messages (#31063) chore: adapt read receipts feature to work without oplog on msgs (#30996) chore: remove Messages model dependency of Rooms model (#31272) chore: `Card` normalization (#31335) refactor: unify useStream and useSingleStream (#31326) chore: add new msg stream for reported msgs (#31087) Bump 6.5.2 feat: Highlight words in thread messages (#31281) fix: Show only departments that are allowed on registration page on livechat widget (#31302) fix: Fallback forward department not working as expected on chat forwarding (#31296) ...

fix for :Text area only shows the last line of the message when switc…

9ed8c14

…hed to any other page

Sayan4444 requested a review from a team as a code owner December 18, 2023 04:54

dionisio-bot Bot added the stat: needs QA label Dec 18, 2023

Merge branch 'develop' into textarea-bug

586122f

Sayan4444 and others added 3 commits December 31, 2023 11:28

fixed linting error

f82dd66

Merge branch 'RocketChat:develop' into textarea-bug

98e51cd

Merge branch 'textarea-bug' of https://github.com/Sayan4444/Rocket.Chat…

f53b6cf

… into textarea-bug

hugocostadev added the community label Jan 2, 2024

hugocostadev approved these changes Jan 2, 2024

View reviewed changes

hugocostadev added the stat: QA skipped label Jan 2, 2024

dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 2, 2024

kodiakhq Bot merged commit 92a8de7 into RocketChat:develop Jan 2, 2024

Sayan4444 deleted the textarea-bug branch January 2, 2024 15:04

dougfabris added this to the 6.6 milestone Jan 3, 2024

dougfabris mentioned this pull request Jan 4, 2024

fix: Text area only shows the last line of the message #31259

Closed

Navigation Menu

Uh oh!

fix: Text area only shows the last line of the message for very long texts #31252 #31257 - #31262

fix: Text area only shows the last line of the message for very long texts #31252 #31257#31262
kodiakhq[bot] merged 5 commits into
RocketChat:developfrom
Sayan4444:textarea-bug

Sayan4444 commented Dec 18, 2023 •

edited

Loading

Uh oh!

changeset-bot Bot commented Dec 18, 2023 •

edited

Loading

Uh oh!

CLAassistant commented Dec 18, 2023 •

edited

Loading

Uh oh!

hugocostadev commented Dec 22, 2023

Uh oh!

codecov Bot commented Dec 22, 2023 •

edited

Loading

Uh oh!

Sayan4444 commented Dec 24, 2023

Uh oh!

hugocostadev left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Sayan4444 commented Dec 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

changeset-bot Bot commented Dec 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

CLAassistant commented Dec 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hugocostadev commented Dec 22, 2023

Uh oh!

codecov Bot commented Dec 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Sayan4444 commented Dec 24, 2023

Uh oh!

hugocostadev left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sayan4444 commented Dec 18, 2023 •

edited

Loading

changeset-bot Bot commented Dec 18, 2023 •

edited

Loading

CLAassistant commented Dec 18, 2023 •

edited

Loading

codecov Bot commented Dec 22, 2023 •

edited

Loading