Skip to content

fix: Text area only shows the last line of the message for very long texts #31252 #31257 #31262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 5 commits into from
Jan 2, 2024
Merged

fix: Text area only shows the last line of the message for very long texts #31252 #31257 #31262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ed8c14
fix for :Text area only shows the last line of the message when switc…
Sayan4444 Dec 18, 2023
586122f
Merge branch 'develop' into textarea-bug
hugocostadev Dec 22, 2023
f82dd66
fixed linting error
Sayan4444 Dec 31, 2023
98e51cd
Merge branch 'RocketChat:develop' into textarea-bug
Sayan4444 Dec 31, 2023
f53b6cf
Merge branch 'textarea-bug' of https://github.com/Sayan4444/Rocket.Ch…
Sayan4444 Dec 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions apps/meteor/client/views/room/composer/RoomComposer/hooks/useAutoGrow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const shadowStyleBase: CSSProperties = {

export const useAutoGrow = (
ref: RefObject<HTMLTextAreaElement>,
shadowRef: RefObject<HTMLTextAreaElement>,
shadowRef: RefObject<HTMLDivElement>,
hideTextArea?: boolean,
): {
textAreaStyle: CSSProperties;
Expand All @@ -37,8 +37,7 @@ export const useAutoGrow = (
if (!textarea) {
return;
}

const handleInput = () => {
const updateTextareaSize = () => {
const { value } = textarea;
const { current: shadow } = shadowRef;
if (!shadow) {
Expand All @@ -51,10 +50,10 @@ export const useAutoGrow = (
.replace(/\n$/, '<br/>&nbsp;')
.replace(/\n/g, '<br/>');
};

textarea.addEventListener('input', handleInput);
updateTextareaSize();
textarea.addEventListener('input', updateTextareaSize);
return () => {
textarea.removeEventListener('input', handleInput);
textarea.removeEventListener('input', updateTextareaSize);
};
}, [ref, shadowRef]);

Expand Down
2 changes: 1 addition & 1 deletion apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ const MessageBox = ({

const textareaRef = useRef<HTMLTextAreaElement>(null);
const messageComposerRef = useRef<HTMLElement>(null);
const shadowRef = useRef(null);
const shadowRef = useRef<HTMLDivElement>(null);

const storageID = `messagebox_${room._id}${tmid ? `-${tmid}` : ''}`;

Expand Down