Skip to content

chore: Replace FramedIcon in favor of fuselage component - #31356

Merged
kodiakhq[bot] merged 6 commits into
developfrom
chore/framedIcon
Jan 3, 2024
Merged

chore: Replace FramedIcon in favor of fuselage component#31356
kodiakhq[bot] merged 6 commits into
developfrom
chore/framedIcon

Conversation

@juliajforesti

@juliajforesti juliajforesti commented Jan 2, 2024

Copy link
Copy Markdown
Contributor

DSAR-409

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot

changeset-bot Bot commented Jan 2, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 47959de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Jan 2, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2706072) 49.35% compared to head (47959de) 49.39%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31356      +/-   ##
===========================================
+ Coverage    49.35%   49.39%   +0.03%     
===========================================
  Files         3310     3310              
  Lines        81306    81334      +28     
  Branches     16651    16657       +6     
===========================================
+ Hits         40129    40175      +46     
+ Misses       36476    36464      -12     
+ Partials      4701     4695       -6     
Flag Coverage Δ
e2e 52.64% <66.66%> (+0.07%) ⬆️
e2e-api 40.67% <ø> (+0.02%) ⬆️
unit 76.67% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti
juliajforesti marked this pull request as ready for review January 2, 2024 21:43
@juliajforesti
juliajforesti requested a review from a team as a code owner January 2, 2024 21:43
@dougfabris dougfabris changed the title chore: replace with FramedIcon from fuselage chore: Replace FramedIcon in favor of fuselage component Jan 2, 2024
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 3, 2024
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jan 3, 2024
@kodiakhq
kodiakhq Bot merged commit 505b67e into develop Jan 3, 2024
@kodiakhq
kodiakhq Bot deleted the chore/framedIcon branch January 3, 2024 14:07
gabriellsh added a commit that referenced this pull request Jan 3, 2024
…hideUi

* 'develop' of github.com:RocketChat/Rocket.Chat: (112 commits)
  chore: update yarn.lock
  chore: Replace `FramedIcon` in favor of fuselage component (#31356)
  chore: fix dep version
  Release 6.5.2
  fix: wrong value used for workspace registration
  ci: update release PR description with change log
  fix: inquiries being limited to 50 items (#31267)
  fix: close image gallery on backdrop click (#31344)
  fix: No error message when uploading a file that is not allowed (#31346)
  fix: Text area only shows the last line of the message for very long texts #31252 #31257 (#31262)
  chore: adding new streamer event for imported messages (#31063)
  chore: adapt read receipts feature to work without oplog on msgs (#30996)
  chore: remove Messages model dependency of Rooms model (#31272)
  chore: `Card` normalization (#31335)
  refactor: unify useStream and useSingleStream (#31326)
  chore: add new msg stream for reported msgs (#31087)
  Bump 6.5.2
  feat: Highlight words in thread messages (#31281)
  fix: Show only departments that are allowed on registration page on livechat widget (#31302)
  fix: Fallback forward department not working as expected on chat forwarding (#31296)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants