Skip to content

refactor: unify useStream and useSingleStream - #31326

Merged
ggazzo merged 4 commits into
developfrom
chore/replaceUseStream
Dec 28, 2023
Merged

refactor: unify useStream and useSingleStream#31326
ggazzo merged 4 commits into
developfrom
chore/replaceUseStream

Conversation

@gabriellsh

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@gabriellsh
gabriellsh requested a review from a team as a code owner December 27, 2023 13:25
@changeset-bot

changeset-bot Bot commented Dec 27, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2778c7f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gabriellsh gabriellsh changed the title refactor: replace useStream with useSingleStream chore: replace useStream with useSingleStream Dec 27, 2023
@codecov

codecov Bot commented Dec 27, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (371698e) 49.36% compared to head (2778c7f) 49.32%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31326      +/-   ##
===========================================
- Coverage    49.36%   49.32%   -0.05%     
===========================================
  Files         3308     3307       -1     
  Lines        81259    81247      -12     
  Branches     16643    16644       +1     
===========================================
- Hits         40113    40073      -40     
- Misses       36451    36474      +23     
- Partials      4695     4700       +5     
Flag Coverage Δ
e2e 52.46% <90.47%> (-0.11%) ⬇️
e2e-api 40.65% <ø> (-0.02%) ⬇️
unit 76.64% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabriellsh gabriellsh changed the title chore: replace useStream with useSingleStream refactor: unify useStream and useSingleStream Dec 27, 2023
ggazzo
ggazzo previously approved these changes Dec 27, 2023
@ggazzo
ggazzo merged commit 6f48470 into develop Dec 28, 2023
@ggazzo
ggazzo deleted the chore/replaceUseStream branch December 28, 2023 19:06
gabriellsh added a commit that referenced this pull request Jan 3, 2024
…hideUi

* 'develop' of github.com:RocketChat/Rocket.Chat: (112 commits)
  chore: update yarn.lock
  chore: Replace `FramedIcon` in favor of fuselage component (#31356)
  chore: fix dep version
  Release 6.5.2
  fix: wrong value used for workspace registration
  ci: update release PR description with change log
  fix: inquiries being limited to 50 items (#31267)
  fix: close image gallery on backdrop click (#31344)
  fix: No error message when uploading a file that is not allowed (#31346)
  fix: Text area only shows the last line of the message for very long texts #31252 #31257 (#31262)
  chore: adding new streamer event for imported messages (#31063)
  chore: adapt read receipts feature to work without oplog on msgs (#30996)
  chore: remove Messages model dependency of Rooms model (#31272)
  chore: `Card` normalization (#31335)
  refactor: unify useStream and useSingleStream (#31326)
  chore: add new msg stream for reported msgs (#31087)
  Bump 6.5.2
  feat: Highlight words in thread messages (#31281)
  fix: Show only departments that are allowed on registration page on livechat widget (#31302)
  fix: Fallback forward department not working as expected on chat forwarding (#31296)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants