chore: remove Messages model dependency of Rooms model - #31272
Merged
sampaiodiego merged 4 commits intoDec 29, 2023
Conversation
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #31272 +/- ##
===========================================
- Coverage 49.34% 49.33% -0.02%
===========================================
Files 3306 3308 +2
Lines 81233 81273 +40
Branches 16642 16646 +4
===========================================
+ Hits 40086 40092 +6
- Misses 36452 36487 +35
+ Partials 4695 4694 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
dionisio-bot
Bot
added
stat: ready to merge
dionisio-bot
Bot
added
stat: ready to merge
ggazzo
previously approved these changes
Dec 28, 2023
KevLehman
previously approved these changes
Dec 28, 2023
dionisio-bot
Bot
added
stat: ready to merge
pierre-lehnen-rc
requested changes
Dec 28, 2023
dionisio-bot
Bot
added
stat: ready to merge
pierre-lehnen-rc
approved these changes
Dec 28, 2023
sampaiodiego
deleted the
chore-remove-rooms-dependency-from-msg-model
branch
December 29, 2023 13:25
gabriellsh
added a commit
that referenced
this pull request
Jan 3, 2024
…hideUi * 'develop' of github.com:RocketChat/Rocket.Chat: (112 commits) chore: update yarn.lock chore: Replace `FramedIcon` in favor of fuselage component (#31356) chore: fix dep version Release 6.5.2 fix: wrong value used for workspace registration ci: update release PR description with change log fix: inquiries being limited to 50 items (#31267) fix: close image gallery on backdrop click (#31344) fix: No error message when uploading a file that is not allowed (#31346) fix: Text area only shows the last line of the message for very long texts #31252 #31257 (#31262) chore: adding new streamer event for imported messages (#31063) chore: adapt read receipts feature to work without oplog on msgs (#30996) chore: remove Messages model dependency of Rooms model (#31272) chore: `Card` normalization (#31335) refactor: unify useStream and useSingleStream (#31326) chore: add new msg stream for reported msgs (#31087) Bump 6.5.2 feat: Highlight words in thread messages (#31281) fix: Show only departments that are allowed on registration page on livechat widget (#31302) fix: Fallback forward department not working as expected on chat forwarding (#31296) ...
ggazzo
pushed a commit
that referenced
this pull request
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Previously the
Messagemodel used to interact directly with theRoommodel, which is not ideal, since models shouldn't know about the business logic of the application.This change also helped finding some places where multiple changes to the same room object were being performed one right after the other, so I improved that as well by performing a single operation.
Issue(s)
Steps to test or reproduce
Further comments