Skip to content

chore: ImageGallery tweaks - #31159

Merged
ggazzo merged 1 commit into
developfrom
chore/imageGallery
Dec 5, 2023
Merged

chore: ImageGallery tweaks#31159
ggazzo merged 1 commit into
developfrom
chore/imageGallery

Conversation

@juliajforesti

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

  • change Throbber color
  • loading position absolute to prevent displacement on loading heavy images

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot

changeset-bot Bot commented Dec 5, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 13f649c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Dec 5, 2023

Copy link
Copy Markdown

Codecov Report

Merging #31159 (13f649c) into develop (a7bee82) will increase coverage by 1.08%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31159      +/-   ##
===========================================
+ Coverage    57.18%   58.27%   +1.08%     
===========================================
  Files          880     1760     +880     
  Lines        19925    33639   +13714     
  Branches      3719     6907    +3188     
===========================================
+ Hits         11395    19604    +8209     
- Misses        7841    12498    +4657     
- Partials       689     1537     +848     
Flag Coverage Δ
e2e 51.48% <ø> (+9.11%) ⬆️
unit 76.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti
juliajforesti marked this pull request as ready for review December 5, 2023 15:29
@juliajforesti
juliajforesti requested a review from a team as a code owner December 5, 2023 15:29
@ggazzo
ggazzo merged commit e6323be into develop Dec 5, 2023
@ggazzo
ggazzo deleted the chore/imageGallery branch December 5, 2023 16:24
gabriellsh added a commit that referenced this pull request Dec 7, 2023
…hideUi

* 'develop' of github.com:RocketChat/Rocket.Chat: (21 commits)
  chore: Rename useFileInput to useSingleFileInput (#31186)
  regression: FED-116 allow to invite rc users to fed channels (#30658)
  refactor: Remove `livechat.js` file (#31179)
  test: Fix Analytics test to use always same date (#31178)
  chore: notify messages on emails incoming and outgoing (#30925)
  chore: add msg stream to the federation v1 feature (#31105)
  chore: update editedBy when the user changes their username (following BE rules) (#31098)
  chore: add a manual msg stream update for autotranslate (#31094)
  chore: send streaming msg update on livechat decline call event (#31025)
  chore: Replace `IconButton` in favor of `Button` on `PageHeader` (#31171)
  refactor: Migrate `analytics.js` to service (#31051)
  feat: Add `push.info` endpoint to retrieve push gateway info (#30868)
  chore: Convert Importer classes to typescript (#29714)
  docs: fix lost image render in markdown (#31013)
  feat(uikit): Move `@rocket.chat/ui-kit` package to the main monorepo (#31138)
  i18n: Language update from LingoHub 🤖 on 2023-12-05Z (#31161)
  feat: Skip to main content shortcut and `useDocumentTitle` (#30680)
  chore: Replace `useForm` in favor of RHF on Omnichannel `AgentsEdit` (#30789)
  chore: ImageGallery tweaks (#31159)
  fix: New `custom-roles` license module isn't properly checked (#31153)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants