Skip to content

chore: Replace useForm in favor of RHF on Omnichannel AgentsEdit - #30789

Merged
ggazzo merged 4 commits into
developfrom
chore/omnichannel-agents-form
Dec 5, 2023
Merged

chore: Replace useForm in favor of RHF on Omnichannel AgentsEdit#30789
ggazzo merged 4 commits into
developfrom
chore/omnichannel-agents-form

Conversation

@dougfabris

@dougfabris dougfabris commented Oct 27, 2023

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

  • Replace useForm in favor of RHF
  • Refactor some components to TS
  • Replace useQuery in favor of useEndpointData
  • Replace deprecated useRoute in favor of useRouter
  • Add a11y support to the forms

Issue(s)

Steps to test or reproduce

Further comments

DSAR-326
DSAR-336

@changeset-bot

changeset-bot Bot commented Oct 27, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: cc500f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Oct 27, 2023

Copy link
Copy Markdown

Codecov Report

Merging #30789 (cc500f1) into develop (e6323be) will decrease coverage by 8.50%.
The diff coverage is 83.83%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30789      +/-   ##
===========================================
- Coverage    57.18%   48.69%   -8.50%     
===========================================
  Files          880     3276    +2396     
  Lines        19925    79958   +60033     
  Branches      3719    16009   +12290     
===========================================
+ Hits         11395    38937   +27542     
- Misses        7841    36444   +28603     
- Partials       689     4577    +3888     
Flag Coverage Δ
e2e 51.33% <83.83%> (+8.95%) ⬆️
e2e-api 40.75% <ø> (?)
unit 76.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris
dougfabris marked this pull request as ready for review December 5, 2023 18:35
@dougfabris
dougfabris requested review from a team as code owners December 5, 2023 18:35
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 5, 2023
@ggazzo
ggazzo merged commit 0681c45 into develop Dec 5, 2023
@ggazzo
ggazzo deleted the chore/omnichannel-agents-form branch December 5, 2023 19:39
gabriellsh added a commit that referenced this pull request Dec 7, 2023
…hideUi

* 'develop' of github.com:RocketChat/Rocket.Chat: (21 commits)
  chore: Rename useFileInput to useSingleFileInput (#31186)
  regression: FED-116 allow to invite rc users to fed channels (#30658)
  refactor: Remove `livechat.js` file (#31179)
  test: Fix Analytics test to use always same date (#31178)
  chore: notify messages on emails incoming and outgoing (#30925)
  chore: add msg stream to the federation v1 feature (#31105)
  chore: update editedBy when the user changes their username (following BE rules) (#31098)
  chore: add a manual msg stream update for autotranslate (#31094)
  chore: send streaming msg update on livechat decline call event (#31025)
  chore: Replace `IconButton` in favor of `Button` on `PageHeader` (#31171)
  refactor: Migrate `analytics.js` to service (#31051)
  feat: Add `push.info` endpoint to retrieve push gateway info (#30868)
  chore: Convert Importer classes to typescript (#29714)
  docs: fix lost image render in markdown (#31013)
  feat(uikit): Move `@rocket.chat/ui-kit` package to the main monorepo (#31138)
  i18n: Language update from LingoHub 🤖 on 2023-12-05Z (#31161)
  feat: Skip to main content shortcut and `useDocumentTitle` (#30680)
  chore: Replace `useForm` in favor of RHF on Omnichannel `AgentsEdit` (#30789)
  chore: ImageGallery tweaks (#31159)
  fix: New `custom-roles` license module isn't properly checked (#31153)
  ...
@dougfabris dougfabris added this to the 6.6 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants