Skip to content

Conversation

@dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #27061 (f7c69f5) into develop (a0077e5) will decrease coverage by 0.68%.
The diff coverage is 20.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27061      +/-   ##
===========================================
- Coverage    41.21%   40.53%   -0.69%     
===========================================
  Files          803      828      +25     
  Lines        17824    18264     +440     
  Branches      1971     2033      +62     
===========================================
+ Hits          7346     7403      +57     
- Misses       10183    10564     +381     
- Partials       295      297       +2     
Flag Coverage Δ
e2e 40.53% <20.00%> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review October 14, 2022 14:02
@dougfabris dougfabris requested a review from a team as a code owner October 14, 2022 14:02
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 14, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Oct 15, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Oct 15, 2022
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have added 1 .js files, please convert to ts(x).
apps/meteor/client/views/admin/apps/AppDetailsPage/tabs/AppLogs/AppLogs.js

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Oct 17, 2022
@github-actions github-actions bot dismissed their stale review October 17, 2022 15:34

js files removed

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Oct 18, 2022
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Oct 18, 2022
@RocketChat RocketChat deleted a comment from kodiakhq bot Oct 18, 2022
Copy link
Contributor

@rique223 rique223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is working as it should. LGTM!

@dougfabris dougfabris added this to the 5.4.0 milestone Oct 31, 2022
@kodiakhq kodiakhq bot merged commit 84664c6 into develop Nov 1, 2022
@kodiakhq kodiakhq bot deleted the chore/apps-code-org branch November 1, 2022 17:29
gabriellsh added a commit that referenced this pull request Nov 1, 2022
…messageGap

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Apps/Marketplace code organization (#27061)
  Bump version to 5.4.0-develop
  Bump version to 5.3.0
  Bump version to 5.3.0-rc.3
  Bump version to 5.3.0-rc.2
  Bump version to 5.3.0-rc.1
  Bump version to 5.3.0-rc.0
gabriellsh added a commit to sidmohanty11/Rocket.Chat that referenced this pull request Nov 3, 2022
…ranch2

* 'develop' of github.com:RocketChat/Rocket.Chat: (1555 commits)
  Chore: Show better error logs (RocketChat#27156)
  [FIX] Message search breaking URL, usertags and emojis (RocketChat#20878)
  [NEW] REST API endpoint `/v1/oauth-apps.create` (RocketChat#27054)
  i18n: Language update from LingoHub 🤖 on 2022-10-31Z (RocketChat#27150)
  Chore: Convert client/views/directory/hooks to ts (RocketChat#26936)
  Chore: Convert client/views/directory/RoomTags to ts (RocketChat#26937)
  [FIX] UserCard not opening inside Threads (RocketChat#27096)
  [FIX] Gap between message content and message header when there's no text. (RocketChat#27165)
  Chore: docs grammar fix (RocketChat#26894)
  [FIX]  Removed mobile requirement for showing real name (RocketChat#26968)
  Chore: Cursor pointer to all the action buttons (RocketChat#24440)
  Chore: Bump actions/upload-artifact from 2 to 3 (RocketChat#27109)
  Chore: Enable PR Title Checker for forks (RocketChat#27144)
  Chore: Converting game center to typescript (RocketChat#26915)
  i18n: Language update from LingoHub 🤖 on 2022-10-24Z (RocketChat#27127)
  Chore: Add info log to remove all rooms method (RocketChat#27106)
  [IMPROVE] Quotes on E2EE Messages (RocketChat#26303)
  [NEW] REST API endpoint `/v1/rooms.delete` (RocketChat#26866)
  [FIX] Room Avatar being deleted after upload. (RocketChat#27060)
  Chore: Apps/Marketplace code organization (RocketChat#27061)
  ...
gabriellsh added a commit that referenced this pull request Nov 3, 2022
…llowArchived

* 'develop' of github.com:RocketChat/Rocket.Chat: (2426 commits)
  Chore: Show better error logs (#27156)
  [FIX] Message search breaking URL, usertags and emojis (#20878)
  [NEW] REST API endpoint `/v1/oauth-apps.create` (#27054)
  i18n: Language update from LingoHub 🤖 on 2022-10-31Z (#27150)
  Chore: Convert client/views/directory/hooks to ts (#26936)
  Chore: Convert client/views/directory/RoomTags to ts (#26937)
  [FIX] UserCard not opening inside Threads (#27096)
  [FIX] Gap between message content and message header when there's no text. (#27165)
  Chore: docs grammar fix (#26894)
  [FIX]  Removed mobile requirement for showing real name (#26968)
  Chore: Cursor pointer to all the action buttons (#24440)
  Chore: Bump actions/upload-artifact from 2 to 3 (#27109)
  Chore: Enable PR Title Checker for forks (#27144)
  Chore: Converting game center to typescript (#26915)
  i18n: Language update from LingoHub 🤖 on 2022-10-24Z (#27127)
  Chore: Add info log to remove all rooms method (#27106)
  [IMPROVE] Quotes on E2EE Messages (#26303)
  [NEW] REST API endpoint `/v1/rooms.delete` (#26866)
  [FIX] Room Avatar being deleted after upload. (#27060)
  Chore: Apps/Marketplace code organization (#27061)
  ...
MartinSchoeler pushed a commit that referenced this pull request Nov 28, 2022
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants