[FIX] Marketplace app details page back-button behavior #27062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the behavior of the marketplace app details page back button. Now it will return the user to the page they accessed the app details from. Also, refactored the overall routing of marketplace and removed the admin-apps route as everything is now handled by the admin-marketplace route.
Codecov Report
@@ Coverage Diff @@
## develop #27062 +/- ##
===========================================
+ Coverage 40.12% 41.16% +1.04%
===========================================
Files 847 819 -28
Lines 18422 17929 -493
Branches 2050 1986 -64
===========================================
- Hits 7391 7380 -11
+ Misses 10747 10265 -482
Partials 284 284
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
previously approved these changes
Nov 10, 2022
apps/meteor/client/components/AdministrationList/AppsModelList.tsx
Outdated
Show resolved
Hide resolved
…ocket.Chat into fix/marketplace-back-button
juliajforesti
previously approved these changes
Nov 11, 2022
dougfabris
approved these changes
Nov 11, 2022
dionisio-bot
bot
added
stat: ready to merge
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 18, 2022
gabriellsh
added a commit
that referenced
this pull request
Nov 21, 2022
…age-ignore-reactivity * 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits) Chore: removing useEndpointData from license api (#26634) Chore: Create unique index for `E2EKey` field (#27301) [FIX] LDAP "Sync Roles" option doesn't work for custom roles (#26842) Chore: UserAvatar wrapper missing key in RoomForeword (#27300) Chore: Add deprecation warning to settings (#27295) Chore: Refactor LeaveTeam to Typescript (#27197) [FIX] Sidebar context menu in searchList (#23830) [NEW] Federation events coverage expansion (#27119) [FIX] Message Parser version upgrade (#27284) [FIX] Replace regex not compatible with safari (#27294) [NEW] Emphasis Elements (italic, strike and bold) in Message Parser Components (#27003) [FIX] Set default value "false" for global search. (#25568) Regression: Custom fields form not showing in user profile nor admin (#27244) [FIX] Sort RecordList items in REVERSE chronological order, not FORWARD (#27201) Chore: Remove unused css (#27289) Chore: also send thread to channel translations (#27242) [FIX] Marketplace app details page back-button behavior (#27062) Chore: Add tests for omni-jobs & add more context in system messages for jobs (#27048) Chore: Fix missing license for forks (#27258) i18n: Language update from LingoHub 🤖 on 2022-11-14Z (#27255) ...
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Jira task: MKP-26
Fixed the behavior of the marketplace app details page back button. Now it will return the user to the page they accessed the app details from. Also, refactored the overall routing of the marketplace and removed the admin-apps route as everything is now handled by the admin-marketplace route.
Demo gif:
Issue(s)
Steps to test or reproduce
Further comments