[NEW] REST API endpoint `/v1/rooms.delete` #26866

felipe-rod123 · 2022-09-14T01:09:49Z

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

lgtm-com · 2022-09-14T01:28:07Z

This pull request introduces 1 alert when merging dde4ceb into ddd52cb - view on LGTM.com

new alerts:

1 for Use of returnless function

lgtm-com · 2022-09-20T17:28:27Z

This pull request introduces 1 alert when merging de0a662 into 3023022 - view on LGTM.com

new alerts:

1 for Use of returnless function

lgtm-com · 2022-09-20T20:43:15Z

This pull request introduces 1 alert when merging 9276326 into 3023022 - view on LGTM.com

new alerts:

1 for Use of returnless function

codecov · 2022-09-20T21:25:34Z

Codecov Report

Merging #26866 (8b2a931) into develop (a0077e5) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #26866      +/-   ##
===========================================
+ Coverage    41.21%   41.24%   +0.03%     
===========================================
  Files          803      803              
  Lines        17824    17824              
  Branches      1971     1971              
===========================================
+ Hits          7346     7352       +6     
+ Misses       10183    10179       -4     
+ Partials       295      293       -2

Flag	Coverage Δ
e2e	`41.24% <ø> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

packages/rest-typings/src/v1/teams/index.ts

lgtm-com · 2022-09-26T01:29:34Z

This pull request introduces 1 alert when merging a24b80d into 8ba1cb8 - view on LGTM.com

new alerts:

1 for Use of returnless function

lgtm-com · 2022-09-26T23:37:47Z

This pull request introduces 1 alert when merging b2a8413 into 6287004 - view on LGTM.com

new alerts:

1 for Use of returnless function

ggazzo

pleas check comments bellow

apps/meteor/server/methods/eraseRoom.ts

lgtm-com · 2022-09-28T13:25:01Z

This pull request introduces 1 alert when merging 512452b into 3a2b6da - view on LGTM.com

new alerts:

1 for Use of returnless function

lgtm-com · 2022-10-05T00:44:23Z

This pull request introduces 1 alert when merging 90b5363 into 3715e0d - view on LGTM.com

new alerts:

1 for Use of returnless function

sampaiodiego · 2022-10-05T13:14:49Z

any special reason to not follow the same pattern as POST users.delete ?

ggazzo · 2022-10-05T13:21:08Z

any special reason to not follow the same pattern as POST users.delete ?

since we have no ~~good~~pattern defined I decided to follow the world convention (RestFul) and apply the http methods usage properly, maybe we could keep both (one because our ancient patterns and the right one) what do you think ?

sampaiodiego · 2022-10-05T13:35:44Z

my suggestion is to use the same pattern we use on other endpoints, so for this one it would be POST rooms.delete { roomId: 'ID-TO-DELETE' } .. I know it is not the best pattern, but it is the one we use, so it is somewhat predictable if you're already familiar with Rocket.Chat API.

…Room-endpoint

…ranch2 * 'develop' of github.com:RocketChat/Rocket.Chat: (1555 commits) Chore: Show better error logs (RocketChat#27156) [FIX] Message search breaking URL, usertags and emojis (RocketChat#20878) [NEW] REST API endpoint `/v1/oauth-apps.create` (RocketChat#27054) i18n: Language update from LingoHub 🤖 on 2022-10-31Z (RocketChat#27150) Chore: Convert client/views/directory/hooks to ts (RocketChat#26936) Chore: Convert client/views/directory/RoomTags to ts (RocketChat#26937) [FIX] UserCard not opening inside Threads (RocketChat#27096) [FIX] Gap between message content and message header when there's no text. (RocketChat#27165) Chore: docs grammar fix (RocketChat#26894) [FIX] Removed mobile requirement for showing real name (RocketChat#26968) Chore: Cursor pointer to all the action buttons (RocketChat#24440) Chore: Bump actions/upload-artifact from 2 to 3 (RocketChat#27109) Chore: Enable PR Title Checker for forks (RocketChat#27144) Chore: Converting game center to typescript (RocketChat#26915) i18n: Language update from LingoHub 🤖 on 2022-10-24Z (RocketChat#27127) Chore: Add info log to remove all rooms method (RocketChat#27106) [IMPROVE] Quotes on E2EE Messages (RocketChat#26303) [NEW] REST API endpoint `/v1/rooms.delete` (RocketChat#26866) [FIX] Room Avatar being deleted after upload. (RocketChat#27060) Chore: Apps/Marketplace code organization (RocketChat#27061) ...

…llowArchived * 'develop' of github.com:RocketChat/Rocket.Chat: (2426 commits) Chore: Show better error logs (#27156) [FIX] Message search breaking URL, usertags and emojis (#20878) [NEW] REST API endpoint `/v1/oauth-apps.create` (#27054) i18n: Language update from LingoHub 🤖 on 2022-10-31Z (#27150) Chore: Convert client/views/directory/hooks to ts (#26936) Chore: Convert client/views/directory/RoomTags to ts (#26937) [FIX] UserCard not opening inside Threads (#27096) [FIX] Gap between message content and message header when there's no text. (#27165) Chore: docs grammar fix (#26894) [FIX] Removed mobile requirement for showing real name (#26968) Chore: Cursor pointer to all the action buttons (#24440) Chore: Bump actions/upload-artifact from 2 to 3 (#27109) Chore: Enable PR Title Checker for forks (#27144) Chore: Converting game center to typescript (#26915) i18n: Language update from LingoHub 🤖 on 2022-10-24Z (#27127) Chore: Add info log to remove all rooms method (#27106) [IMPROVE] Quotes on E2EE Messages (#26303) [NEW] REST API endpoint `/v1/rooms.delete` (#26866) [FIX] Room Avatar being deleted after upload. (#27060) Chore: Apps/Marketplace code organization (#27061) ...

* 'develop' of github.com:RocketChat/Rocket.Chat: (2462 commits) [FIX] Uploading Custom Sound files not working, but showing success (RocketChat#27177) Chore: Show better error logs (RocketChat#27156) [FIX] Message search breaking URL, usertags and emojis (RocketChat#20878) [NEW] REST API endpoint `/v1/oauth-apps.create` (RocketChat#27054) i18n: Language update from LingoHub 🤖 on 2022-10-31Z (RocketChat#27150) Chore: Convert client/views/directory/hooks to ts (RocketChat#26936) Chore: Convert client/views/directory/RoomTags to ts (RocketChat#26937) [FIX] UserCard not opening inside Threads (RocketChat#27096) [FIX] Gap between message content and message header when there's no text. (RocketChat#27165) Chore: docs grammar fix (RocketChat#26894) [FIX] Removed mobile requirement for showing real name (RocketChat#26968) Chore: Cursor pointer to all the action buttons (RocketChat#24440) Chore: Bump actions/upload-artifact from 2 to 3 (RocketChat#27109) Chore: Enable PR Title Checker for forks (RocketChat#27144) Chore: Converting game center to typescript (RocketChat#26915) i18n: Language update from LingoHub 🤖 on 2022-10-24Z (RocketChat#27127) Chore: Add info log to remove all rooms method (RocketChat#27106) [IMPROVE] Quotes on E2EE Messages (RocketChat#26303) [NEW] REST API endpoint `/v1/rooms.delete` (RocketChat#26866) [FIX] Room Avatar being deleted after upload. (RocketChat#27060) ...

…password-change * 'develop' of github.com:RocketChat/Rocket.Chat: (2885 commits) [FIX] Uploading Custom Sound files not working, but showing success (RocketChat#27177) Chore: Show better error logs (RocketChat#27156) [FIX] Message search breaking URL, usertags and emojis (RocketChat#20878) [NEW] REST API endpoint `/v1/oauth-apps.create` (RocketChat#27054) i18n: Language update from LingoHub 🤖 on 2022-10-31Z (RocketChat#27150) Chore: Convert client/views/directory/hooks to ts (RocketChat#26936) Chore: Convert client/views/directory/RoomTags to ts (RocketChat#26937) [FIX] UserCard not opening inside Threads (RocketChat#27096) [FIX] Gap between message content and message header when there's no text. (RocketChat#27165) Chore: docs grammar fix (RocketChat#26894) [FIX] Removed mobile requirement for showing real name (RocketChat#26968) Chore: Cursor pointer to all the action buttons (RocketChat#24440) Chore: Bump actions/upload-artifact from 2 to 3 (RocketChat#27109) Chore: Enable PR Title Checker for forks (RocketChat#27144) Chore: Converting game center to typescript (RocketChat#26915) i18n: Language update from LingoHub 🤖 on 2022-10-24Z (RocketChat#27127) Chore: Add info log to remove all rooms method (RocketChat#27106) [IMPROVE] Quotes on E2EE Messages (RocketChat#26303) [NEW] REST API endpoint `/v1/rooms.delete` (RocketChat#26866) [FIX] Room Avatar being deleted after upload. (RocketChat#27060) ...

Co-authored-by: Diego Sampaio <[email protected]>

create eraseRoom endpoint

9cb9897

ggazzo added the stat: needs QA label Sep 14, 2022

add useEndpoint function

dde4ceb

Merge branch 'develop' into chore/create-eraseRoom-endpoint

de0a662

fix Ajv

9276326

ggazzo requested changes Sep 21, 2022

View reviewed changes

packages/rest-typings/src/v1/teams/index.ts Outdated Show resolved Hide resolved

review changes (work in progress)

a24b80d

create e2e test

b2a8413

Merge branch 'develop' into chore/create-eraseRoom-endpoint

512452b

ggazzo requested changes Sep 28, 2022

View reviewed changes

apps/meteor/server/methods/eraseRoom.ts Outdated Show resolved Hide resolved

apps/meteor/server/methods/eraseRoom.ts Outdated Show resolved Hide resolved

fix review

90b5363

ggazzo added 3 commits October 5, 2022 09:57

Review

5d63a6e

fix erase room method

8569774

Merge branch 'develop' into chore/create-eraseRoom-endpoint

7d701a7

ggazzo marked this pull request as ready for review October 5, 2022 13:00

ggazzo requested review from a team as code owners October 5, 2022 13:00

ggazzo added this to the 5.3.0 milestone Oct 5, 2022

ggazzo previously approved these changes Oct 5, 2022

View reviewed changes

Fix CI

a2a4427

ggazzo dismissed their stale review via a2a4427 October 5, 2022 13:18

ggazzo requested a review from sampaiodiego October 5, 2022 13:21

fix lint

588240c

sampaiodiego added 2 commits October 18, 2022 16:03

Merge remote-tracking branch 'origin/develop' into chore/create-erase…

9ec0399

…Room-endpoint

rename endpoint

5c8b468

sampaiodiego changed the title ~~Chore: create eraseRoom endpoint~~ [NEW] REST API endpoint /v1/rooms.delete Oct 18, 2022

sampaiodiego previously approved these changes Oct 18, 2022

View reviewed changes

sampaiodiego added the stat: QA skipped label Oct 18, 2022

ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 18, 2022

d-gubert modified the milestones: 5.3.0, 5.4.0 Oct 19, 2022

sampaiodiego added 2 commits November 1, 2022 14:00

Merge branch 'develop' into chore/create-eraseRoom-endpoint

37b3d4c

move to function and add more tests

8b2a931

sampaiodiego dismissed their stale review via 8b2a931 November 1, 2022 17:59

sampaiodiego approved these changes Nov 1, 2022

View reviewed changes

sampaiodiego merged commit daa6aae into develop Nov 1, 2022

sampaiodiego deleted the chore/create-eraseRoom-endpoint branch November 1, 2022 19:54

MartinSchoeler pushed a commit that referenced this pull request Nov 28, 2022

[NEW] REST API endpoint /v1/rooms.delete (#26866)

03d348b

Co-authored-by: Diego Sampaio <[email protected]>

ggazzo mentioned this pull request Dec 5, 2022

Release 5.4.0 #27447

Merged

[NEW] REST API endpoint /v1/rooms.delete #26866

[NEW] REST API endpoint /v1/rooms.delete #26866

Uh oh!

Conversation

felipe-rod123 commented Sep 14, 2022 • edited by sampaiodiego Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

lgtm-com bot commented Sep 14, 2022

Uh oh!

lgtm-com bot commented Sep 20, 2022

Uh oh!

lgtm-com bot commented Sep 20, 2022

Uh oh!

codecov bot commented Sep 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

lgtm-com bot commented Sep 26, 2022

Uh oh!

lgtm-com bot commented Sep 26, 2022

Uh oh!

ggazzo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lgtm-com bot commented Sep 28, 2022

Uh oh!

lgtm-com bot commented Oct 5, 2022

Uh oh!

sampaiodiego commented Oct 5, 2022

Uh oh!

ggazzo commented Oct 5, 2022

Uh oh!

sampaiodiego commented Oct 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[NEW] REST API endpoint `/v1/rooms.delete` #26866

[NEW] REST API endpoint `/v1/rooms.delete` #26866

felipe-rod123 commented Sep 14, 2022 •

edited by sampaiodiego

Loading

codecov bot commented Sep 20, 2022 •

edited

Loading

ggazzo left a comment •

edited

Loading