Chore: Show better error logs #27156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
added
stat: ready to merge
Codecov Report
@@ Coverage Diff @@
## develop #27156 +/- ##
===========================================
+ Coverage 40.53% 41.31% +0.77%
===========================================
Files 826 801 -25
Lines 18116 17676 -440
Branches 2058 1996 -62
===========================================
- Hits 7344 7302 -42
+ Misses 10481 10079 -402
- Partials 291 295 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
approved these changes
Nov 1, 2022
KevLehman
approved these changes
Nov 3, 2022
gabriellsh
added a commit
to sidmohanty11/Rocket.Chat
that referenced
this pull request
Nov 3, 2022
…ranch2 * 'develop' of github.com:RocketChat/Rocket.Chat: (1555 commits) Chore: Show better error logs (RocketChat#27156) [FIX] Message search breaking URL, usertags and emojis (RocketChat#20878) [NEW] REST API endpoint `/v1/oauth-apps.create` (RocketChat#27054) i18n: Language update from LingoHub 🤖 on 2022-10-31Z (RocketChat#27150) Chore: Convert client/views/directory/hooks to ts (RocketChat#26936) Chore: Convert client/views/directory/RoomTags to ts (RocketChat#26937) [FIX] UserCard not opening inside Threads (RocketChat#27096) [FIX] Gap between message content and message header when there's no text. (RocketChat#27165) Chore: docs grammar fix (RocketChat#26894) [FIX] Removed mobile requirement for showing real name (RocketChat#26968) Chore: Cursor pointer to all the action buttons (RocketChat#24440) Chore: Bump actions/upload-artifact from 2 to 3 (RocketChat#27109) Chore: Enable PR Title Checker for forks (RocketChat#27144) Chore: Converting game center to typescript (RocketChat#26915) i18n: Language update from LingoHub 🤖 on 2022-10-24Z (RocketChat#27127) Chore: Add info log to remove all rooms method (RocketChat#27106) [IMPROVE] Quotes on E2EE Messages (RocketChat#26303) [NEW] REST API endpoint `/v1/rooms.delete` (RocketChat#26866) [FIX] Room Avatar being deleted after upload. (RocketChat#27060) Chore: Apps/Marketplace code organization (RocketChat#27061) ...
gabriellsh
added a commit
that referenced
this pull request
Nov 3, 2022
…llowArchived * 'develop' of github.com:RocketChat/Rocket.Chat: (2426 commits) Chore: Show better error logs (#27156) [FIX] Message search breaking URL, usertags and emojis (#20878) [NEW] REST API endpoint `/v1/oauth-apps.create` (#27054) i18n: Language update from LingoHub 🤖 on 2022-10-31Z (#27150) Chore: Convert client/views/directory/hooks to ts (#26936) Chore: Convert client/views/directory/RoomTags to ts (#26937) [FIX] UserCard not opening inside Threads (#27096) [FIX] Gap between message content and message header when there's no text. (#27165) Chore: docs grammar fix (#26894) [FIX] Removed mobile requirement for showing real name (#26968) Chore: Cursor pointer to all the action buttons (#24440) Chore: Bump actions/upload-artifact from 2 to 3 (#27109) Chore: Enable PR Title Checker for forks (#27144) Chore: Converting game center to typescript (#26915) i18n: Language update from LingoHub 🤖 on 2022-10-24Z (#27127) Chore: Add info log to remove all rooms method (#27106) [IMPROVE] Quotes on E2EE Messages (#26303) [NEW] REST API endpoint `/v1/rooms.delete` (#26866) [FIX] Room Avatar being deleted after upload. (#27060) Chore: Apps/Marketplace code organization (#27061) ...
gabriellsh
added a commit
to Kartik18g/Rocket.Chat
that referenced
this pull request
Nov 3, 2022
* 'develop' of github.com:RocketChat/Rocket.Chat: (2462 commits) [FIX] Uploading Custom Sound files not working, but showing success (RocketChat#27177) Chore: Show better error logs (RocketChat#27156) [FIX] Message search breaking URL, usertags and emojis (RocketChat#20878) [NEW] REST API endpoint `/v1/oauth-apps.create` (RocketChat#27054) i18n: Language update from LingoHub 🤖 on 2022-10-31Z (RocketChat#27150) Chore: Convert client/views/directory/hooks to ts (RocketChat#26936) Chore: Convert client/views/directory/RoomTags to ts (RocketChat#26937) [FIX] UserCard not opening inside Threads (RocketChat#27096) [FIX] Gap between message content and message header when there's no text. (RocketChat#27165) Chore: docs grammar fix (RocketChat#26894) [FIX] Removed mobile requirement for showing real name (RocketChat#26968) Chore: Cursor pointer to all the action buttons (RocketChat#24440) Chore: Bump actions/upload-artifact from 2 to 3 (RocketChat#27109) Chore: Enable PR Title Checker for forks (RocketChat#27144) Chore: Converting game center to typescript (RocketChat#26915) i18n: Language update from LingoHub 🤖 on 2022-10-24Z (RocketChat#27127) Chore: Add info log to remove all rooms method (RocketChat#27106) [IMPROVE] Quotes on E2EE Messages (RocketChat#26303) [NEW] REST API endpoint `/v1/rooms.delete` (RocketChat#26866) [FIX] Room Avatar being deleted after upload. (RocketChat#27060) ...
gabriellsh
added a commit
to im-adithya/Rocket.Chat
that referenced
this pull request
Nov 3, 2022
…password-change * 'develop' of github.com:RocketChat/Rocket.Chat: (2885 commits) [FIX] Uploading Custom Sound files not working, but showing success (RocketChat#27177) Chore: Show better error logs (RocketChat#27156) [FIX] Message search breaking URL, usertags and emojis (RocketChat#20878) [NEW] REST API endpoint `/v1/oauth-apps.create` (RocketChat#27054) i18n: Language update from LingoHub 🤖 on 2022-10-31Z (RocketChat#27150) Chore: Convert client/views/directory/hooks to ts (RocketChat#26936) Chore: Convert client/views/directory/RoomTags to ts (RocketChat#26937) [FIX] UserCard not opening inside Threads (RocketChat#27096) [FIX] Gap between message content and message header when there's no text. (RocketChat#27165) Chore: docs grammar fix (RocketChat#26894) [FIX] Removed mobile requirement for showing real name (RocketChat#26968) Chore: Cursor pointer to all the action buttons (RocketChat#24440) Chore: Bump actions/upload-artifact from 2 to 3 (RocketChat#27109) Chore: Enable PR Title Checker for forks (RocketChat#27144) Chore: Converting game center to typescript (RocketChat#26915) i18n: Language update from LingoHub 🤖 on 2022-10-24Z (RocketChat#27127) Chore: Add info log to remove all rooms method (RocketChat#27106) [IMPROVE] Quotes on E2EE Messages (RocketChat#26303) [NEW] REST API endpoint `/v1/rooms.delete` (RocketChat#26866) [FIX] Room Avatar being deleted after upload. (RocketChat#27060) ...
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This was a technical debt created when we started using Pino logger, that has some better ways to properly show error logs, as per their docs https://github.com/pinojs/pino/blob/master/docs/api.md#errors
Issue(s)
ARCH-86
Steps to test or reproduce
Further comments