[NEW] REST API endpoint `/v1/oauth-apps.create` #27054

felipe-rod123 · 2022-10-11T19:02:23Z

Proposed changes (including videos or screenshots)

Created the 'oauth-apps.addOAuthApp' endpoint for the apps/meteor/client/views/admin/oauthApps/OAuthAddApp.tsx file, and added Ajv validation.

Issue(s)

Steps to test or reproduce

Further comments

codecov · 2022-10-11T20:12:24Z

Codecov Report

Merging #27054 (d91792f) into develop (a0077e5) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #27054      +/-   ##
===========================================
- Coverage    41.21%   41.17%   -0.05%     
===========================================
  Files          803      802       -1     
  Lines        17824    17806      -18     
  Branches      1971     1971              
===========================================
- Hits          7346     7331      -15     
+ Misses       10183    10181       -2     
+ Partials       295      294       -1

Flag	Coverage Δ
e2e	`41.17% <ø> (-0.05%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

sampaiodiego

missing tests though

sampaiodiego

the return type of the new endpoint is not compatible with the old method. it should return the created application

debdutdeb · 2022-10-23T08:25:21Z

Should this set of endpoints not check for manage-oauth-apps permission?

debdutdeb · 2022-10-23T08:26:28Z

Hm it's being checked in the meteor method. Was a bit confusing considering the new permissionRequired option being part of addRoute now :)

…ranch2 * 'develop' of github.com:RocketChat/Rocket.Chat: (1555 commits) Chore: Show better error logs (RocketChat#27156) [FIX] Message search breaking URL, usertags and emojis (RocketChat#20878) [NEW] REST API endpoint `/v1/oauth-apps.create` (RocketChat#27054) i18n: Language update from LingoHub 🤖 on 2022-10-31Z (RocketChat#27150) Chore: Convert client/views/directory/hooks to ts (RocketChat#26936) Chore: Convert client/views/directory/RoomTags to ts (RocketChat#26937) [FIX] UserCard not opening inside Threads (RocketChat#27096) [FIX] Gap between message content and message header when there's no text. (RocketChat#27165) Chore: docs grammar fix (RocketChat#26894) [FIX] Removed mobile requirement for showing real name (RocketChat#26968) Chore: Cursor pointer to all the action buttons (RocketChat#24440) Chore: Bump actions/upload-artifact from 2 to 3 (RocketChat#27109) Chore: Enable PR Title Checker for forks (RocketChat#27144) Chore: Converting game center to typescript (RocketChat#26915) i18n: Language update from LingoHub 🤖 on 2022-10-24Z (RocketChat#27127) Chore: Add info log to remove all rooms method (RocketChat#27106) [IMPROVE] Quotes on E2EE Messages (RocketChat#26303) [NEW] REST API endpoint `/v1/rooms.delete` (RocketChat#26866) [FIX] Room Avatar being deleted after upload. (RocketChat#27060) Chore: Apps/Marketplace code organization (RocketChat#27061) ...

…llowArchived * 'develop' of github.com:RocketChat/Rocket.Chat: (2426 commits) Chore: Show better error logs (#27156) [FIX] Message search breaking URL, usertags and emojis (#20878) [NEW] REST API endpoint `/v1/oauth-apps.create` (#27054) i18n: Language update from LingoHub 🤖 on 2022-10-31Z (#27150) Chore: Convert client/views/directory/hooks to ts (#26936) Chore: Convert client/views/directory/RoomTags to ts (#26937) [FIX] UserCard not opening inside Threads (#27096) [FIX] Gap between message content and message header when there's no text. (#27165) Chore: docs grammar fix (#26894) [FIX] Removed mobile requirement for showing real name (#26968) Chore: Cursor pointer to all the action buttons (#24440) Chore: Bump actions/upload-artifact from 2 to 3 (#27109) Chore: Enable PR Title Checker for forks (#27144) Chore: Converting game center to typescript (#26915) i18n: Language update from LingoHub 🤖 on 2022-10-24Z (#27127) Chore: Add info log to remove all rooms method (#27106) [IMPROVE] Quotes on E2EE Messages (#26303) [NEW] REST API endpoint `/v1/rooms.delete` (#26866) [FIX] Room Avatar being deleted after upload. (#27060) Chore: Apps/Marketplace code organization (#27061) ...

* 'develop' of github.com:RocketChat/Rocket.Chat: (2462 commits) [FIX] Uploading Custom Sound files not working, but showing success (RocketChat#27177) Chore: Show better error logs (RocketChat#27156) [FIX] Message search breaking URL, usertags and emojis (RocketChat#20878) [NEW] REST API endpoint `/v1/oauth-apps.create` (RocketChat#27054) i18n: Language update from LingoHub 🤖 on 2022-10-31Z (RocketChat#27150) Chore: Convert client/views/directory/hooks to ts (RocketChat#26936) Chore: Convert client/views/directory/RoomTags to ts (RocketChat#26937) [FIX] UserCard not opening inside Threads (RocketChat#27096) [FIX] Gap between message content and message header when there's no text. (RocketChat#27165) Chore: docs grammar fix (RocketChat#26894) [FIX] Removed mobile requirement for showing real name (RocketChat#26968) Chore: Cursor pointer to all the action buttons (RocketChat#24440) Chore: Bump actions/upload-artifact from 2 to 3 (RocketChat#27109) Chore: Enable PR Title Checker for forks (RocketChat#27144) Chore: Converting game center to typescript (RocketChat#26915) i18n: Language update from LingoHub 🤖 on 2022-10-24Z (RocketChat#27127) Chore: Add info log to remove all rooms method (RocketChat#27106) [IMPROVE] Quotes on E2EE Messages (RocketChat#26303) [NEW] REST API endpoint `/v1/rooms.delete` (RocketChat#26866) [FIX] Room Avatar being deleted after upload. (RocketChat#27060) ...

…password-change * 'develop' of github.com:RocketChat/Rocket.Chat: (2885 commits) [FIX] Uploading Custom Sound files not working, but showing success (RocketChat#27177) Chore: Show better error logs (RocketChat#27156) [FIX] Message search breaking URL, usertags and emojis (RocketChat#20878) [NEW] REST API endpoint `/v1/oauth-apps.create` (RocketChat#27054) i18n: Language update from LingoHub 🤖 on 2022-10-31Z (RocketChat#27150) Chore: Convert client/views/directory/hooks to ts (RocketChat#26936) Chore: Convert client/views/directory/RoomTags to ts (RocketChat#26937) [FIX] UserCard not opening inside Threads (RocketChat#27096) [FIX] Gap between message content and message header when there's no text. (RocketChat#27165) Chore: docs grammar fix (RocketChat#26894) [FIX] Removed mobile requirement for showing real name (RocketChat#26968) Chore: Cursor pointer to all the action buttons (RocketChat#24440) Chore: Bump actions/upload-artifact from 2 to 3 (RocketChat#27109) Chore: Enable PR Title Checker for forks (RocketChat#27144) Chore: Converting game center to typescript (RocketChat#26915) i18n: Language update from LingoHub 🤖 on 2022-10-24Z (RocketChat#27127) Chore: Add info log to remove all rooms method (RocketChat#27106) [IMPROVE] Quotes on E2EE Messages (RocketChat#26303) [NEW] REST API endpoint `/v1/rooms.delete` (RocketChat#26866) [FIX] Room Avatar being deleted after upload. (RocketChat#27060) ...

Co-authored-by: Diego Sampaio <[email protected]>

create addOAuthApp endpoint

f971b0a

ggazzo added the stat: needs QA label Oct 11, 2022

felipe-rod123 marked this pull request as ready for review October 11, 2022 20:12

felipe-rod123 requested review from a team as code owners October 11, 2022 20:12

sampaiodiego added 2 commits October 18, 2022 17:16

Merge branch 'develop' into chore/create-OAuthAddApp-endpoints

0c58a09

rename endpoint

602be09

sampaiodiego changed the title ~~Chore: create addOAuthApp endpoint~~ [NEW] REST API endpoint /v1/oauth-apps.create Oct 18, 2022

sampaiodiego approved these changes Oct 18, 2022

View reviewed changes

sampaiodiego requested changes Oct 18, 2022

View reviewed changes

felipe-rod123 and others added 2 commits October 20, 2022 09:43

fix 'oauth-apps.create' return type

e915d1b

Merge branch 'develop' into chore/create-OAuthAddApp-endpoints

33e8d9f

sampaiodiego added 3 commits November 1, 2022 15:25

Merge branch 'develop' into chore/create-OAuthAddApp-endpoints

15a3ce7

move code to function

46c9a67

move code to function and add tests

d91792f

sampaiodiego approved these changes Nov 1, 2022

View reviewed changes

sampaiodiego merged commit 010f186 into develop Nov 3, 2022

sampaiodiego deleted the chore/create-OAuthAddApp-endpoints branch November 3, 2022 13:18

MartinSchoeler pushed a commit that referenced this pull request Nov 28, 2022

[NEW] REST API endpoint /v1/oauth-apps.create (#27054)

6622889

Co-authored-by: Diego Sampaio <[email protected]>

ggazzo mentioned this pull request Dec 5, 2022

Release 5.4.0 #27447

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NEW] REST API endpoint `/v1/oauth-apps.create` #27054

[NEW] REST API endpoint `/v1/oauth-apps.create` #27054

Uh oh!

felipe-rod123 commented Oct 11, 2022

Uh oh!

codecov bot commented Oct 11, 2022 •

edited

Loading

Uh oh!

sampaiodiego left a comment

Uh oh!

sampaiodiego left a comment

Uh oh!

debdutdeb commented Oct 23, 2022

Uh oh!

debdutdeb commented Oct 23, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[NEW] REST API endpoint /v1/oauth-apps.create #27054

[NEW] REST API endpoint /v1/oauth-apps.create #27054

Uh oh!

Conversation

felipe-rod123 commented Oct 11, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

codecov bot commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sampaiodiego left a comment

Choose a reason for hiding this comment

Uh oh!

sampaiodiego left a comment

Choose a reason for hiding this comment

Uh oh!

debdutdeb commented Oct 23, 2022

Uh oh!

debdutdeb commented Oct 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[NEW] REST API endpoint `/v1/oauth-apps.create` #27054

[NEW] REST API endpoint `/v1/oauth-apps.create` #27054

codecov bot commented Oct 11, 2022 •

edited

Loading

debdutdeb commented Oct 23, 2022 •

edited

Loading