Skip to content

Conversation

@tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #27144 (41bf50b) into develop (34ca34f) will increase coverage by 0.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27144      +/-   ##
===========================================
+ Coverage    40.55%   41.22%   +0.67%     
===========================================
  Files          828      803      -25     
  Lines        18254    17823     -431     
  Branches      2030     1971      -59     
===========================================
- Hits          7403     7348      -55     
+ Misses       10553    10182     -371     
+ Partials       298      293       -5     
Flag Coverage Δ
e2e 41.22% <100.00%> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Oct 28, 2022
@debdutdeb
Copy link
Member

@tassoevan believe this is not a draft anymore? 👀

@tassoevan tassoevan marked this pull request as ready for review October 31, 2022 11:44
@tassoevan tassoevan requested a review from a team as a code owner October 31, 2022 11:44
@ggazzo ggazzo merged commit dc9f366 into develop Nov 2, 2022
@ggazzo ggazzo deleted the chore/pr-title-checker-for-all branch November 2, 2022 00:14
gabriellsh added a commit to sidmohanty11/Rocket.Chat that referenced this pull request Nov 3, 2022
…ranch2

* 'develop' of github.com:RocketChat/Rocket.Chat: (1555 commits)
  Chore: Show better error logs (RocketChat#27156)
  [FIX] Message search breaking URL, usertags and emojis (RocketChat#20878)
  [NEW] REST API endpoint `/v1/oauth-apps.create` (RocketChat#27054)
  i18n: Language update from LingoHub 🤖 on 2022-10-31Z (RocketChat#27150)
  Chore: Convert client/views/directory/hooks to ts (RocketChat#26936)
  Chore: Convert client/views/directory/RoomTags to ts (RocketChat#26937)
  [FIX] UserCard not opening inside Threads (RocketChat#27096)
  [FIX] Gap between message content and message header when there's no text. (RocketChat#27165)
  Chore: docs grammar fix (RocketChat#26894)
  [FIX]  Removed mobile requirement for showing real name (RocketChat#26968)
  Chore: Cursor pointer to all the action buttons (RocketChat#24440)
  Chore: Bump actions/upload-artifact from 2 to 3 (RocketChat#27109)
  Chore: Enable PR Title Checker for forks (RocketChat#27144)
  Chore: Converting game center to typescript (RocketChat#26915)
  i18n: Language update from LingoHub 🤖 on 2022-10-24Z (RocketChat#27127)
  Chore: Add info log to remove all rooms method (RocketChat#27106)
  [IMPROVE] Quotes on E2EE Messages (RocketChat#26303)
  [NEW] REST API endpoint `/v1/rooms.delete` (RocketChat#26866)
  [FIX] Room Avatar being deleted after upload. (RocketChat#27060)
  Chore: Apps/Marketplace code organization (RocketChat#27061)
  ...
gabriellsh added a commit that referenced this pull request Nov 3, 2022
…llowArchived

* 'develop' of github.com:RocketChat/Rocket.Chat: (2426 commits)
  Chore: Show better error logs (#27156)
  [FIX] Message search breaking URL, usertags and emojis (#20878)
  [NEW] REST API endpoint `/v1/oauth-apps.create` (#27054)
  i18n: Language update from LingoHub 🤖 on 2022-10-31Z (#27150)
  Chore: Convert client/views/directory/hooks to ts (#26936)
  Chore: Convert client/views/directory/RoomTags to ts (#26937)
  [FIX] UserCard not opening inside Threads (#27096)
  [FIX] Gap between message content and message header when there's no text. (#27165)
  Chore: docs grammar fix (#26894)
  [FIX]  Removed mobile requirement for showing real name (#26968)
  Chore: Cursor pointer to all the action buttons (#24440)
  Chore: Bump actions/upload-artifact from 2 to 3 (#27109)
  Chore: Enable PR Title Checker for forks (#27144)
  Chore: Converting game center to typescript (#26915)
  i18n: Language update from LingoHub 🤖 on 2022-10-24Z (#27127)
  Chore: Add info log to remove all rooms method (#27106)
  [IMPROVE] Quotes on E2EE Messages (#26303)
  [NEW] REST API endpoint `/v1/rooms.delete` (#26866)
  [FIX] Room Avatar being deleted after upload. (#27060)
  Chore: Apps/Marketplace code organization (#27061)
  ...
gabriellsh added a commit to Kartik18g/Rocket.Chat that referenced this pull request Nov 3, 2022
* 'develop' of github.com:RocketChat/Rocket.Chat: (2462 commits)
  [FIX] Uploading Custom Sound files not working, but showing success (RocketChat#27177)
  Chore: Show better error logs (RocketChat#27156)
  [FIX] Message search breaking URL, usertags and emojis (RocketChat#20878)
  [NEW] REST API endpoint `/v1/oauth-apps.create` (RocketChat#27054)
  i18n: Language update from LingoHub 🤖 on 2022-10-31Z (RocketChat#27150)
  Chore: Convert client/views/directory/hooks to ts (RocketChat#26936)
  Chore: Convert client/views/directory/RoomTags to ts (RocketChat#26937)
  [FIX] UserCard not opening inside Threads (RocketChat#27096)
  [FIX] Gap between message content and message header when there's no text. (RocketChat#27165)
  Chore: docs grammar fix (RocketChat#26894)
  [FIX]  Removed mobile requirement for showing real name (RocketChat#26968)
  Chore: Cursor pointer to all the action buttons (RocketChat#24440)
  Chore: Bump actions/upload-artifact from 2 to 3 (RocketChat#27109)
  Chore: Enable PR Title Checker for forks (RocketChat#27144)
  Chore: Converting game center to typescript (RocketChat#26915)
  i18n: Language update from LingoHub 🤖 on 2022-10-24Z (RocketChat#27127)
  Chore: Add info log to remove all rooms method (RocketChat#27106)
  [IMPROVE] Quotes on E2EE Messages (RocketChat#26303)
  [NEW] REST API endpoint `/v1/rooms.delete` (RocketChat#26866)
  [FIX] Room Avatar being deleted after upload. (RocketChat#27060)
  ...
gabriellsh added a commit to im-adithya/Rocket.Chat that referenced this pull request Nov 3, 2022
…password-change

* 'develop' of github.com:RocketChat/Rocket.Chat: (2885 commits)
  [FIX] Uploading Custom Sound files not working, but showing success (RocketChat#27177)
  Chore: Show better error logs (RocketChat#27156)
  [FIX] Message search breaking URL, usertags and emojis (RocketChat#20878)
  [NEW] REST API endpoint `/v1/oauth-apps.create` (RocketChat#27054)
  i18n: Language update from LingoHub 🤖 on 2022-10-31Z (RocketChat#27150)
  Chore: Convert client/views/directory/hooks to ts (RocketChat#26936)
  Chore: Convert client/views/directory/RoomTags to ts (RocketChat#26937)
  [FIX] UserCard not opening inside Threads (RocketChat#27096)
  [FIX] Gap between message content and message header when there's no text. (RocketChat#27165)
  Chore: docs grammar fix (RocketChat#26894)
  [FIX]  Removed mobile requirement for showing real name (RocketChat#26968)
  Chore: Cursor pointer to all the action buttons (RocketChat#24440)
  Chore: Bump actions/upload-artifact from 2 to 3 (RocketChat#27109)
  Chore: Enable PR Title Checker for forks (RocketChat#27144)
  Chore: Converting game center to typescript (RocketChat#26915)
  i18n: Language update from LingoHub 🤖 on 2022-10-24Z (RocketChat#27127)
  Chore: Add info log to remove all rooms method (RocketChat#27106)
  [IMPROVE] Quotes on E2EE Messages (RocketChat#26303)
  [NEW] REST API endpoint `/v1/rooms.delete` (RocketChat#26866)
  [FIX] Room Avatar being deleted after upload. (RocketChat#27060)
  ...
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants