Repository navigation
[tensilelite] Fix type mismatches in gfx942 GridBased large YAML files (1c/3) - #8683
Closed
jaopaulolc wants to merge 1 commit into
Closed
jaopaulolc wants to merge 1 commit into
jaopaulolc wants to merge 1 commit into
Conversation
…s (1c/3) Fix parameter type mismatches in 26 large (>10MB) aquavanjaram/gfx942 GridBased logic files: - int -> bool: Activation, SourceSwap, TailloopInNll, TransposeA, TransposeB - int -> float: GlobalReadPerMfma Split from 1b due to GitHub diff rendering limits on large files.
This was referenced Jun 22, 2026
Contributor
Author
|
Closing in favour of #6609 which covers these fixes. |
jaopaulolc
deleted the
users/jolabega/fix-type-mismatch-gfx942-gridbased-large
branch
July 7, 2026 15:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TensileLite device library YAML files for 26 large (>10 MB) gfx942
GridBased configurations contain parameter type mismatches (int stored
where bool or float is expected). These cause
std::bad_castexceptionsat runtime when msgpack deserialization encounters unexpected wire types.
This is part 1c of a series splitting #8623 into reviewable chunks.
These 26 files are split separately because GitHub cannot render inline
diffs for files this large; reviewers should trust the mechanical regex
changes (identical pattern to PRs 1a and 1b).
Technical Details
Bulk regex fixes applied to 26 YAML library logic files (each >10 MB)
under
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/aquavanjaram/gfx942/GridBased/.Conversions:
Activation,SourceSwap,TailloopInNll,TransposeA,TransposeB(e.g.
Activation: 1→Activation: true)GlobalReadPerMfma(e.g.
GlobalReadPerMfma: 1→GlobalReadPerMfma: 1.0)No logic or behavior change; only corrects serialized types to match
TensileLite's schema expectations.
Note: GitHub will show these files as changed but may not render inline
diffs due to file size. The changes are identical in nature to the
smaller files in PR 1b — same regex, same parameters.
Test Plan
test_validateParameterTypes.pyconfirm correct type detectionTest Result
Submission Checklist
Risk level
None — data-only change correcting serialized types to match schema; no logic change.
Associated ticket: N/A
PR Series