Skip to content

[tensilelite] Fix type mismatches in gfx942 GridBased large YAML files (1c/3) - #8683

Closed
jaopaulolc wants to merge 1 commit into
developfrom
users/jolabega/fix-type-mismatch-gfx942-gridbased-large
Closed

jaopaulolc wants to merge 1 commit into
developfrom
users/jolabega/fix-type-mismatch-gfx942-gridbased-large

Conversation

@jaopaulolc

@jaopaulolc jaopaulolc commented Jun 22, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

TensileLite device library YAML files for 26 large (>10 MB) gfx942
GridBased configurations contain parameter type mismatches (int stored
where bool or float is expected). These cause std::bad_cast exceptions
at runtime when msgpack deserialization encounters unexpected wire types.

This is part 1c of a series splitting #8623 into reviewable chunks.
These 26 files are split separately because GitHub cannot render inline
diffs for files this large; reviewers should trust the mechanical regex
changes (identical pattern to PRs 1a and 1b).

Technical Details

Bulk regex fixes applied to 26 YAML library logic files (each >10 MB)
under projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/aquavanjaram/gfx942/GridBased/.

Conversions:

  • int → bool: Activation, SourceSwap, TailloopInNll, TransposeA, TransposeB
    (e.g. Activation: 1 → Activation: true)
  • int → float: GlobalReadPerMfma
    (e.g. GlobalReadPerMfma: 1 → GlobalReadPerMfma: 1.0)

No logic or behavior change; only corrects serialized types to match
TensileLite's schema expectations.

Note: GitHub will show these files as changed but may not render inline
diffs due to file size. The changes are identical in nature to the
smaller files in PR 1b — same regex, same parameters.

Test Plan

  • Device library build for gfx942 passes type validation with zero mismatches
  • CI gating builds for hipblaslt and hipsparselt pass
  • Unit tests in test_validateParameterTypes.py confirm correct type detection

Test Result

  • Local device library build completed with 0 type mismatch warnings
  • Existing unit tests pass

Submission Checklist

Risk level

None — data-only change correcting serialized types to match schema; no logic change.

Associated ticket: N/A

PR Series

# PR Files URL
1a FreeSize gfx942 YAML fixes 100 #8680
1b GridBased small + 80cu/228cu YAML fixes 36 #8682
1c GridBased large YAML files (>10MB) 26 #8683 👈
2 gfx950/gfx1250/gfx11xx YAML + CustomKernels + hipsparselt ~120 #8678
3 Error promotion + test/config fixes 35 #8679

…s (1c/3)

Fix parameter type mismatches in 26 large (>10MB) aquavanjaram/gfx942
GridBased logic files:

- int -> bool: Activation, SourceSwap, TailloopInNll, TransposeA, TransposeB
- int -> float: GlobalReadPerMfma

Split from 1b due to GitHub diff rendering limits on large files.
@jaopaulolc

Copy link
Copy Markdown
Contributor Author

Closing in favour of #6609 which covers these fixes.

@jaopaulolc jaopaulolc closed this Jun 22, 2026
@jaopaulolc
jaopaulolc deleted the users/jolabega/fix-type-mismatch-gfx942-gridbased-large branch July 7, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant