Repository navigation
[tensilelite] Promote type mismatch warning to hard error (3/3) - #8679
Closed
jaopaulolc wants to merge 1 commit into
Closed
jaopaulolc wants to merge 1 commit into
jaopaulolc wants to merge 1 commit into
Conversation
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
ci:hipsparselt-fast
labels
jaopaulolc
added
the
rocm:gemm algos
This was referenced Jun 22, 2026
- Change printTypeMismatchSummary() diagnostic from WARNING to ERROR - Raise RuntimeError in TensileCreateLibrary when mismatches are detected, failing the build immediately instead of continuing silently - Fix GlobalReadPerMfma default in GlobalParameters.py from [1] to [1.0] - Fix GlobalReadPerMfma in test fixture YAML - Update unit test assertions for new error behavior - Fix type mismatches in test config and streamk YAML files
jaopaulolc
force-pushed
the
users/jolabega/fix-type-mismatch-error-promotion
branch
from
June 22, 2026 18:28
cd1fc95 to
3cccbb2
Compare
Contributor
Author
|
Closing in favour of #6609 which covers these fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After fixing all type mismatches in the device library YAML files (PRs
#8680, #8681, #8678), the build-time diagnostic that detects these
mismatches should be promoted from a warning to a hard error to prevent
silent regressions.
This is part 3 of a 3-part series splitting #8623 into reviewable chunks.
Technical Details
TensileCreateLibrary/Run.py: callsprintTypeMismatchSummary()andraises
RuntimeErrorwhen any mismatches are found, failing the devicelibrary build immediately.
Tensile/SolutionStructs/Solution.py: changes diagnostic label from"WARNING" to "ERROR" for clarity.
Tensile/Common/GlobalParameters.py: fixesGlobalReadPerMfmadefaultfrom
[1](int) to[1.0](float) to match schema.behavior and corrected default types.
35 files changed.
Test Plan
tox -e unitpasses with updated assertions expecting errors(confirming the YAML fixes in PRs 1a/1b/2 are complete)
Test Result
Submission Checklist
Risk level
Low — promotes an existing diagnostic to a build-breaking error; only
triggers if type mismatches exist, which PRs 1a/1b/2 have eliminated.
Associated ticket: N/A
PR Series