Repository navigation
[tensilelite] Fix YAML parameter type mismatches and promote to hard error - #8623
Closed
jaopaulolc wants to merge 1 commit into
Closed
jaopaulolc wants to merge 1 commit into
jaopaulolc wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.90%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #8623 +/- ##
========================================
Coverage 64.81% 64.81%
========================================
Files 2613 2613
Lines 407102 407083 -19
Branches 60785 60790 +5
========================================
- Hits 263840 263835 -5
+ Misses 123272 123254 -18
- Partials 19990 19994 +4
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
…error Fix parameter type mismatches across hipblaslt and hipsparselt that cause std::bad_cast at runtime due to msgpack wire type differences for int vs bool. Type corrections applied: - int -> bool: Activation, BufferStore, ExpandPointerSwap, LDSTrInst, MIArchVgpr, NoReject, PreloadKernArgs, SourceSwap, StorePriorityOpt, TailloopInNll, TransposeA, TransposeB, Use64bShadowLimit - bool -> int: DirectToLds, DirectToLdsMetadata, SwapGlobalReadOrder, TransposeLDSMetadata, UsePLRPack - int -> float: GlobalReadPerMfma - float -> int: StaggerUStride Promote the type mismatch diagnostic from warning to hard error in TensileCreateLibrary so future mismatches fail the build immediately. Fix GlobalReadPerMfma default in GlobalParameters.py from [1] to [1.0].
jaopaulolc
force-pushed
the
users/jolabega/fix-parameter-type-mismatch
branch
from
June 22, 2026 17:30
d16e615 to
6956cdf
Compare
Contributor
Author
|
Splitting into 3 smaller PRs for GitHub rendering: parts 1/3, 2/3, and 3/3 (error promotion last). |
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TensileLite YAML solution files and CustomKernel assembly files contained parameter type mismatches (e.g.,
intwhereboolis expected,intwherefloatis expected). Because msgpack serializesboolandintas different wire types, these mismatches causestd::bad_castat runtime.The existing build-time check only emitted a warning, allowing broken files to ship silently.
Changes
Fix all existing type mismatches
Corrected types across hipblaslt library YAML, hipblaslt test YAML, hipblaslt CustomKernels (.s), and hipsparselt library YAML:
Promote type mismatch warning to hard error
printTypeMismatchSummary()inTensileCreateLibrary/Run.pynow raisesRuntimeErrorwhen mismatches are detected, failing the build immediately instead of continuing with a warning.Fix GlobalReadPerMfma default type
Changed the default value in
GlobalParameters.pyfrom[1](int) to[1.0](float) so inherited defaults don't trigger the type check.Test Plan
test_validateParameterTypes.pyto assert RuntimeError is raised on mismatch detectionRisk level
Low — the YAML/assembly fixes are purely data corrections (values semantically unchanged, just typed correctly), and the hard error only triggers on genuinely broken files that would already fail at runtime.
Submission Checklist