Repository navigation
Update TheRock reference to (c9bde5b) - #12826
Merged
Merged
Conversation
github-actions
Bot
added
github actions
project: none
|
🤖 Bump PR detected (author |
assistant-librarian
Bot
added
the
external contribution
This was referenced Oct 1, 2026
Contributor
CI review: flake / tracked / new breakdownVerdict: safe to merge (override expected). This bump doesn't add CI red beyond what's tracked in Project 231. Every remaining red is infra (GPU hangs on the gfx950 pool, a DNS failure, a Windows runner setup failure) or rocm-systems-owned. Still needs code-owner review. Two things changed versus #12707 (closed, superseded by this one): MIOpen gfx94X FP8/BFP8 passes again (I think the #12707 failure was the hipBLASLt race fixed by #12615, not the bump; details on #11116), and Per-failure disposition (rocm-libraries scope)
rocm-systems-owned reds (visibility only)
( What this bump actually brings inTheRock
TheRock itself: GPU family matrix consolidation with trigger-based test selection (ROCm/TheRock#8322, which moves gfx950 testing to bump PRs only), RCCL comprehensive tests for gfx950, a clinfo OpenCL sanity check, Actions permission scoping, and Windows MSI build workflow work. Writes made in this review
|
tony-davis
approved these changes
Oct 2, 2026
1 task done
Contributor
Author
TheRock Submodule Bump ActivityNewest first
|
tony-davis
added a commit
that referenced
this pull request
Oct 21, 2026
…testing redesign (#12997) > **Reading this PR:** the diffs are hard to follow, so here are both files rendered as they stand on this branch. The links follow the branch, so they always show the latest commit. > > - [projects/hipblaslt/TESTING.md](https://github.com/ROCm/rocm-libraries/blob/users/tony-davis/AIHPBLAS-5028-testing-md-tracking/projects/hipblaslt/TESTING.md) > - [projects/hipblaslt/tensilelite/TESTING.md](https://github.com/ROCm/rocm-libraries/blob/users/tony-davis/AIHPBLAS-5028-testing-md-tracking/projects/hipblaslt/tensilelite/TESTING.md) JIRA ID : AIHPBLAS-5028 ## Motivation hipBLASLt is AMD's matrix-multiply (GEMM) library, and TensileLite is the Python code generator that writes its GPU kernels. Each has a TESTING.md that describes how it's tested today and ends with a "Known Risks and Gaps" table and an "Improvement Roadmap". While checking those against current CI, I found a lot of specific shortcomings, and most of them had no ticket. This PR records them and gives each one a ticket. It's the first step of a bigger effort, though, not the plan. Testing across these two products is pretty scattered, and I think it needs a top-down redesign rather than a longer list of fixes. That redesign comes in the PRs stacked on this one: a shared testing plan, an inventory of every suite, and a coverage model. So the roadmap sections here are framed as tactical findings. They aren't a commitment or a priority order. ## Technical Details Docs only. No code, test, or CI configuration changes. - **Every gap row and roadmap item names a ticket.** New work items are under the epic AIHPBLAS-5028, plus #12996 for the out-of-date required-check list in docs/gardening.md. Where an existing ticket already covered a gap, the row uses it. For example, the rows about Math CI's `preliminary` job point at AIHPBLAS-3354, which moves TensileLite testing to TheRock CI, since Math CI is being retired. - **The roadmap sections are reframed.** Each one now opens by saying it's not yet a plan, and its items are grouped by kind of work ("Process and policy fixes", "Structural changes", "Larger investments") instead of near, medium, and longer term. - **Six rows and three roadmap items are removed.** Four of the gaps are closed on develop: TheRock now runs hipBLASLt tiers through CTest, submodule-bump PRs run more tests rather than fewer, gfx950 runs per PR in Multi-Arch CI, and TheRock's installed-artifact lane now has the snapshot-test plugin (syrupy). `preliminary`'s target-branch condition no longer exists. The last one is a Math CI job name we don't plan to change, since Math CI is going away. - **Four rows are added** from existing tickets: large-size address arithmetic (AIHPBLAS-4988), tests of the public API itself (AIHPBLAS-3579), the library-logic check skipping derived-parameter assignment (AIHPBLAS-3575), and no sanitizer lane being a required check (AIHPBLAS-1079). - **Body text that no longer matched CI is corrected.** The ones most likely to change how someone reads a CI result: - The TensileLite coverage floor blocks a merge. Its lane rolls up to `Component CI Summary`, which the develop ruleset requires. The floor is 82%, not 75%. - The required checks are `Math CI Summary`, `pre-commit`, `Multi-Arch CI Summary` and `Component CI Summary`. Neither AddressSanitizer (ASAN) lane is one of them. - gfx950 runs per PR in TheRock Multi-Arch CI at the `standard` tier, as of the TheRock pin bump in #12826. - Math CI schedules a PR by its `project:` label, and the labeler doesn't give that label to `shared/rocroller` or `shared/mxdatagenerator`. So a PR that only touches those gets no hipBLASLt Math CI jobs at all. - Smaller fixes: Math CI runs multi-GPU tests on two gfx950 GPUs, the mutation-testing slice is ten files, one test file and one corpus check were removed in #11777, a dead cmake link, and the current rocPTS nightly details. - **Rebased onto develop.** develop changed both files after this PR opened: the TensileLite lowercase namespace move (#12150, #13399), and the ASAN lane change in #13126. I kept develop's paths and lane facts. One exception: #13126 marks the gfx90a HOST_ASAN lane as gating, but `hipBLASLt ASAN CI Summary` isn't a required check in the develop ruleset, so the table says it doesn't gate. I also updated six other passages that still described full ASAN on gfx90a per PR, and two TensileLite links that still used the old `Tensile/` path. ## Test Plan Docs only, so the checks are about accuracy and links: - `pre-commit run --files` on both files. - Resolve every relative link and in-document anchor in both files. - Resolve every Jira key and GitHub link through the Jira REST API and `gh api`. - Check each corrected statement against develop, TheRock at the pinned commit, rocJenkins at its live branch, and the develop ruleset (`gh api repos/ROCm/rocm-libraries/rules/branches/develop`). ## Test Result - `pre-commit` passes. The Markdown files fall outside every hook's file filter, so I also checked trailing whitespace, links, and anchors with a script. - All Jira keys and GitHub references resolved when this PR was first checked, and the rebase and reframing added none. - The original corrections were checked against develop at f4ec50c and TheRock c9bde5b. After the rebase I rechecked the ASAN lanes and the required checks against develop at 67b685e. I haven't re-audited every other statement against TheRock 76bd097, which develop pins now. - Automated GitHub checks are pending. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests. ## Risk level Low (1/5): documentation only. No product, test, CI, or device behavior changes. The main risk is that one of the corrections is itself wrong, which is what review is for. --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated all pinned TheRock workflow and source refs to
c9bde5bdue to submodule bumpBaseline run ID: 36617503899