Skip to content

[tensilelite] Fix type mismatches in gfx942 GridBased/80cu/228cu library YAML (1b/3) - #8681

Closed
jaopaulolc wants to merge 1 commit into
developfrom
users/jolabega/fix-type-mismatch-gfx942-gridbased
Closed

jaopaulolc wants to merge 1 commit into
developfrom
users/jolabega/fix-type-mismatch-gfx942-gridbased

Conversation

@jaopaulolc

@jaopaulolc jaopaulolc commented Jun 22, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

TensileLite device library YAML files for gfx942 GridBased, gfx942_80cu,
and gfx942_228cu configurations contain parameter type mismatches (int
stored where bool or float is expected). These cause std::bad_cast
exceptions at runtime when msgpack deserialization encounters unexpected
wire types.

This is part 1b of a 3-part series splitting #8623 into reviewable
chunks. This PR covers the GridBased subdirectory and multi-CU variants.

Technical Details

Bulk regex fixes applied to 62 YAML library logic files under
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/aquavanjaram/:

  • gfx942/GridBased/
  • gfx942_80cu/
  • gfx942_228cu/

Conversions:

  • int → bool: Activation, SourceSwap, TailloopInNll, TransposeA, TransposeB
    (e.g. Activation: 1 → Activation: true)
  • int → float: GlobalReadPerMfma
    (e.g. GlobalReadPerMfma: 1 → GlobalReadPerMfma: 1.0)

No logic or behavior change; only corrects serialized types to match
TensileLite's schema expectations.

Test Plan

  • Device library build for gfx942 passes type validation with zero mismatches
  • CI gating builds for hipblaslt and hipsparselt pass
  • Unit tests in test_validateParameterTypes.py confirm correct type detection

Test Result

  • Local device library build completed with 0 type mismatch warnings
  • Existing unit tests pass

Submission Checklist

Risk level

None — data-only change correcting serialized types to match schema; no logic change.

Associated ticket: N/A

PR Series

# PR Files URL
1a FreeSize gfx942 YAML fixes 178 #8680
1b GridBased/80cu/228cu gfx942 YAML fixes 62 #8681 👈
2 gfx950/gfx1250/gfx11xx YAML + CustomKernels + hipsparselt ~120 #8678
3 Error promotion + test/config fixes 35 #8679

…ary YAML (1b/3)

Fix parameter type mismatches in aquavanjaram/gfx942 GridBased,
gfx942_80cu, and gfx942_228cu logic files that cause std::bad_cast
at runtime due to msgpack wire-type mismatch:

- int -> bool: Activation, SourceSwap, TailloopInNll, TransposeA, TransposeB
- int -> float: GlobalReadPerMfma
@jaopaulolc

Copy link
Copy Markdown
Contributor Author

Superseded: split further by file size into two PRs due to GitHub's diff rendering limit on large files.

@jaopaulolc jaopaulolc closed this Jun 22, 2026
@jaopaulolc
jaopaulolc deleted the users/jolabega/fix-type-mismatch-gfx942-gridbased branch June 22, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: hipblaslt rocm:gemm algos Label to identify PRs of the GEMM Algorithms team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant