Repository navigation
[tensilelite] Fix type mismatches in gfx942 GridBased/80cu/228cu library YAML (1b/3) - #8681
Closed
jaopaulolc wants to merge 1 commit into
Closed
jaopaulolc wants to merge 1 commit into
jaopaulolc wants to merge 1 commit into
Conversation
…ary YAML (1b/3) Fix parameter type mismatches in aquavanjaram/gfx942 GridBased, gfx942_80cu, and gfx942_228cu logic files that cause std::bad_cast at runtime due to msgpack wire-type mismatch: - int -> bool: Activation, SourceSwap, TailloopInNll, TransposeA, TransposeB - int -> float: GlobalReadPerMfma
This was referenced Jun 22, 2026
Contributor
Author
|
Superseded: split further by file size into two PRs due to GitHub's diff rendering limit on large files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TensileLite device library YAML files for gfx942 GridBased, gfx942_80cu,
and gfx942_228cu configurations contain parameter type mismatches (int
stored where bool or float is expected). These cause
std::bad_castexceptions at runtime when msgpack deserialization encounters unexpected
wire types.
This is part 1b of a 3-part series splitting #8623 into reviewable
chunks. This PR covers the GridBased subdirectory and multi-CU variants.
Technical Details
Bulk regex fixes applied to 62 YAML library logic files under
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/aquavanjaram/:gfx942/GridBased/gfx942_80cu/gfx942_228cu/Conversions:
Activation,SourceSwap,TailloopInNll,TransposeA,TransposeB(e.g.
Activation: 1→Activation: true)GlobalReadPerMfma(e.g.
GlobalReadPerMfma: 1→GlobalReadPerMfma: 1.0)No logic or behavior change; only corrects serialized types to match
TensileLite's schema expectations.
Test Plan
test_validateParameterTypes.pyconfirm correct type detectionTest Result
Submission Checklist
Risk level
None — data-only change correcting serialized types to match schema; no logic change.
Associated ticket: N/A
PR Series