[rocRAND] Add missing include for utility header by umfranzw · Pull Request #599 · ROCm/rocm-libraries

umfranzw · 2025-07-11T16:28:21Z

The file rocrand/library/include/rocrand/rocrand_common.h was missing an include for the utility header.
This header is needed to provide std::declval.

rocrand/library/include/rocrand/rocrand_common.h was missing an include for the utility header. This header is needed for std::declval.

codecov-commenter · 2025-07-11T17:08:45Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (52.17%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #599      +/-   ##
===========================================
- Coverage    52.19%   52.17%   -0.01%     
===========================================
  Files           63       63              
  Lines         7437     7437              
  Branches       799      799              
===========================================
- Hits          3881     3880       -1     
  Misses        3239     3239              
- Partials       317      318       +1

Flag	Coverage Δ
rocRAND	`52.17% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...s/rocrand/library/include/rocrand/rocrand_common.h	`100.00% <ø> (ø)`

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

NguyenNhuDi

lgtm

[rocRAND] Add missing include for utility header (#599) The file rocrand/library/include/rocrand/rocrand_common.h was missing an include for the utility header. This header is needed to provide `std::declval`.

Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.18.1 to 1.18.2. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.18.1...v1.18.2) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-version: 1.18.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [ROCm/hipSPARSE commit: a7f2a4b]

… and non-unit scale factor (#599) Keep `scale_factor` as part of the `last_cpu_fft_data` and use it in evaluating validity thereof [ROCm/rocFFT commit: 61ebe75]

Remove unnecessary const keyword to avoid compiler warnings

Remove unnecessary const keyword to avoid compiler warnings [ROCm/rocwmma commit: eb4cffd]

[ROCm/rpp commit: a9c3104]

* Update dependency names for static builds (ROCm#557) This also removes the line setting `BUILD_SHARED_LIBS` to `ON`, which was previously required to get the correctly named packages when not specifically compiling for a static build. Updates to the ROCmCMakeBuildTools (rocm-cmake) should mean this is no longer necessary. * Fix BUILD_SHARED_LIBS for packaging (ROCm#558) * Fix the dependencies of the static packages (ROCm#563) * cmake: don't set CMAKE_C_COMPILER, as rocPRIM is a CXX project (ROCm#567) * add developer guidelines (ROCm#555) (ROCm#574) Co-authored-by: Nol Moonen <nol@streamhpc.com> * Update Read the Docs config to Python 3.10 and latest rocm-docs-core (ROCm#564) (ROCm#579) * Cherry-pick: Optimize block_reduce_warp_reduce when block size is the same as warp size (ROCm#599) * Optimize block_reduce_warp_reduce when block size == warp size * Make conditional constexpr * Fix conflict in concepts.rst --------- Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Steve Leung <Steve.Leung@amd.com> Co-authored-by: randyh62 <42045079+randyh62@users.noreply.github.com> Co-authored-by: Nol Moonen <nol@streamhpc.com> Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com> [ROCm/rocPRIM commit: 4dca5b7]

* Remove website URL from comments (ROCm#600) Referencing or using code from some websites is prohibited in this repository. This change removes an informational reference in the comments. * Fix rare memory access faults when using internal serial merge (ROCm#597) * test: add tests for internal serial merge function * refactor(detail/merge_path.hpp): removed code duplication * fix(detail/merge_path.hpp): stricter boundary checking in serial merge * fix(detail/block_sort_merge.hpp): fix missing block-wide sync During a previous refactor, serial_merge does no longer do a block sync. This has now been re-added. * feat: add unsafe variant of serial merge * fix: use bounded version for serial merge to fix rare page faults * test(test_internal_merge_path): clean up internal merge path tests * style: standardize range_t<> construction * fix(detail/merge_path.hpp): fix 'range_t<>::count1()' and 'range_t<>::count2()' return types to be same as encapsulated type * perf(detail/merge_path.hpp): use const ref in function parameters * refactor(detail/merge_path.hpp): replace redundant use of 'OffsetT' with 'unsigned int' * chore: update changelog * fix: restore missing thread sync This got removed during a rebase. * Add gfx1151 target (ROCm#601) (ROCm#603) Co-authored-by: Stanley Tsang <stanley.tsang@amd.com> * Merge back 6.2 hotfixes (ROCm#607) (ROCm#620) * Update dependency names for static builds (ROCm#557) This also removes the line setting `BUILD_SHARED_LIBS` to `ON`, which was previously required to get the correctly named packages when not specifically compiling for a static build. Updates to the ROCmCMakeBuildTools (rocm-cmake) should mean this is no longer necessary. * Fix BUILD_SHARED_LIBS for packaging (ROCm#558) * Fix the dependencies of the static packages (ROCm#563) * cmake: don't set CMAKE_C_COMPILER, as rocPRIM is a CXX project (ROCm#567) * add developer guidelines (ROCm#555) (ROCm#574) * Update Read the Docs config to Python 3.10 and latest rocm-docs-core (ROCm#564) (ROCm#579) * Cherry-pick: Optimize block_reduce_warp_reduce when block size is the same as warp size (ROCm#599) * Optimize block_reduce_warp_reduce when block size == warp size * Make conditional constexpr * Fix conflict in concepts.rst --------- Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Steve Leung <Steve.Leung@amd.com> Co-authored-by: randyh62 <42045079+randyh62@users.noreply.github.com> Co-authored-by: Nol Moonen <nol@streamhpc.com> Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com> * Changed precondition for edge case in serial_merge to prevent assertion error (ROCm#622) * added std::min to ensure no out of bound acess * fixed typo keys->keys1 * updated changelog * reverted std::min * implemented suggested logic * edited to conform to standards (ROCm#618) * Memory leak fix for multiple rocPRIM unit tests (ROCm#614) * fixed mem leak in test_config_dispatch.cpp * added missing hip free for method==4 in test_block_scan.kernels * added graphHelpeer class that does not cause memory leak due to using hipGraphCreate * replaced old hipGraph helpers with new class in device_bin_search * changed HIP_CHECK_NON_VOID to HIP_CHECK * fixed mem leak in device_bin_search * added additional functions * changed out old calls to hipGraphCrete to new GraphHelper class * added missing stream sync for hipgrag_algs * n * added missing hipFree and HIP_CHECK for lookback_reproducibility * added missing hipFree in test_discard_iterator * fixed test failures * removed extra hipFree * removed unused variables * updated change log * removed redundant function --------- Co-authored-by: Your Name <you@example.com> Co-authored-by: root <root@x1001c6s0b1n0.hostmgmt2001.cm.lockhart.amd.com> * changed to using gHelper * merged 6.3 version of merge_sort_merge_path (failing large indices test) * updated mergepath to have fix for large indices * updated the changelog for 6.3 (ROCm#632) * updated changelog for test_utils_hipgraph change * updated changelog --------- Co-authored-by: Wayne Franz <wayfranz@amd.com> Co-authored-by: Nara <nara@streamhpc.com> Co-authored-by: amd-garydeng <garydeng@amd.com> Co-authored-by: Stanley Tsang <stanley.tsang@amd.com> Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Steve Leung <Steve.Leung@amd.com> Co-authored-by: randyh62 <42045079+randyh62@users.noreply.github.com> Co-authored-by: Nol Moonen <nol@streamhpc.com> Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Your Name <you@example.com> Co-authored-by: root <root@x1001c6s0b1n0.hostmgmt2001.cm.lockhart.amd.com> [ROCm/rocPRIM commit: 44159bd]

* Remove website URL from comments (ROCm#600) Referencing or using code from some websites is prohibited in this repository. This change removes an informational reference in the comments. * Fix rare memory access faults when using internal serial merge (ROCm#597) * test: add tests for internal serial merge function * refactor(detail/merge_path.hpp): removed code duplication * fix(detail/merge_path.hpp): stricter boundary checking in serial merge * fix(detail/block_sort_merge.hpp): fix missing block-wide sync During a previous refactor, serial_merge does no longer do a block sync. This has now been re-added. * feat: add unsafe variant of serial merge * fix: use bounded version for serial merge to fix rare page faults * test(test_internal_merge_path): clean up internal merge path tests * style: standardize range_t<> construction * fix(detail/merge_path.hpp): fix 'range_t<>::count1()' and 'range_t<>::count2()' return types to be same as encapsulated type * perf(detail/merge_path.hpp): use const ref in function parameters * refactor(detail/merge_path.hpp): replace redundant use of 'OffsetT' with 'unsigned int' * chore: update changelog * fix: restore missing thread sync This got removed during a rebase. * Add gfx1151 target (ROCm#601) (ROCm#603) Co-authored-by: Stanley Tsang <stanley.tsang@amd.com> * Merge back 6.2 hotfixes (ROCm#607) (ROCm#620) * Update dependency names for static builds (ROCm#557) This also removes the line setting `BUILD_SHARED_LIBS` to `ON`, which was previously required to get the correctly named packages when not specifically compiling for a static build. Updates to the ROCmCMakeBuildTools (rocm-cmake) should mean this is no longer necessary. * Fix BUILD_SHARED_LIBS for packaging (ROCm#558) * Fix the dependencies of the static packages (ROCm#563) * cmake: don't set CMAKE_C_COMPILER, as rocPRIM is a CXX project (ROCm#567) * add developer guidelines (ROCm#555) (ROCm#574) * Update Read the Docs config to Python 3.10 and latest rocm-docs-core (ROCm#564) (ROCm#579) * Cherry-pick: Optimize block_reduce_warp_reduce when block size is the same as warp size (ROCm#599) * Optimize block_reduce_warp_reduce when block size == warp size * Make conditional constexpr * Fix conflict in concepts.rst --------- Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Steve Leung <Steve.Leung@amd.com> Co-authored-by: randyh62 <42045079+randyh62@users.noreply.github.com> Co-authored-by: Nol Moonen <nol@streamhpc.com> Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com> * Changed precondition for edge case in serial_merge to prevent assertion error (ROCm#622) * added std::min to ensure no out of bound acess * fixed typo keys->keys1 * updated changelog * reverted std::min * implemented suggested logic * edited to conform to standards (ROCm#618) * Memory leak fix for multiple rocPRIM unit tests (ROCm#614) * fixed mem leak in test_config_dispatch.cpp * added missing hip free for method==4 in test_block_scan.kernels * added graphHelpeer class that does not cause memory leak due to using hipGraphCreate * replaced old hipGraph helpers with new class in device_bin_search * changed HIP_CHECK_NON_VOID to HIP_CHECK * fixed mem leak in device_bin_search * added additional functions * changed out old calls to hipGraphCrete to new GraphHelper class * added missing stream sync for hipgrag_algs * n * added missing hipFree and HIP_CHECK for lookback_reproducibility * added missing hipFree in test_discard_iterator * fixed test failures * removed extra hipFree * removed unused variables * updated change log * removed redundant function --------- Co-authored-by: Your Name <you@example.com> Co-authored-by: root <root@x1001c6s0b1n0.hostmgmt2001.cm.lockhart.amd.com> * updated the changelog for 6.3 (ROCm#632) * updated default gpu to include gfx12 and gfx1151 * updated changelog * fixed minor grammar mistake in changelog * Update CHANGELOG.md Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> * Remove gfx940,gfx941 targets (ROCm#639) * Update rocPRIM version --------- Co-authored-by: Wayne Franz <wayfranz@amd.com> Co-authored-by: Nara <nara@streamhpc.com> Co-authored-by: amd-garydeng <garydeng@amd.com> Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Steve Leung <Steve.Leung@amd.com> Co-authored-by: randyh62 <42045079+randyh62@users.noreply.github.com> Co-authored-by: Nol Moonen <nol@streamhpc.com> Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com> Co-authored-by: Di Nguyen <dinguyennhu@gmail.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Your Name <you@example.com> Co-authored-by: root <root@x1001c6s0b1n0.hostmgmt2001.cm.lockhart.amd.com> Co-authored-by: Val Movsik <160653499+vamovsik@users.noreply.github.com> [ROCm/rocPRIM commit: ffd6685]

* Update dependency names for static builds (ROCm#557) This also removes the line setting `BUILD_SHARED_LIBS` to `ON`, which was previously required to get the correctly named packages when not specifically compiling for a static build. Updates to the ROCmCMakeBuildTools (rocm-cmake) should mean this is no longer necessary. * Fix BUILD_SHARED_LIBS for packaging (ROCm#558) * Fix the dependencies of the static packages (ROCm#563) * cmake: don't set CMAKE_C_COMPILER, as rocPRIM is a CXX project (ROCm#567) * add developer guidelines (ROCm#555) (ROCm#574) Co-authored-by: Nol Moonen <nol@streamhpc.com> * Update Read the Docs config to Python 3.10 and latest rocm-docs-core (ROCm#564) (ROCm#579) * Cherry-pick: Optimize block_reduce_warp_reduce when block size is the same as warp size (ROCm#599) * Optimize block_reduce_warp_reduce when block size == warp size * Make conditional constexpr * Fix conflict in concepts.rst --------- Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Steve Leung <Steve.Leung@amd.com> Co-authored-by: randyh62 <42045079+randyh62@users.noreply.github.com> Co-authored-by: Nol Moonen <nol@streamhpc.com> Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com> [ROCm/rocPRIM commit: 4dca5b7]

* Remove website URL from comments (ROCm#600) Referencing or using code from some websites is prohibited in this repository. This change removes an informational reference in the comments. * Fix rare memory access faults when using internal serial merge (ROCm#597) * test: add tests for internal serial merge function * refactor(detail/merge_path.hpp): removed code duplication * fix(detail/merge_path.hpp): stricter boundary checking in serial merge * fix(detail/block_sort_merge.hpp): fix missing block-wide sync During a previous refactor, serial_merge does no longer do a block sync. This has now been re-added. * feat: add unsafe variant of serial merge * fix: use bounded version for serial merge to fix rare page faults * test(test_internal_merge_path): clean up internal merge path tests * style: standardize range_t<> construction * fix(detail/merge_path.hpp): fix 'range_t<>::count1()' and 'range_t<>::count2()' return types to be same as encapsulated type * perf(detail/merge_path.hpp): use const ref in function parameters * refactor(detail/merge_path.hpp): replace redundant use of 'OffsetT' with 'unsigned int' * chore: update changelog * fix: restore missing thread sync This got removed during a rebase. * Add gfx1151 target (ROCm#601) (ROCm#603) Co-authored-by: Stanley Tsang <stanley.tsang@amd.com> * Merge back 6.2 hotfixes (ROCm#607) (ROCm#620) * Update dependency names for static builds (ROCm#557) This also removes the line setting `BUILD_SHARED_LIBS` to `ON`, which was previously required to get the correctly named packages when not specifically compiling for a static build. Updates to the ROCmCMakeBuildTools (rocm-cmake) should mean this is no longer necessary. * Fix BUILD_SHARED_LIBS for packaging (ROCm#558) * Fix the dependencies of the static packages (ROCm#563) * cmake: don't set CMAKE_C_COMPILER, as rocPRIM is a CXX project (ROCm#567) * add developer guidelines (ROCm#555) (ROCm#574) * Update Read the Docs config to Python 3.10 and latest rocm-docs-core (ROCm#564) (ROCm#579) * Cherry-pick: Optimize block_reduce_warp_reduce when block size is the same as warp size (ROCm#599) * Optimize block_reduce_warp_reduce when block size == warp size * Make conditional constexpr * Fix conflict in concepts.rst --------- Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Steve Leung <Steve.Leung@amd.com> Co-authored-by: randyh62 <42045079+randyh62@users.noreply.github.com> Co-authored-by: Nol Moonen <nol@streamhpc.com> Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com> * Changed precondition for edge case in serial_merge to prevent assertion error (ROCm#622) * added std::min to ensure no out of bound acess * fixed typo keys->keys1 * updated changelog * reverted std::min * implemented suggested logic * edited to conform to standards (ROCm#618) * Memory leak fix for multiple rocPRIM unit tests (ROCm#614) * fixed mem leak in test_config_dispatch.cpp * added missing hip free for method==4 in test_block_scan.kernels * added graphHelpeer class that does not cause memory leak due to using hipGraphCreate * replaced old hipGraph helpers with new class in device_bin_search * changed HIP_CHECK_NON_VOID to HIP_CHECK * fixed mem leak in device_bin_search * added additional functions * changed out old calls to hipGraphCrete to new GraphHelper class * added missing stream sync for hipgrag_algs * n * added missing hipFree and HIP_CHECK for lookback_reproducibility * added missing hipFree in test_discard_iterator * fixed test failures * removed extra hipFree * removed unused variables * updated change log * removed redundant function --------- Co-authored-by: Your Name <you@example.com> Co-authored-by: root <root@x1001c6s0b1n0.hostmgmt2001.cm.lockhart.amd.com> * changed to using gHelper * merged 6.3 version of merge_sort_merge_path (failing large indices test) * updated mergepath to have fix for large indices * updated the changelog for 6.3 (ROCm#632) * updated changelog for test_utils_hipgraph change * updated changelog --------- Co-authored-by: Wayne Franz <wayfranz@amd.com> Co-authored-by: Nara <nara@streamhpc.com> Co-authored-by: amd-garydeng <garydeng@amd.com> Co-authored-by: Stanley Tsang <stanley.tsang@amd.com> Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Steve Leung <Steve.Leung@amd.com> Co-authored-by: randyh62 <42045079+randyh62@users.noreply.github.com> Co-authored-by: Nol Moonen <nol@streamhpc.com> Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Your Name <you@example.com> Co-authored-by: root <root@x1001c6s0b1n0.hostmgmt2001.cm.lockhart.amd.com> [ROCm/rocPRIM commit: 44159bd]

* Remove website URL from comments (ROCm#600) Referencing or using code from some websites is prohibited in this repository. This change removes an informational reference in the comments. * Fix rare memory access faults when using internal serial merge (ROCm#597) * test: add tests for internal serial merge function * refactor(detail/merge_path.hpp): removed code duplication * fix(detail/merge_path.hpp): stricter boundary checking in serial merge * fix(detail/block_sort_merge.hpp): fix missing block-wide sync During a previous refactor, serial_merge does no longer do a block sync. This has now been re-added. * feat: add unsafe variant of serial merge * fix: use bounded version for serial merge to fix rare page faults * test(test_internal_merge_path): clean up internal merge path tests * style: standardize range_t<> construction * fix(detail/merge_path.hpp): fix 'range_t<>::count1()' and 'range_t<>::count2()' return types to be same as encapsulated type * perf(detail/merge_path.hpp): use const ref in function parameters * refactor(detail/merge_path.hpp): replace redundant use of 'OffsetT' with 'unsigned int' * chore: update changelog * fix: restore missing thread sync This got removed during a rebase. * Add gfx1151 target (ROCm#601) (ROCm#603) Co-authored-by: Stanley Tsang <stanley.tsang@amd.com> * Merge back 6.2 hotfixes (ROCm#607) (ROCm#620) * Update dependency names for static builds (ROCm#557) This also removes the line setting `BUILD_SHARED_LIBS` to `ON`, which was previously required to get the correctly named packages when not specifically compiling for a static build. Updates to the ROCmCMakeBuildTools (rocm-cmake) should mean this is no longer necessary. * Fix BUILD_SHARED_LIBS for packaging (ROCm#558) * Fix the dependencies of the static packages (ROCm#563) * cmake: don't set CMAKE_C_COMPILER, as rocPRIM is a CXX project (ROCm#567) * add developer guidelines (ROCm#555) (ROCm#574) * Update Read the Docs config to Python 3.10 and latest rocm-docs-core (ROCm#564) (ROCm#579) * Cherry-pick: Optimize block_reduce_warp_reduce when block size is the same as warp size (ROCm#599) * Optimize block_reduce_warp_reduce when block size == warp size * Make conditional constexpr * Fix conflict in concepts.rst --------- Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Steve Leung <Steve.Leung@amd.com> Co-authored-by: randyh62 <42045079+randyh62@users.noreply.github.com> Co-authored-by: Nol Moonen <nol@streamhpc.com> Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com> * Changed precondition for edge case in serial_merge to prevent assertion error (ROCm#622) * added std::min to ensure no out of bound acess * fixed typo keys->keys1 * updated changelog * reverted std::min * implemented suggested logic * edited to conform to standards (ROCm#618) * Memory leak fix for multiple rocPRIM unit tests (ROCm#614) * fixed mem leak in test_config_dispatch.cpp * added missing hip free for method==4 in test_block_scan.kernels * added graphHelpeer class that does not cause memory leak due to using hipGraphCreate * replaced old hipGraph helpers with new class in device_bin_search * changed HIP_CHECK_NON_VOID to HIP_CHECK * fixed mem leak in device_bin_search * added additional functions * changed out old calls to hipGraphCrete to new GraphHelper class * added missing stream sync for hipgrag_algs * n * added missing hipFree and HIP_CHECK for lookback_reproducibility * added missing hipFree in test_discard_iterator * fixed test failures * removed extra hipFree * removed unused variables * updated change log * removed redundant function --------- Co-authored-by: Your Name <you@example.com> Co-authored-by: root <root@x1001c6s0b1n0.hostmgmt2001.cm.lockhart.amd.com> * updated the changelog for 6.3 (ROCm#632) * updated default gpu to include gfx12 and gfx1151 * updated changelog * fixed minor grammar mistake in changelog * Update CHANGELOG.md Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> * Remove gfx940,gfx941 targets (ROCm#639) * Update rocPRIM version --------- Co-authored-by: Wayne Franz <wayfranz@amd.com> Co-authored-by: Nara <nara@streamhpc.com> Co-authored-by: amd-garydeng <garydeng@amd.com> Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Steve Leung <Steve.Leung@amd.com> Co-authored-by: randyh62 <42045079+randyh62@users.noreply.github.com> Co-authored-by: Nol Moonen <nol@streamhpc.com> Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com> Co-authored-by: Di Nguyen <dinguyennhu@gmail.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Your Name <you@example.com> Co-authored-by: root <root@x1001c6s0b1n0.hostmgmt2001.cm.lockhart.amd.com> Co-authored-by: Val Movsik <160653499+vamovsik@users.noreply.github.com> [ROCm/rocPRIM commit: ffd6685]

Add missing include for utility header

4f8fa0c

rocrand/library/include/rocrand/rocrand_common.h was missing an include for the utility header. This header is needed for std::declval.

umfranzw requested a review from NguyenNhuDi July 11, 2025 16:28

umfranzw requested a review from stanleytsang-amd as a code owner July 11, 2025 16:28

umfranzw added the project: rocrand label Jul 11, 2025

umfranzw requested a review from RobsonRLemos as a code owner July 11, 2025 16:28

NguyenNhuDi approved these changes Jul 11, 2025

View reviewed changes

stanleytsang-amd approved these changes Jul 11, 2025

View reviewed changes

umfranzw merged commit 1d9fa69 into ROCm:develop Jul 11, 2025

ammallya pushed a commit that referenced this pull request Oct 27, 2025

Merge pull request #599 from bsyrowik/fix_compile_warning

eb4cffd

Remove unnecessary const keyword to avoid compiler warnings

ammallya pushed a commit that referenced this pull request Oct 28, 2025

Merge pull request #599 from bsyrowik/fix_compile_warning

8e27e33

Remove unnecessary const keyword to avoid compiler warnings [ROCm/rocwmma commit: eb4cffd]

ammallya pushed a commit that referenced this pull request Jun 8, 2026

Half - Update FindHALF.cmake (#599)

a9c3104

kliegeois pushed a commit to kliegeois/rocm-libraries that referenced this pull request Jun 8, 2026

Half - Update FindHALF.cmake (ROCm#599)

26a36e7

[ROCm/rpp commit: a9c3104]

AviralGoelAMD mentioned this pull request Oct 20, 2026

refactor(rocke): deduplicate conv/attention emitter clone groups #14078

Closed

Navigation Menu

Repository navigation

[rocRAND] Add missing include for utility header - #599

[rocRAND] Add missing include for utility header#599
umfranzw merged 1 commit into
ROCm:developfrom
umfranzw:add_utility_header

umfranzw commented Jul 11, 2025

Uh oh!

codecov-commenter commented Jul 11, 2025 •

edited

Loading

Uh oh!

NguyenNhuDi left a comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

umfranzw commented Jul 11, 2025

Uh oh!

codecov-commenter commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

NguyenNhuDi left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Jul 11, 2025 •

edited

Loading