Skip to content

[Ex CI] workflow fork test - do not merge#600

Closed
danielsu-amd wants to merge 79 commits into
ROCm:users/danielsu/az-dispatch-nonpollingfrom
danielsu-amd:users/danielsu/az-dispatch-nonpolling-fork-test
Closed

[Ex CI] workflow fork test - do not merge#600
danielsu-amd wants to merge 79 commits into
ROCm:users/danielsu/az-dispatch-nonpollingfrom
danielsu-amd:users/danielsu/az-dispatch-nonpolling-fork-test

Conversation

@danielsu-amd
Copy link
Copy Markdown
Contributor

No description provided.

@danielsu-amd danielsu-amd force-pushed the users/danielsu/az-dispatch-nonpolling branch from 780b9b7 to 685bc44 Compare July 11, 2025 16:50
@danielsu-amd danielsu-amd requested a review from a team as a code owner July 11, 2025 16:50
danielsu-amd added a commit that referenced this pull request Jul 11, 2025
Progress for #479

Reworks the Azure dispatch action to be nonpolling, which resolves the
360 minute timeout issue. It now creates a separate `Azure CI Summary`
check, which will be updated inside Azure pipeline runs via the
`report-summary-check.yml` template. This summary check is intended to
be marked as required.

Once an Azure pipelines run finishes, it will report its overall status
to the summary. If any jobs have failed or are cancelled, the summary
check will be marked as failed. If all jobs have succeeded, the summary
will pass.

Adds logic for handling rerunning the initial dispatch action, which
will either start new runs or rerun existing runs depending on the state
of the PR. Instructions for doing so are included directly in the
summary checks for easy access.

Overview of flow:
1. PR is created, `Trigger Azure CI` action is run on PR
2. `Trigger Azure CI` kicks off Azure runs and creates an `Azure CI
Summary` check
3. As Azure runs finish, `Azure CI Summary` is updated with their
statuses
4. After all runs are finished, `Azure CI Summary` will be marked as
successful or failed depending on the runs' statuses
5. If a rerun is desired, `Trigger Azure CI` can be rerun, which will
overwrite the existing `Azure CI Summary` with a new one

Sample runs:
Branch PR: #561 -
[summary](https://github.com/ROCm/rocm-libraries/pull/561/checks?check_run_id=45813198366)
Fork PR: #600 -
[summary](https://github.com/ROCm/rocm-libraries/pull/600/checks?check_run_id=45815418773)

Other stuff:
- Copied the Github CLI fallback logic from `pr_category_label.py` to
`pr_detect_changed_subtrees.py`
  - To fix dispatch action not running on PRs with infinite diffs
- Removed `paths-ignore` from dispatch action
@danielsu-amd danielsu-amd deleted the branch ROCm:users/danielsu/az-dispatch-nonpolling July 11, 2025 20:45
@danielsu-amd danielsu-amd deleted the users/danielsu/az-dispatch-nonpolling-fork-test branch July 11, 2025 20:46
danielsu-amd added a commit that referenced this pull request Jul 11, 2025
Progress for #479

Reworks the Azure dispatch action to be nonpolling, which resolves the
360 minute timeout issue. It now creates a separate `Azure CI Summary`
check, which will be updated inside Azure pipeline runs via the
`report-summary-check.yml` template. This summary check is intended to
be marked as required.

Once an Azure pipelines run finishes, it will report its overall status
to the summary. If any jobs have failed or are cancelled, the summary
check will be marked as failed. If all jobs have succeeded, the summary
will pass.

Adds logic for handling rerunning the initial dispatch action, which
will either start new runs or rerun existing runs depending on the state
of the PR. Instructions for doing so are included directly in the
summary checks for easy access.

Overview of flow:
1. PR is created, `Trigger Azure CI` action is run on PR
2. `Trigger Azure CI` kicks off Azure runs and creates an `Azure CI
Summary` check
3. As Azure runs finish, `Azure CI Summary` is updated with their
statuses
4. After all runs are finished, `Azure CI Summary` will be marked as
successful or failed depending on the runs' statuses
5. If a rerun is desired, `Trigger Azure CI` can be rerun, which will
overwrite the existing `Azure CI Summary` with a new one

Sample runs:
Branch PR: #561 -
[summary](https://github.com/ROCm/rocm-libraries/pull/561/checks?check_run_id=45813198366)
Fork PR: #600 -
[summary](https://github.com/ROCm/rocm-libraries/pull/600/checks?check_run_id=45815418773)

Other stuff:
- Copied the Github CLI fallback logic from `pr_category_label.py` to
`pr_detect_changed_subtrees.py`
  - To fix dispatch action not running on PRs with infinite diffs
- Removed `paths-ignore` from dispatch action
ammallya pushed a commit that referenced this pull request Jul 22, 2025
* Break up hipsparse.cpp into separate translation units

[ROCm/hipSPARSE commit: c9ffd19]
ammallya pushed a commit that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant