Repository navigation
refactor(rocke): deduplicate conv/attention emitter clone groups - #14078
Closed
AviralGoelAMD wants to merge 44 commits into
Closed
AviralGoelAMD wants to merge 44 commits into
AviralGoelAMD wants to merge 44 commits into
Conversation
…onv_direct_grouped.py (clone group #75)
…clone group #177)
…mma_common (clone group #281)
…a_warp_body.py (clone group #489)
…y (clone group #854)
…t_grouped.py (clone group #131)
…nv_direct_grouped.py (clone group #131)" This reverts commit 526e5f2.
…rocke.helpers.geometry (clone group #286)
…es into rocke.helpers.geometry (clone group #286)" This reverts commit 80a4037.
…mha_common (clone group #1040)
…mplicit_gemm_common (clone group #295)
…mma_common (clone group #1411)
…_setup (clone group #1411)
…e_attention.py (clone group #1232)
…_universal.py (clone group #646)
…_universal.py (clone group #646)
…onv_direct_grouped.py (clone group #686)
…v_implicit_gemm_common (clone group #658)
…nto _conv_implicit_gemm_common (clone group #658)" This reverts commit 54dd61d.
…opies (clone group #751)" This reverts commit f97b4a5.
…plicit_gemm_dgrad.py (clone group #950)
…plicit_gemm_dgrad.py (clone group #950)
… conv_implicit_gemm_dgrad.py (clone group #950)" This reverts commit 33535a7.
…v_direct_grouped.py (clone group #807)
…s in conv_direct_grouped.py (clone group #807)" This reverts commit aef89f5.
…rom conv_direct_grouped.py (clone groups #1102, #1332)
…irect_grouped.py (clone group #804)
…/wgrad (clone group #1335)
…lone group #1217)
…irect_grouped.py (clone group #1326)
… it from build_direct_conv_16c (clone group #1317)
…from conv_direct_grouped.py (clone groups #1020, #1215)
…ct_grouped.py (clone group #267)
…onv_direct_grouped.py (clone group #214)
…es in conv_direct_grouped.py (clone group #474)
…_direct_grouped.py (clone group #528)
…m 3 copies in conv_direct_grouped.py (clone group #474)" This reverts commit 4454298.
…irect_grouped.py (clone group #1315)
…ntion.py (clone group #1214)
…nv_direct_grouped.py (clone group #599)
…_direct_grouped.py (clone group #652)
…_direct_grouped.py (clone group #474 rework)
…rect_grouped.py (clone group #1195)
⏳ Waiting on Required Checks⏳ Required checks have not all concluded yet. This bot run is exiting without failing so those checks can report independently.
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
⏳ Waiting for required checks to start or finish:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deduplicate verbatim-cloned statement blocks in the rocKE Python kernel emitters, discovered mechanically with
clone_check --backlogagainstdevelop@503f5c82876and extracted into private helpers.29 clone groups fixed, all gated through
ir_snapshot.py verifybefore commit — emitted IR is byte-identical to the pre-refactor baseline for every change.Verification
ir_snapshot.py compare:IR IDENTICAL: 4522 verified entries byte-identical; 425 identical rejections(exit 0)pytest library/tests platform/tests: before344 failed, 61648 passed, 11995 skipped, after344 failed, 61648 passed, 11995 skipped— identical failure setjunit_cmp.py:PYTEST SAME— identical case IDs, failing/erroring IDs, and skipsExtractions
_emit_direct_params_tuple_implicit_gemm_output_config_iu8_gemm_lane_and_acc(gfx1151 WMMA)_online_softmax_update_decode_staged_slot(loads)_c_lane_rows_cols_declare_fmha_fwd_params_wmma_lane_tile_setup_direct_dgrad_params_read_direct_wgrad_params_conv_lds_dims_direct_dgrad_params_direct_conv_lane_setup_conv_io_buffer_rsrcs_fma_tap_load_direct_conv_builder_conv_lds_base_direct_store_offset_reorg_src_dst_off_direct_conv_h_loop_setup_direct_conv_h_loop_args_direct_conv_constants_direct_conv_q_constants_direct_conv_lane_head_sparse_builder_setup_gemm_universal_c_lane_direct_flush_acc_direct_conv_lane_s_sparse_q_setupSkips
196 distinct skip labels (219 pass-level rows; the ledger keys on the clone tool's per-pass numeric ID, not reconstructed content signatures). Breakdown: 165
too_small_after_alignment(shared run < 3 statements or < 6 lines), 16gate_failed(IR gate failed after retry — reverted), 8no_shared_home, 4control_flow(shared run contains adefwithreturnor spans awithboundary), 3not_identical(literal-value differences). Six gate-failed groups (#131, #286, #658, #751, #807, #950) were reverted and remain unre-extracted.Notes
library/kernels/andplatform/python/rocke/).ml_dtypesmodule-not-found failures are pre-existing environment gaps, unchanged.