[hipBLASLt] Integrate tensilelite client into next-cmake#650
Merged
ibrahimw1 merged 3 commits intoJul 15, 2025
Conversation
bstefanuk
reviewed
Jul 15, 2025
davidd-amd
approved these changes
Jul 15, 2025
assistant-librarian Bot
pushed a commit
to ROCm/hipBLASLt
that referenced
this pull request
Jul 15, 2025
[hipBLASLt] Integrate tensilelite client into next-cmake (#650) - Integrates the tensilelite client build process into `next-cmake`. - Separates the `tensilelite-host` code from the `hipblaslt` target, so that tensilelite can build independent of hipBLASLt.
Contributor
|
This patch has an issue in it that is causing downstream failures in software built with a host compiler (gcc, etc) such as pytorch. The root cause is that this is illegal: This is advertising a dependency on I think that we need to revert. |
This was referenced Jul 25, 2025
davidd-amd
added a commit
that referenced
this pull request
Jul 26, 2025
- Do note use PUBLIC linkage for hip::device - Add logic to project config to catch when hip::device is added to interface link libraries - Fixes the regression noted in #650 (comment) - Root cause diagnosis of the issue: https://chatgpt.com/share/68841788-4564-800d-a6a1-e000c668c0fb
assistant-librarian Bot
pushed a commit
to ROCm/hipBLASLt
that referenced
this pull request
Jul 26, 2025
[hipblsalt] Fix leaky hip::device dependency - Do note use PUBLIC linkage for hip::device - Add logic to project config to catch when hip::device is added to interface link libraries - Fixes the regression noted in ROCm/rocm-libraries#650 (comment) - Root cause diagnosis of the issue: https://chatgpt.com/share/68841788-4564-800d-a6a1-e000c668c0fb
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
next-cmake.tensilelite-hostcode from thehipblaslttarget, so that tensilelite can build independent of hipBLASLt.