Skip to content

[hipBLASLt] Integrate tensilelite client into next-cmake#650

Merged
ibrahimw1 merged 3 commits into
developfrom
users/ibrahimw1/hipblaslt-enable-tensilelite-client
Jul 15, 2025
Merged

[hipBLASLt] Integrate tensilelite client into next-cmake#650
ibrahimw1 merged 3 commits into
developfrom
users/ibrahimw1/hipblaslt-enable-tensilelite-client

Conversation

@ibrahimw1
Copy link
Copy Markdown
Contributor

@ibrahimw1 ibrahimw1 commented Jul 14, 2025

  • Integrates the tensilelite client build process into next-cmake.
  • Separates the tensilelite-host code from the hipblaslt target, so that tensilelite can build independent of hipBLASLt.

@ibrahimw1 ibrahimw1 changed the title Integrate tensilelite client into next-cmake. Integrate tensilelite client into next-cmake Jul 14, 2025
@ibrahimw1 ibrahimw1 added the NoCI Don't run CI label Jul 14, 2025
@ibrahimw1 ibrahimw1 changed the title Integrate tensilelite client into next-cmake [hipBLASLt] Integrate tensilelite client into next-cmake Jul 14, 2025
@KKyang KKyang removed the NoCI Don't run CI label Jul 15, 2025
Comment thread projects/hipblaslt/next-cmake/tensilelite-client/CMakeLists.txt
@ibrahimw1 ibrahimw1 merged commit 2ed66d1 into develop Jul 15, 2025
15 checks passed
@ibrahimw1 ibrahimw1 deleted the users/ibrahimw1/hipblaslt-enable-tensilelite-client branch July 15, 2025 15:57
assistant-librarian Bot pushed a commit to ROCm/hipBLASLt that referenced this pull request Jul 15, 2025
[hipBLASLt] Integrate tensilelite client into next-cmake (#650)

- Integrates the tensilelite client build process into `next-cmake`.
- Separates the `tensilelite-host` code from the `hipblaslt` target, so
that tensilelite can build independent of hipBLASLt.
@stellaraccident
Copy link
Copy Markdown
Contributor

stellaraccident commented Jul 25, 2025

This patch has an issue in it that is causing downstream failures in software built with a host compiler (gcc, etc) such as pytorch. The root cause is that this is illegal:

    target_link_libraries(tensilelite-host 
        PUBLIC
            rocisa::rocisa-cpp
            hip::device
    )

This is advertising a dependency on hip::device to all users of the host libraries, resulting in it ultimately being advertised on anyone who depends on hipblaslt. This causes device compiler flags (such as -x hip and --offload-arch to be used in pure host compilations).

I think that we need to revert.

davidd-amd added a commit that referenced this pull request Jul 26, 2025
- Do note use PUBLIC linkage for hip::device
- Add logic to project config to catch when hip::device is added to
interface link libraries
- Fixes the regression noted in
#650 (comment)
- Root cause diagnosis of the issue:
https://chatgpt.com/share/68841788-4564-800d-a6a1-e000c668c0fb
assistant-librarian Bot pushed a commit to ROCm/hipBLASLt that referenced this pull request Jul 26, 2025
[hipblsalt] Fix leaky hip::device dependency

- Do note use PUBLIC linkage for hip::device
- Add logic to project config to catch when hip::device is added to
interface link libraries
- Fixes the regression noted in
ROCm/rocm-libraries#650 (comment)
- Root cause diagnosis of the issue:
https://chatgpt.com/share/68841788-4564-800d-a6a1-e000c668c0fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants