[Ex CI] nonpolling dispatch action and summary check#607
Merged
Conversation
jayhawk-commits
requested changes
Jul 11, 2025
Collaborator
jayhawk-commits
left a comment
jayhawk-commits
left a comment
There was a problem hiding this comment.
Summary looks great and has additional documentation to guide developers. This is a great first step.
Primary concern is the infinite loop, and then potential with code-reuse for the stage sequence. There is potential in doing some refactor in the recurring theme of bash code blocks running curl requests, but that can be a future improvement.
danielsu-amd
force-pushed
the
users/danielsu/az-dispatch-nonpolling
branch
from
7a4f3ce to
372791d
Compare
bstefanuk
pushed a commit
that referenced
this pull request
Jul 11, 2025
Contributor
Author
|
Created a new PR to test the stage template and loop limit: #610 |
danielsu-amd
added a commit
that referenced
this pull request
Jul 11, 2025
danielsu-amd
added a commit
that referenced
this pull request
Jul 11, 2025
Progress for #479 Reworks the Azure dispatch action to be nonpolling, which resolves the 360 minute timeout issue. It now creates a separate `Azure CI Summary` check, which will be updated inside Azure pipeline runs via the `report-summary-check.yml` template. This summary check is intended to be marked as required. Once an Azure pipelines run finishes, it will report its overall status to the summary. If any jobs have failed or are cancelled, the summary check will be marked as failed. If all jobs have succeeded, the summary will pass. Adds logic for handling rerunning the initial dispatch action, which will either start new runs or rerun existing runs depending on the state of the PR. Instructions for doing so are included directly in the summary checks for easy access. Overview of flow: 1. PR is created, `Trigger Azure CI` action is run on PR 2. `Trigger Azure CI` kicks off Azure runs and creates an `Azure CI Summary` check 3. As Azure runs finish, `Azure CI Summary` is updated with their statuses 4. After all runs are finished, `Azure CI Summary` will be marked as successful or failed depending on the runs' statuses 5. If a rerun is desired, `Trigger Azure CI` can be rerun, which will overwrite the existing `Azure CI Summary` with a new one Sample runs: Branch PR: #561 - [summary](https://github.com/ROCm/rocm-libraries/pull/561/checks?check_run_id=45813198366) Fork PR: #600 - [summary](https://github.com/ROCm/rocm-libraries/pull/600/checks?check_run_id=45815418773) Other stuff: - Copied the Github CLI fallback logic from `pr_category_label.py` to `pr_detect_changed_subtrees.py` - To fix dispatch action not running on PRs with infinite diffs - Removed `paths-ignore` from dispatch action
danielsu-amd
added a commit
that referenced
this pull request
Jul 11, 2025
danielsu-amd
added a commit
that referenced
this pull request
Jul 11, 2025
ammallya
pushed a commit
that referenced
this pull request
Jul 22, 2025
[ROCm/hipSPARSE commit: 39b2356]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress for #479
Reworks the Azure dispatch action to be nonpolling, which resolves the 360 minute timeout issue. It now creates a separate
Azure CI Summarycheck, which will be updated inside Azure pipeline runs via thereport-summary-check.ymltemplate. This summary check is intended to be marked as required.Once an Azure pipelines run finishes, it will report its overall status to the summary. If any jobs have failed or are cancelled, the summary check will be marked as failed. If all jobs have succeeded, the summary will pass.
Adds logic for handling rerunning the initial dispatch action, which will either start new runs or rerun existing runs depending on the state of the PR. Instructions for doing so are included directly in the summary checks for easy access.
Overview of flow:
Trigger Azure CIaction is run on PRTrigger Azure CIkicks off Azure runs and creates anAzure CI SummarycheckAzure CI Summaryis updated with their statusesAzure CI Summarywill be marked as successful or failed depending on the runs' statusesTrigger Azure CIcan be rerun, which will overwrite the existingAzure CI Summarywith a new oneSample runs:
Branch PR: #561 - summary
Fork PR: #600 - summary
Other stuff:
pr_category_label.pytopr_detect_changed_subtrees.pypaths-ignorefrom dispatch action