[FusilliPlugin] Lift and shift `fusilli-plugin`: `shark-ai` -> `rocm-libraries` by AaronStGeorge · Pull Request #2252 · ROCm/rocm-libraries

AaronStGeorge · 2025-10-23T21:09:40Z

Motivation

This is a direct "lift and shift" of the hipDnn plugin for fusilli (also known as fusilli-plugin) + git history originally developed in shark-ai.

The (current) plan is to move fusilli-plugin in a few stages:

PR 1 (this PR) Directly move code from nod-ai/shark-ai without any edits. At this point the plugin will not build and not be running in rocm-libraries CI (it also won't be running in TheRock CI).
PR 2 Follow up with changes need update paths, enable CI, change how we fetch fusilli dependency + hipDnn dependencies, etc. At this point fusilli-plugin should build and run in rocm-libraries CI. Note: TheRock CI will still not be enabled.
PR 3 Remove fusilli-plugin from shark-ai.
PR 4/N Enable building fusilli plugin optionally in TheRock (see RFC0004-Fusilli-IREE-Kernel-Provider-hipDNN.md) and enable TheRock CI
PR N+1 disable CI added in PR 2 as things will now be tested through TheRock CI.

Technical Details

Direct lift and shift using git subtree all code has been previously reviewed in shark-ai.

Test Plan

Tests of all functionally should be current, however initially CI will not test fusilli-plugin. CI will come in follow up PR.

Test Result

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

jayhawk-commits · 2025-10-23T22:05:32Z

Added project: none label to skip Math CI check. Notifying @eidenyoshida for awareness.

jayhawk-commits · 2025-10-23T22:07:25Z

@amd-jnovotny Note that the docs team was pinged because of the *.md file included in this "lift and shift".

sjain-stanford

LGTM. The main thing is between this PR and PR 3/N (when fusilli-plugin is removed from shark-ai), how do you manage contributions to the codebase - freeze the shark-ai mirror, or cherry-pick in both?

AaronStGeorge · 2025-10-23T23:12:46Z

I was thinking cherry-pick in both. I don't like it, but hopefully we don't have to spend a lot of time with the sate in superposition.

amd-jnovotny

I'll approve to unblock this. We'll want to clean up the readme when it's ready for general release.

amd-jnovotny · 2025-10-23T23:23:36Z

@jayhawk-commits sound good. I approved to unblock it. We'll worry about fixing up the read me later.

…ROCm#2275) Adds basic CI, CMake build scrips, and Readme.

This PR adds a convenience feature for development. When switching between `hipDNN` code and `fusilli-plugin` code it's nice to have one location for sources.

This PR adds "all the boring bits" of the fusilli plugin. It adds a basic engine plugin that hipDNN can load, which ensures that all of the required API definitions are present, and those APIs called as part of load function. The PR also tests for plugin loading, logging, and basic functionality.

This PR implements [`hipdnnEnginePluginGetApplicableEngineIds`](https://github.com/ROCm/rocm-libraries/blob/7e29d65a8db488a5e038c3616398144d7c2289a5/projects/hipdnn/sdk/include/hipdnn_sdk/plugin/EnginePluginApi.h#L90-L115) and [`hipdnnEnginePluginCreateExecutionContext`](https://github.com/ROCm/rocm-libraries/blob/7e29d65a8db488a5e038c3616398144d7c2289a5/projects/hipdnn/sdk/include/hipdnn_sdk/plugin/EnginePluginApi.h#L170-L191), which together completes `hipDNN` -> `fusilli` graph translation for the initial plugin goal of e2e run of single node ConvFprop graph.

This PR implements `hipdnnEnginePluginExecuteOpGraph` enabling graph/plan execution. We can now complete the initial plugin goal of e2e run of single node ConvFprop graph. Note: a simple e2e integration test is added. This should be expanded to a parameterized matrix of test, once we're on the latest hipDNN [example](https://github.com/ROCm/rocm-libraries/blob/develop/projects/hipdnn/plugins/miopen_legacy_plugin/integration_tests/IntegrationGpuConvForward.cpp). Tickets: [ROCm#2363](nod-ai/amd-shark-ai#2363), [ROCm#2375](nod-ai/amd-shark-ai#2375).

Update build to pull hipdnn from `rocm-libraries` and update clang to version 20 from TheRock. Co-authored-by: Sambhav Jain <sambhav.jain@amd.com>

…ld. (ROCm#2449) This PR fixes `fusilli-plugin` build failure when fusilli benchmarking (`FUSILLI_BUILD_BENCHMARKS`) was enabled, but fusilli testing (`FUSILLI_BUILD_TESTS`) was disabled: [link to CI failure](https://github.com/nod-ai/shark-ai/actions/runs/18206945208/job/51839515287?pr=2410). Both _should_ be disabled, but ideally the build wouldn't break if one wasn't. The issue was: both fusilli tests and fusilli benchmarks depend on `libutils`, but the target was only defined if tests were enabled.

…_agent_enumerator (ROCm#2488) Got this building on my SharkWorkstation with an RX 9070XT (RDNA4) targeting the `gfx1201` arch with minimal changes. The `Backend` enum doesn't need to be specific to the arch, and the iree-compile flag `--iree-hip-target` can just be derived using `rocm_agent_enumerator` (which lists the gfx arch from the GPUs visible) based on https://iree.dev/guides/deployment-configurations/gpu-rocm/#choosing-hip-targets.

… monorepo. (ROCm#2521) Signed-off-by: MaheshRavishankar <mravisha@amd.com>

Add Fusilli+IREE as a kernel provider and JIT engine for hipDNN

Official RFC is here: https://github.com/ROCm/TheRock/blob/main/docs/rfcs/RFC0004-Fusilli-IREE-Kernel-Provider-hipDNN.md

When building `hipDNN` from source it handles downloading and configuring transitive dependencies, while an installed version requires the consuming package to provide needed dependencies. In the plugin's current form, the former is more convenient.

…nv3d (ROCm#2560) Compiler fix: iree-org/iree#22320 Issue: iree-org/iree#22312

Adds support for async execution and explicit device/stream selection and updates fusilli plugin to use new API: - Handle creation supports device id and external HIP stream parameters. - Graph execution is async on AMDGPU backend. - Fusilli plugin now uses stream if set by user.

Co-authored-by: Jim <jimguo12@amd.com> [ROCm/composable_kernel commit: 57f4974]

AaronStGeorge changed the title ~~Fusilli plugin to the rock 1 of n~~ [FusilliPlugin] Lift and shift fusilli-plugin shark-ai -> rocm-libraries Oct 23, 2025

AaronStGeorge changed the title ~~[FusilliPlugin] Lift and shift fusilli-plugin shark-ai -> rocm-libraries~~ [FusilliPlugin] Lift and shift fusilli-plugin: shark-ai -> rocm-libraries Oct 23, 2025

AaronStGeorge marked this pull request as ready for review October 23, 2025 21:24

AaronStGeorge requested a review from a team as a code owner October 23, 2025 21:24

assistant-librarian Bot added the organization: ROCm label Oct 23, 2025

jayhawk-commits added the project: none Does not target any component label Oct 23, 2025

sjain-stanford approved these changes Oct 23, 2025

View reviewed changes

amd-jnovotny approved these changes Oct 23, 2025

View reviewed changes

AaronStGeorge and others added 14 commits October 24, 2025 15:58

[FusilliPlugin] Basic CI, Build, and README (fusilli-plugin 1 of N) (…

4ff5df6

…ROCm#2275) Adds basic CI, CMake build scrips, and Readme.

[FusilliPlugin] Add local build option for hipDNN (ROCm#2295)

ce616f0

This PR adds a convenience feature for development. When switching between `hipDNN` code and `fusilli-plugin` code it's nice to have one location for sources.

[Fusilli,FusilliPlugin] Update hipdnn and clang version (ROCm#2405)

8b485a4

Update build to pull hipdnn from `rocm-libraries` and update clang to version 20 from TheRock. Co-authored-by: Sambhav Jain <sambhav.jain@amd.com>

Initial draft/placeholder for RFC to move Fusilli-plugin into TheRock…

a830fbf

… monorepo. (ROCm#2521) Signed-off-by: MaheshRavishankar <mravisha@amd.com>

[FusilliPlugin] TheRock RFC revisions (ROCm#2546)

d7cb049

Add Fusilli+IREE as a kernel provider and JIT engine for hipDNN

[FusilliPlugin] Cleanup draft RFC (ROCm#2558)

6b6e69f

Official RFC is here: https://github.com/ROCm/TheRock/blob/main/docs/rfcs/RFC0004-Fusilli-IREE-Kernel-Provider-hipDNN.md

[Fusilli] Pick compiler fixes and change dispatch count checks for co…

55b156d

…nv3d (ROCm#2560) Compiler fix: iree-org/iree#22320 Issue: iree-org/iree#22312

AaronStGeorge force-pushed the fusilli-plugin-to-the-rock-1-of-n branch from 618b1c3 to 05f8da9 Compare October 24, 2025 16:22

AaronStGeorge merged commit 1a50a48 into ROCm:develop Oct 24, 2025
9 checks passed

AaronStGeorge mentioned this pull request Oct 25, 2025

[FusilliPlugin] Re-Enable build and CI and add CODEOWNERS etc. #2269

Closed

1 task

AaronStGeorge mentioned this pull request Mar 9, 2026

[fusilli-provider] Add fusilli-provider to dnn-providers #5149

Merged

1 task

AaronStGeorge added project: fusilli-provider and removed project: fusilli-provider labels Mar 11, 2026

qiangpan2 pushed a commit to qiangpan2/rocm-libraries that referenced this pull request May 29, 2026

remove restriction of group mode hd192 no lse (ROCm#2252)

a2d09fd

Co-authored-by: Jim <jimguo12@amd.com> [ROCm/composable_kernel commit: 57f4974]

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FusilliPlugin] Lift and shift `fusilli-plugin`: `shark-ai` -> `rocm-libraries`#2252

[FusilliPlugin] Lift and shift `fusilli-plugin`: `shark-ai` -> `rocm-libraries`#2252
AaronStGeorge merged 14 commits into
ROCm:developfrom
AaronStGeorge:fusilli-plugin-to-the-rock-1-of-n

AaronStGeorge commented Oct 23, 2025 •

edited

Loading

Uh oh!

jayhawk-commits commented Oct 23, 2025

Uh oh!

jayhawk-commits commented Oct 23, 2025

Uh oh!

sjain-stanford left a comment

Uh oh!

AaronStGeorge commented Oct 23, 2025

Uh oh!

amd-jnovotny left a comment

Uh oh!

amd-jnovotny commented Oct 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

AaronStGeorge commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Uh oh!

jayhawk-commits commented Oct 23, 2025

Uh oh!

jayhawk-commits commented Oct 23, 2025

Uh oh!

sjain-stanford left a comment

Choose a reason for hiding this comment

Uh oh!

AaronStGeorge commented Oct 23, 2025

Uh oh!

amd-jnovotny left a comment

Choose a reason for hiding this comment

Uh oh!

amd-jnovotny commented Oct 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AaronStGeorge commented Oct 23, 2025 •

edited

Loading