[rocPRIM][hipCUB] Add minimum version in find_package call for Google Benchmark#2405
Merged
Merged
Conversation
In the rocPRIM and hipCUB cmake dependencies files, no minimum Google Benchmark version is specified in the call to find_package. This can cause CMake to grab an incompatible version of the library, causing the build to fail. This change adds a minimum version. I've set it to the version that's downloaded when the library isn't present.
umfranzw
changed the title
stanleytsang-amd
approved these changes
Oct 31, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2405 +/- ##
============================================
+ Coverage 67.19% 81.83% +14.64%
============================================
Files 362 42 -320
Lines 50705 2609 -48096
Branches 5708 96 -5612
============================================
- Hits 34069 2135 -31934
+ Misses 13052 421 -12631
+ Partials 3584 53 -3531
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
NolanHannaAMD
pushed a commit
that referenced
this pull request
Nov 3, 2025
Update build to pull hipdnn from `rocm-libraries` and update clang to version 20 from TheRock. Co-authored-by: Sambhav Jain <sambhav.jain@amd.com>
assistant-librarian Bot
pushed a commit
to ROCm/hipCUB
that referenced
this pull request
Nov 7, 2025
[rocPRIM][hipCUB] Add minimum version in find_package call for Google Benchmark (#2405) ## Motivation In the rocPRIM and hipCUB cmake dependencies files, no minimum Google Benchmark version is specified in the call to find_package. This can cause CMake to grab an incompatible version of the library, causing the build to fail. rocThrust and rocRAND already do this. ## Technical Details This change adds a minimum version. I've set it to the version that's downloaded when the library isn't present. ## Test Plan Install Google Benchmark < 1.8.0 from the github repo here: https://github.com/google/benchmark. Build rocPRIM and hipCUB with -DBENCHMARK=ON. Verify that there are no build errors. ## Test Result No build errors observed. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
assistant-librarian Bot
pushed a commit
to ROCm/rocPRIM
that referenced
this pull request
Nov 7, 2025
[rocPRIM][hipCUB] Add minimum version in find_package call for Google Benchmark (#2405) ## Motivation In the rocPRIM and hipCUB cmake dependencies files, no minimum Google Benchmark version is specified in the call to find_package. This can cause CMake to grab an incompatible version of the library, causing the build to fail. rocThrust and rocRAND already do this. ## Technical Details This change adds a minimum version. I've set it to the version that's downloaded when the library isn't present. ## Test Plan Install Google Benchmark < 1.8.0 from the github repo here: https://github.com/google/benchmark. Build rocPRIM and hipCUB with -DBENCHMARK=ON. Verify that there are no build errors. ## Test Result No build errors observed. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
ammallya
pushed a commit
that referenced
this pull request
Feb 3, 2026
* add prefetching physical block id for pagedkv * start add pagedkv prefill * rename pipeline * add kernel for pagedkv * add an init version pagedkv prefill * fix redefine issue * add struct BlockFmhaFwdPagedKVPipelineProblem and fmha_fwd_pagedkv_args * generate dispatch code * add body generating code * comipling pass * remove dropout from pagedkv * set lse to false in generating code * start changing qr kernel to pagedkv * init version of kernerl with pagedkv * change names of file that are generated * chang host validation for pagedkv prefill * using iglp to change blockgemm * add kernel files to op head file * show parameters * rewrite print parameter fun * add fwd * remove default parameter of GridSize * format * fix nhead issue and add seqlen_k_ptr to batch mode * format code * remove no-longer used code * format * fix some comments --------- Co-authored-by: ltqin <letaoqin@amd.com> Co-authored-by: Po Yen Chen <PoYen.Chen@amd.com> [ROCm/composable_kernel commit: 9f4c5d7]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In the rocPRIM and hipCUB cmake dependencies files, no minimum Google Benchmark version is specified in the call to find_package. This can cause CMake to grab an incompatible version of the library, causing the build to fail.
rocThrust and rocRAND already do this.
Technical Details
This change adds a minimum version. I've set it to the version that's downloaded when the library isn't present.
Test Plan
Install Google Benchmark < 1.8.0 from the github repo here: https://github.com/google/benchmark.
Build rocPRIM and hipCUB with -DBENCHMARK=ON.
Verify that there are no build errors.
Test Result
No build errors observed.
Submission Checklist