Skip to content

[rocBLAS] remove double iteration for xml reduction#2488

Merged
TorreZuk merged 1 commit into
developfrom
users/torrezuk/fix-test-output-reduce
Nov 6, 2025
Merged

[rocBLAS] remove double iteration for xml reduction#2488
TorreZuk merged 1 commit into
developfrom
users/torrezuk/fix-test-output-reduce

Conversation

@TorreZuk
Copy link
Copy Markdown
Contributor

@TorreZuk TorreZuk commented Nov 5, 2025

  • fixes glitch in file reduction

@TorreZuk TorreZuk requested a review from a team as a code owner November 5, 2025 21:23
@TorreZuk TorreZuk added noTensile Run PR without Tensile TestLevel1Only Tests only Level 1 functions in this PR labels Nov 5, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

❗ There is a different number of reports uploaded between BASE (05453dd) and HEAD (037303d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (05453dd) HEAD (037303d)
hipCUB 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2488       +/-   ##
============================================
- Coverage    81.83%   67.19%   -14.64%     
============================================
  Files           42      362      +320     
  Lines         2609    50789    +48180     
  Branches        96     5741     +5645     
============================================
+ Hits          2135    34126    +31991     
- Misses         421    13057    +12636     
- Partials        53     3606     +3553     
Flag Coverage Δ
hipCUB ?
rocBLAS 67.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 404 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TorreZuk
Copy link
Copy Markdown
Contributor Author

TorreZuk commented Nov 6, 2025

Thanks @amcamd it says out of date but that shouldn't block so assume it is the hipblaslt unrelated failures. I'll re-run those

@TorreZuk TorreZuk merged commit 7af2f5c into develop Nov 6, 2025
48 of 50 checks passed
@TorreZuk TorreZuk deleted the users/torrezuk/fix-test-output-reduce branch November 6, 2025 16:14
assistant-librarian Bot pushed a commit to ROCm/rocBLAS that referenced this pull request Nov 6, 2025
[rocBLAS] remove double iteration for xml reduction

* fixes glitch in google test xml output file size reduction being slow
kliegeois pushed a commit to kliegeois/rocm-libraries that referenced this pull request Nov 6, 2025
…_agent_enumerator (ROCm#2488)

Got this building on my SharkWorkstation with an RX 9070XT (RDNA4)
targeting the `gfx1201` arch with minimal changes. The `Backend` enum
doesn't need to be specific to the arch, and the iree-compile flag
`--iree-hip-target` can just be derived using `rocm_agent_enumerator`
(which lists the gfx arch from the GPUs visible) based on
https://iree.dev/guides/deployment-configurations/gpu-rocm/#choosing-hip-targets.
ammallya pushed a commit that referenced this pull request Feb 3, 2026
* Add F6 GEMM MX Test

* Add BF6 GEMM MX Test

[ROCm/composable_kernel commit: 25b359d]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

noTensile Run PR without Tensile organization: ROCm project: rocblas TestLevel1Only Tests only Level 1 functions in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants