Skip to content

[fusilli-provider] Add fusilli-provider to dnn-providers#5149

Merged
AaronStGeorge merged 4 commits into
ROCm:developfrom
AaronStGeorge:p036-move-fusilli-plugin-to-rocm-libs
Mar 11, 2026
Merged

[fusilli-provider] Add fusilli-provider to dnn-providers#5149
AaronStGeorge merged 4 commits into
ROCm:developfrom
AaronStGeorge:p036-move-fusilli-plugin-to-rocm-libs

Conversation

@AaronStGeorge
Copy link
Copy Markdown
Contributor

@AaronStGeorge AaronStGeorge commented Mar 5, 2026 •
edited
Loading

Motivation

Copy the fusilli hipDNN plugin from iree-org/fusilli to rocm-libraries/dnn-providers so it lives alongside the other hipDNN providers (miopen-provider, hipblaslt-provider).

Technical Details

ThePebble.py is removed as it's no longer necessary, but other than that there are no other code changes, this is a copy paste.

Test Plan

Take a look at the associated PR in TheRock to see working CI: link to pr, link to successful run of fusilli provider tests.

Test Result

Submission Checklist

AaronStGeorge and others added 2 commits March 4, 2026 21:10
@AaronStGeorge @claude
Add fusilli-provider to dnn-providers
b53a22d 
Copy the fusilli hipDNN plugin from iree-libs/fusilli/plugins/hipdnn-plugin/
to rocm-libraries/dnn-providers/fusilli-provider/ so it lives alongside the
other hipDNN providers (miopen-provider, hipblaslt-provider).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@AaronStGeorge @claude
Remove obsolete ThePebble dev environment scripts
01550af 
ThePebble was a standalone dev/CI setup tool for when the plugin lived
inside the fusilli repo. Now that the plugin is built through TheRock,
these files serve no purpose and contain stale relative path assumptions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@AaronStGeorge AaronStGeorge requested a review from a team as a code owner March 5, 2026 18:08
@AaronStGeorge AaronStGeorge mentioned this pull request Mar 5, 2026
Merged
1 task
@AaronStGeorge
Copy link
Copy Markdown
Contributor Author

AaronStGeorge commented Mar 9, 2026

@jayhawk-commits would you mind taking a look at this? We temporarily moved fusilli plugin into rocm-libraries before #2252, but unlike the previous move, now fusilli plugin is fully baked into TheRock. See discussion here for details on why we're moving it back.

sjain-stanford
sjain-stanford approved these changes Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@sjain-stanford sjain-stanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the move. We'll need someone from ROCm docs to approve as well - @jayhawk-commits could you stamp?

jayhawk-commits
jayhawk-commits approved these changes Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jayhawk-commits jayhawk-commits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyrights all have 2025. The guidance I have from legal is that the inclusion of the year is no longer standard practice. The 2025 mentions can be removed.

See this example: https://github.com/ROCm/TheRock/blob/main/dctools/CMakeLists.txt

I will approve regardless.

@AaronStGeorge AaronStGeorge enabled auto-merge (squash) March 10, 2026 20:21
@AaronStGeorge
Copy link
Copy Markdown
Contributor Author

AaronStGeorge commented Mar 10, 2026

@amd-jnovotny Would you mind taking a look at this. The docs team was pinged because of the *.md file. This is a direct drop from an existing codebase without any modifications.

amd-jnovotny
amd-jnovotny approved these changes Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@amd-jnovotny amd-jnovotny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've added two minor suggestions.

Comment thread dnn-providers/fusilli-provider/README.md Outdated
Comment thread dnn-providers/fusilli-provider/README.md Outdated
@AaronStGeorge AaronStGeorge disabled auto-merge March 10, 2026 21:11
@AaronStGeorge AaronStGeorge enabled auto-merge (squash) March 10, 2026 22:05
@AaronStGeorge AaronStGeorge added the project: none Does not target any component label Mar 11, 2026
@AaronStGeorge AaronStGeorge merged commit 36497b5 into ROCm:develop Mar 11, 2026
7 checks passed
kokolchin pushed a commit to kokolchin/rocm-libraries that referenced this pull request Mar 11, 2026
@AaronStGeorge @claude
[fusilli-provider] Add fusilli-provider to dnn-providers (ROCm#5149)
8289463 
## Motivation

<!-- Explain the purpose of this PR and the goals it aims to achieve.
-->

Copy the fusilli hipDNN plugin from
[`iree-org/fusilli`](https://github.com/iree-org/fusilli/tree/369d94a246440e183ae1ad185db36e6c8dd36cbb/plugins/hipdnn-plugin)
to `rocm-libraries/dnn-providers` so it lives alongside the other hipDNN
providers (`miopen-provider`, `hipblaslt-provider`).

## Technical Details

<!-- Explain the changes along with any relevant GitHub links. -->


[`ThePebble.py`](https://github.com/iree-org/fusilli/blob/369d94a246440e183ae1ad185db36e6c8dd36cbb/plugins/hipdnn-plugin/build_tools/ThePebble.py)
is removed as it's no longer necessary, but other than that there are no
other code changes, this is a copy paste.

## Test Plan

<!-- Explain any relevant testing done to verify this PR. -->

Take a look at the associated PR in TheRock to see working CI: [link to
pr](ROCm/TheRock#3791), [link to successful run
of fusilli provider
tests](https://github.com/ROCm/TheRock/actions/runs/22736501150/job/65959962519?pr=3791).

## Test Result

<!-- Briefly summarize test outcomes. -->

## Submission Checklist

- [ ] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 11, 2026
Closed
Merged
@AaronStGeorge AaronStGeorge mentioned this pull request Mar 11, 2026
Closed
1 task
AaronStGeorge added a commit that referenced this pull request Mar 12, 2026
@AaronStGeorge @claude
[fusilli-provider] Add CODEOWNERS and PR label for fusilli-provider (…
30a4492 
…#5358)

## Motivation

<!-- Explain the purpose of this PR and the goals it aims to achieve.
-->

This PR adds CODEOWNERS and PR label for `fusilli-provider` that was
added in #5149

## Technical Details

<!-- Explain the changes along with any relevant GitHub links. -->

## Test Plan

<!-- Explain any relevant testing done to verify this PR. -->

## Test Result

<!-- Briefly summarize test outcomes. -->

## Submission Checklist

- [ ] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
AaronStGeorge added a commit to ROCm/TheRock that referenced this pull request Mar 12, 2026
@AaronStGeorge @claude
Use fusilli-provider defined in rocm-libraries (#3791)
ff39cb9 
## Motivation

<!-- Explain the purpose of this PR and the goals it aims to achieve.
-->

Update TheRock build for fusilli provider to pull from new location in
`rocm-libraries` (see: ROCm/rocm-libraries#5149)

## Technical Details

<!-- Explain the changes along with any relevant GitHub links. -->

Really just a couple boilerplate additions.

Note: as an optimization, we may want to add a feature to allow a sparse
checkout when fetching the `rocm-libraries` source set
([link](https://github.com/ROCm/TheRock/pull/3791/changes#diff-9c53c23f4ebfe2986e8dfe8af30208eb6a1a6294946bb07b8fd69f9e1b84d379R317)).
The `fusilli-libs` stage is only using a very small portion of that
repo.

## Test Plan

<!-- Explain any relevant testing done to verify this PR. -->

As the IREE / fusilli build are not enabled by default, see this test
branch with temporary changes required to enable the IREE / fusilli
build: #3912

## Test Result

<!-- Briefly summarize test outcomes. -->

It works! [successful build +
CI](https://github.com/ROCm/TheRock/actions/runs/22972523986/job/66726952506?pr=3912)

## Submission Checklist

- [ ] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
kamuruga08 pushed a commit that referenced this pull request Mar 18, 2026
@AaronStGeorge @claude @kamuruga08
[fusilli-provider] Add CODEOWNERS and PR label for fusilli-provider (…
eaf2441 
…#5358)

## Motivation

<!-- Explain the purpose of this PR and the goals it aims to achieve.
-->

This PR adds CODEOWNERS and PR label for `fusilli-provider` that was
added in #5149

## Technical Details

<!-- Explain the changes along with any relevant GitHub links. -->

## Test Plan

<!-- Explain any relevant testing done to verify this PR. -->

## Test Result

<!-- Briefly summarize test outcomes. -->

## Submission Checklist

- [ ] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
jovanau pushed a commit to jovanau/rocm-libraries that referenced this pull request Mar 19, 2026
@AaronStGeorge @claude @jovanau
[fusilli-provider] Add fusilli-provider to dnn-providers (ROCm#5149)
de0ef70 
## Motivation

<!-- Explain the purpose of this PR and the goals it aims to achieve.
-->

Copy the fusilli hipDNN plugin from
[`iree-org/fusilli`](https://github.com/iree-org/fusilli/tree/369d94a246440e183ae1ad185db36e6c8dd36cbb/plugins/hipdnn-plugin)
to `rocm-libraries/dnn-providers` so it lives alongside the other hipDNN
providers (`miopen-provider`, `hipblaslt-provider`).

## Technical Details

<!-- Explain the changes along with any relevant GitHub links. -->


[`ThePebble.py`](https://github.com/iree-org/fusilli/blob/369d94a246440e183ae1ad185db36e6c8dd36cbb/plugins/hipdnn-plugin/build_tools/ThePebble.py)
is removed as it's no longer necessary, but other than that there are no
other code changes, this is a copy paste.

## Test Plan

<!-- Explain any relevant testing done to verify this PR. -->

Take a look at the associated PR in TheRock to see working CI: [link to
pr](ROCm/TheRock#3791), [link to successful run
of fusilli provider
tests](https://github.com/ROCm/TheRock/actions/runs/22736501150/job/65959962519?pr=3791).

## Test Result

<!-- Briefly summarize test outcomes. -->

## Submission Checklist

- [ ] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
jovanau pushed a commit to jovanau/rocm-libraries that referenced this pull request Mar 19, 2026
@AaronStGeorge @claude @jovanau
[fusilli-provider] Add CODEOWNERS and PR label for fusilli-provider (…
c127534 
…ROCm#5358)

## Motivation

<!-- Explain the purpose of this PR and the goals it aims to achieve.
-->

This PR adds CODEOWNERS and PR label for `fusilli-provider` that was
added in ROCm#5149

## Technical Details

<!-- Explain the changes along with any relevant GitHub links. -->

## Test Plan

<!-- Explain any relevant testing done to verify this PR. -->

## Test Result

<!-- Briefly summarize test outcomes. -->

## Submission Checklist

- [ ] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjain-stanford sjain-stanford sjain-stanford approved these changes

@jayhawk-commits jayhawk-commits jayhawk-commits approved these changes

+1 more reviewer

@amd-jnovotny amd-jnovotny amd-jnovotny approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation organization: ROCm project: none Does not target any component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AaronStGeorge @sjain-stanford @jayhawk-commits @amd-jnovotny