Timestamp option for logging#2384
Merged
Merged
Conversation
Contributor
randyspauldingamd
left a comment
randyspauldingamd
left a comment
There was a problem hiding this comment.
Nice, this is something I've wanted to do myself for a very long time. I think the switch to ISO 8601 is pretty important; the others not as much.
Contributor
|
@cderb Should we add a unit test for this? |
reidkwja
reviewed
Oct 31, 2025
chuckwu20000
pushed a commit
to chuckwu20000/rocm-libraries
that referenced
this pull request
Oct 31, 2025
This PR implements `hipdnnEnginePluginExecuteOpGraph` enabling graph/plan execution. We can now complete the initial plugin goal of e2e run of single node ConvFprop graph. Note: a simple e2e integration test is added. This should be expanded to a parameterized matrix of test, once we're on the latest hipDNN [example](https://github.com/ROCm/rocm-libraries/blob/develop/projects/hipdnn/plugins/miopen_legacy_plugin/integration_tests/IntegrationGpuConvForward.cpp). Tickets: [ROCm#2363](nod-ai/amd-shark-ai#2363), [ROCm#2375](nod-ai/amd-shark-ai#2375).
Contributor
Author
I'm not inclined to at this point. |
JonathanLichtnerAMD
approved these changes
Nov 2, 2025
assistant-librarian Bot
pushed a commit
to ROCm/MIOpen
that referenced
this pull request
Nov 4, 2025
Timestamp option for logging ## Motivation Timestamp for log messages can help identify delays during execution. ## Technical Details Add method for fetching date time in milliseconds. Environment switch to activate in logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Timestamp for log messages can help identify delays during execution.
Technical Details
Add method for fetching date time in milliseconds.
Environment switch to activate in logging.