[hipblaslt] Use rocisa macro helpers for CMS#2275
Merged
Merged
Conversation
b-shi
force-pushed
the
users/brianshi/macrofix
branch
from
e538e99 to
18b8aa7
Compare
smalekta
pushed a commit
to smalekta/rocm-libraries
that referenced
this pull request
Oct 25, 2025
…ROCm#2275) Adds basic CI, CMake build scrips, and Readme.
babakpst
approved these changes
Oct 25, 2025
perfci run on commit 7a1b42d |
assistant-librarian Bot
pushed a commit
to ROCm/hipBLASLt
that referenced
this pull request
Oct 25, 2025
[hipblaslt] Use rocisa macro helpers for CMS ## Motivation When disabling asm comments all text blocks are stripped away. This causes issues with CMS kernels. This PR updates CMS kernels to use `Macro` and related helpers in rocISA instead of `TextBlock`. Changed `ValueIf` to take a string as an input instead of an integer. This lets us have more generic conditionals when using the `.if` directives. ## Technical Details ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
qiangpan2
pushed a commit
to qiangpan2/rocm-libraries
that referenced
this pull request
May 29, 2026
Adds V3 GEMM pipeline for MX FP4 and MX FP8 Adds V3 GEMM pipeline for MX FP4 with preshuffling Adds MXFP4 GEMM tests (ROCm#2275) Adds MXFP4 GEMM examples Adds MXFP4 GEMMs to ckProfiler Co-authored-by: Andriy Roshchenko <107577548+andriy-ca@users.noreply.github.com> Co-authored-by: Andriy Roshchenko <andriy.roshchenko@amd.com> Co-authored-by: aska-0096 <haocwang@amd.com> Co-authored-by: lalala-sh <Jiaxing.Wen@amd.com> Co-authored-by: OscarXu <huaiguxu@amd.com> Co-authored-by: mtgu0705 <mtgu@amd.com> Co-authored-by: Ding, Yi <yi.ding@amd.com> Co-authored-by: feifei14119 <feiw@amd.com> Co-authored-by: Lin, Qun <qlin@amd.com> Co-authored-by: joye <joye@amd.com> Co-authored-by: Rostyslav Geyyer <46627076+geyyer@users.noreply.github.com> [ROCm/composable_kernel commit: 00247e3]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When disabling asm comments all text blocks are stripped away. This causes issues with CMS kernels. This PR updates CMS kernels to use
Macroand related helpers in rocISA instead ofTextBlock.Changed
ValueIfto take a string as an input instead of an integer. This lets us have more generic conditionals when using the.ifdirectives.Technical Details
Test Plan
Test Result
Submission Checklist
ROCM-9819