Skip to content

refactor(api): change the names of liquid classes based transfers#18006

Merged
sanni-t merged 1 commit intochore_release-8.4.0from
refactor-change_lc_based_transfers_names
Apr 8, 2025
Merged

refactor(api): change the names of liquid classes based transfers#18006
sanni-t merged 1 commit intochore_release-8.4.0from
refactor-change_lc_based_transfers_names

Conversation

@sanni-t
Copy link
Copy Markdown
Member

@sanni-t sanni-t commented Apr 8, 2025

Overview

To reduce confusion with Liquid class and LiquidClass class and their respective usages, we have decided to rename all LC-based transfers to .._with_liquid_class.

Test Plan and Hands on Testing

None needed. Refactor only

Review requests

  • I guess look for any typos
  • We'll need to update the snapshot tests. Do we need to do that in this PR?

Risk assessment

None.

@sanni-t sanni-t requested a review from a team as a code owner April 8, 2025 15:45
@sanni-t sanni-t requested review from emilyburghardt, jbleon95 and y3rsh and removed request for a team April 8, 2025 15:45
Copy link
Copy Markdown
Contributor

@jbleon95 jbleon95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sanni-t sanni-t merged commit 39ad078 into chore_release-8.4.0 Apr 8, 2025
30 checks passed
@sanni-t sanni-t deleted the refactor-change_lc_based_transfers_names branch April 8, 2025 19:44
y3rsh added a commit that referenced this pull request Apr 9, 2025
…y-path

* chore_release-8.4.0: (30 commits)
  fix(api): make error message clearer for lld issues (#18005)
  chore(locize): sync for translations needed (#18009)
  chore(locize): sync translations (#18009)
  docs(api): API reference entries for liquid class methods (#17887)
  refactor(api): change the names of liquid classes based transfers (#18006)
  feat(app, labware-library): add evotip definition assets (#18007)
  fix(api, shared-data): Flex Stacker engine command optional fields (#17989)
  fix(shared-data): ethanol aspirate position reference (#17991)
  fix(app): Labware setup UI fixes (#17987)
  refactor(app): adjust protocol setup offsets table header (#17985)
  fix(app): do not show post run drop tip prompt if just handled in Error Recovery (#17981)
  fix(app): fix LPC disabled reasons not including fixture mismatch (#17979)
  refactor(app): adjust width on "calibrate now" button (#17978)
  fix(app): fix applying offsets implicitly when navigating on the desktop app (#17967)
  feat(robot-server): Populate `locationSequence` on old runs and make it faster to filter out deleted offsets (#17946)
  feat(app): add inline notification when setting default offsets with a 96ch (#17977)
  fix(app): ER tip selection crashes when trying to get labware def (#17975)
  feat(robot-server,system-server): Return server timing metrics in HTTP responses (#17970)
  fix(app): fix accumulating offsets on run record (#17969)
  fix(app): Fix local state issues when "resetting to default" in LPC (#17965)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants