fix(app): fix applying offsets implicitly when navigating on the desktop app

[mjhuff]

Closes RQA-4032

Overview

Woops, the clientData effect for applying offsets for apps that did not do LPC had some logic issues. It was possible to navigate back and forth on the desktop app quickly and cause offsets to automatically apply, because some of the state used in the effect hadn't had the chance to properly initialize.

To fix, let's not update the client store as an effect. Since only one user can actually click the apply offsets button, that user should do the client store update on the CTA itself. This simplies the effect a bit and everything works.

Current Behavior

Screen.Recording.2025-04-02.at.1.11.57.PM.mov

Fixed Behavior

Screen.Recording.2025-04-02.at.12.57.17.PM.mov

Test Plan and Hands on Testing

• See videos.
• Ran the exact test case in the ticket (same protocol, etc), and the issue no longer occurs.

Changelog

• Fixed offsets sometimes getting automatically applied on the desktop app when navigating back to a run.

Risk assessment

low

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 27.91%. Comparing base (7afe1f1) to head (f135104).
Report is 3 commits behind head on chore_release-8.4.0.

Files with missing lines	Patch %	Lines
...s/Desktop/Devices/ProtocolRun/ProtocolRunSetup.tsx	0.00%	2 Missing ⚠️
...ck/LPCFlows/hooks/useHandleClientAppliedOffsets.ts	0.00%	2 Missing ⚠️
...lSetup/ProtocolSetupOffsets/SetupOffsetsHeader.tsx	0.00%	2 Missing ⚠️

Additional details and impacted files

@@                   Coverage Diff                   @@
##           chore_release-8.4.0   #17967      +/-   ##
=======================================================
+ Coverage                27.65%   27.91%   +0.25%     
=======================================================
  Files                     3113     3113              
  Lines                   236796   236797       +1     
  Branches                 19220    19224       +4     
=======================================================
+ Hits                     65482    66095     +613     
+ Misses                  171296   170679     -617     
- Partials                    18       23       +5     

Flag	Coverage Δ
app	2.32% <0.00%> (+0.27%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...s/Desktop/Devices/ProtocolRun/ProtocolRunSetup.tsx	0.00% <0.00%> (ø)
...ck/LPCFlows/hooks/useHandleClientAppliedOffsets.ts	0.00% <0.00%> (ø)
...lSetup/ProtocolSetupOffsets/SetupOffsetsHeader.tsx	0.00% <0.00%> (ø)

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sfoster1]

Looks good to me!