Skip to content

refactor(app): adjust width on "calibrate now" button#17978

Merged
mjhuff merged 1 commit intochore_release-8.4.0from
app_adjust-calibrate-now-btn
Apr 3, 2025
Merged

refactor(app): adjust width on "calibrate now" button#17978
mjhuff merged 1 commit intochore_release-8.4.0from
app_adjust-calibrate-now-btn

Conversation

@mjhuff
Copy link
Copy Markdown
Contributor

@mjhuff mjhuff commented Apr 3, 2025

Closes RQA-4041

Overview

Design wants the text to hug the button like the other buttons in this list, so let's do that.

Current Behavior

Screenshot 2025-04-03 at 12 22 22 PM

Fixed Behavior

Screenshot 2025-04-03 at 12 18 30 PM

Test Plan and Hands on Testing

  • See images.

Changelog

  • Adjusted the width of the "calibrate now" button during protocol setup on the desktop app.

Risk assessment

none

@mjhuff mjhuff requested review from a team and sfoster1 April 3, 2025 16:25
@mjhuff mjhuff requested a review from a team as a code owner April 3, 2025 16:25
@mjhuff mjhuff requested review from TamarZanzouri and removed request for a team April 3, 2025 16:25
Copy link
Copy Markdown
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@mjhuff mjhuff merged commit 46fd2bd into chore_release-8.4.0 Apr 3, 2025
36 checks passed
@mjhuff mjhuff deleted the app_adjust-calibrate-now-btn branch April 3, 2025 19:56
y3rsh added a commit that referenced this pull request Apr 9, 2025
…y-path

* chore_release-8.4.0: (30 commits)
  fix(api): make error message clearer for lld issues (#18005)
  chore(locize): sync for translations needed (#18009)
  chore(locize): sync translations (#18009)
  docs(api): API reference entries for liquid class methods (#17887)
  refactor(api): change the names of liquid classes based transfers (#18006)
  feat(app, labware-library): add evotip definition assets (#18007)
  fix(api, shared-data): Flex Stacker engine command optional fields (#17989)
  fix(shared-data): ethanol aspirate position reference (#17991)
  fix(app): Labware setup UI fixes (#17987)
  refactor(app): adjust protocol setup offsets table header (#17985)
  fix(app): do not show post run drop tip prompt if just handled in Error Recovery (#17981)
  fix(app): fix LPC disabled reasons not including fixture mismatch (#17979)
  refactor(app): adjust width on "calibrate now" button (#17978)
  fix(app): fix applying offsets implicitly when navigating on the desktop app (#17967)
  feat(robot-server): Populate `locationSequence` on old runs and make it faster to filter out deleted offsets (#17946)
  feat(app): add inline notification when setting default offsets with a 96ch (#17977)
  fix(app): ER tip selection crashes when trying to get labware def (#17975)
  feat(robot-server,system-server): Return server timing metrics in HTTP responses (#17970)
  fix(app): fix accumulating offsets on run record (#17969)
  fix(app): Fix local state issues when "resetting to default" in LPC (#17965)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants