Skip to content

evidence(OMN-14060): bind infra venv drift guard - #3657

Merged
jonahgabriel merged 79 commits into
devfrom
jonah/omn-14060-occ-infra-venv-drift-guard
Jul 7, 2026
Merged

jonahgabriel merged 79 commits into
devfrom
jonah/omn-14060-occ-infra-venv-drift-guard

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jul 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Verification

  • uv run ruff check src/omnibase_infra/cli/omnimarket_drift_guard.py src/omnibase_infra/cli/cli_skill.py tests/unit/cli/ tests/scripts/
  • uv run mypy src/omnibase_infra/cli/omnimarket_drift_guard.py src/omnibase_infra/cli/cli_skill.py
  • uv run pre-commit run yamlfmt --files contracts/OMN-14060.yaml drift/dod_receipts/OMN-14060/dod-tests/command.yaml drift/dod_receipts/OMN-14060/dod-lint-typecheck-precommit/command.yaml drift/dod_receipts/OMN-14060/dod-omnibase-infra-pr-2223/command.yaml
  • uv run pre-commit run check-receipt-honesty --files drift/dod_receipts/OMN-14060/dod-tests/command.yaml drift/dod_receipts/OMN-14060/dod-lint-typecheck-precommit/command.yaml drift/dod_receipts/OMN-14060/dod-omnibase-infra-pr-2223/command.yaml
  • uv run pre-commit run validate-contract-yaml --files contracts/OMN-14060.yaml
  • uv run pre-commit run lint-contract-check-values --files contracts/OMN-14060.yaml
  • uv run pre-commit run dod-evidence-required --files contracts/OMN-14060.yaml

Evidence-Ticket: OMN-14060
Product-PR: OmniNode-ai/omnibase_infra#2223

Summary by CodeRabbit

  • Chores
    • Added a new contract and supporting validation records for an infrastructure drift-guard workflow.
    • Documented successful checks for lint/type, test, deploy-gate, and contract-validation steps.
    • Recorded evidence that no live deployment is required and that related PR checks passed.

jonahgabriel and others added 30 commits May 25, 2026 06:09
* contracts(OMN-11828,OMN-11972): add self agent PR evidence

* fix(OMN-11828): bind OCC evidence PR
* contracts(OMN-11994): add infra handler wiring evidence

* fix(OMN-11994): bind OCC evidence PR
* contracts(OMN-12006): add omnimarket overlay evidence

* contracts(OMN-12006): format overlay evidence receipts

* contracts(OMN-12006): include swarm runs migration in inventory
* contracts(OMN-12116): add dispatch result applier evidence

* contracts(OMN-12116): add OCC PR self receipt
* contracts(OMN-11969): bind compat PR receipt

* contracts(OMN-11969): add OCC self receipt for compat repair
* contracts(OMN-12006): bind omnimarket fleet rewrite receipt

* contracts(OMN-12006): add OCC self receipt for fleet rewrite
* contracts(OMN-12116): bind verified hot-patch deploy receipt

Replace placeholder echo command in dod-deploy-assessment with the
actual docker exec smoke test verified on stability-test containers at
2026-05-25T18:53:00Z. Smoke confirms _derive_event_type_from_topic
returns 'omnimarket.swarm-dispatch-completed' on the hot-patched
runtime (run_id=8d68c8e7).

* chore: trigger rebase check

* contracts(OMN-12116): add dod-occ-pr-1627 receipt to bind PR 1627

Add receipt dod-occ-pr-1627 referencing PR #1627 so the receipt gate
can bind this OCC PR to the OMN-12116 ticket. Also update the contract
dod-deploy-assessment entry to reference the actual receipt file
(replacing the placeholder echo command from PR #1618) and add the
dod-occ-pr-1627 evidence item to the contract dod_evidence list.

* contracts(OMN-12116): update all receipts to new contract hash

After adding dod-occ-pr-1627 evidence item to the contract YAML,
the contract hash changed. Update contract_sha256 in all four receipts
to match the new hash (d856fc82). Also update dod-occ-pr-1627 commit_sha
to the OCC branch head and probe_stdout headRefOid.
* evidence(OMN-12245,OMN-11599): promote release receipts from dev to main

Backports OMN-12245 and OMN-11599 DoD receipts and contracts from OCC dev
to main. Required for Contract Compliance Check CI gate which reads from
OCC main branch.

These receipts were written to OCC dev via PR #1710 but were not
forward-promoted to main due to dev/main divergence.

* evidence(OMN-12245): bind replacement release PR receipts
* chore(occ-deps): update rerun state after merge c3d38e7 [skip ci]

* ci: rerun OCC state update checks

* evidence(OMN-12245): bind OCC rerun state cleanup

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: jonahgabriel <jonah.gabriel@gmail.com>
* ci(OMN-12243): add main target guard

* evidence(OMN-12243): add main target guard receipt

* style(OMN-12243): format main target guard receipt
Remove stale deleted node_contract_dependency entry points and bind the hotfix with OMN-12245 receipt evidence.
Add central OCC evidence for omnibase_infra PR #1772 at head 9bcfee8504e4039ec5744bb8163f73c5092d0f9e.
* evidence(OMN-12245): bind omnimarket PR 926 head

* evidence(OMN-12245): bind OCC omnimarket evidence PR
* evidence(OMN-12245): bind omnimarket PR 926 final head

* evidence(OMN-12245): add OCC proof for omnimarket 926 final head
* evidence(OMN-12245): refresh omniintelligence release gates

* evidence(OMN-12245): bind omniintelligence OCC gate
* evidence(OMN-12245): refresh omniintelligence PR 681 final head

* evidence(OMN-12245): bind omniintelligence final OCC PR
Refresh OMN-12245 central evidence for omniclaude#1681 head 8393eff and bind OCC hotfix PR #1750.
Refresh OMN-12245 central evidence for omniclaude#1681 workflow-fix head 244ce65 and bind OCC hotfix PR #1752.
* evidence(OMN-12245): refresh omniclaude PR 1681 CI head

* evidence(OMN-12245): bind OCC PR 1754

* evidence(OMN-12245): format OCC PR 1754 receipt
* evidence(OMN-12245): refresh omniclaude PR 1681 DoD source head

* evidence(OMN-12245): bind OCC PR 1756

* evidence(OMN-12245): format OCC PR 1756 receipt
* evidence(OMN-12245): bind omnibase core PR 1174

* evidence(OMN-12245): bind OCC PR 1770
* evidence(OMN-12245): bind compat runtime DTO hotfix

* evidence(OMN-12245): bind OCC compat DTO evidence PR

* evidence(OMN-12245): restamp receipt contract hashes

* evidence(OMN-12245): refresh OCC DTO receipt head

* evidence(OMN-12245): format and restamp DTO receipts
* evidence(OMN-12245): bind omnimarket runtime proof hotfix

* evidence(OMN-12245): bind OCC omnimarket evidence PR
Merge OCC evidence for omnibase_infra#1773 projection-topic hotfix. Receipt Gate, main-target, pre-commit, and CI passed.
Refresh OMN-12245 OCC evidence for omnibase_infra#1773 after adding integration coverage. Receipt Gate, main-target, pre-commit, and CI passed.
* evidence(OMN-12245): bind infra 1774 release receipt

* evidence(OMN-12245): bind infra 1774 OCC PR

* chore(OMN-12245): retrigger OCC evidence gates

* evidence(OMN-12245): refresh receipt contract hashes

* evidence(OMN-12245): refresh infra 1774 head receipt

* evidence(OMN-12245): format and repin release receipts

* chore(OMN-12245): refresh OCC core dependency pin
* evidence(OMN-12245): refresh infra 1774 retry head

* evidence(OMN-12245): bind infra 1774 refresh OCC PR

* evidence(OMN-12245): declare infra 1774 refresh receipt
…2346)

* evidence(OMN-12833): baseline omniintelligence freestanding guard (#2343)

* evidence(OMN-12833): baseline omniintelligence freestanding guard

* evidence(OMN-12833): bind OCC PR self receipt

* evidence(OMN-12833): bind omniintelligence replacement PR (#2344)

* evidence(OMN-12833): bind omniintelligence replacement PR

* evidence(OMN-12833): self-bind replacement evidence followup

* evidence(OMN-12833): self-bind main hotfix promotion
* evidence(OMN-12856): OCC contract + deploy/focused/pr receipts (#2390)

* evidence(OMN-12856): OCC contract + deploy/focused/pr receipts

Adds contracts/OMN-12856.yaml and three receipts:
- dod-omnimarket-pr-1137: omnimarket#1137 carries the full migration
- dod-focused-checks: enforcement gate + focused tests pass
- dod-deploy-assessment: code-only refactor, No live deploy required

Evidence-Ticket: OMN-12856

* fix(OMN-12856): add self-binding OCC receipt for PR #2390

Adds dod-occ-pr-2390 receipt with pr_number=2390 to satisfy the
OCC eligibility PR-bound invariant.

Evidence-Ticket: OMN-12856

* fix(OMN-12856): add contract_sha256 to all receipts (OMN-10421 requirement)

All receipts produced after 2026-04-30 must carry contract_sha256.
Hash: sha256:cafecd7f0a504be423a483548f8ea2c5ac04105a0ca97e9932b02eaf5dc01dca

Evidence-Ticket: OMN-12856

* fix(OMN-12856): add dod-occ-pr-2391 self-binding receipt and update contract_sha256

Adds dod-occ-pr-2391 receipt (pr_number=2391) for OCC eligibility binding.
Updates contract_sha256 across all receipts to match updated contract.
New hash: sha256:275e51b1a7d06da0b02c8f978c579b36edbfb3c789cb2b17f6318b82f7cccd1a

Evidence-Ticket: OMN-12856
…n baseline

True merge commit (NOT force-update) per OCC evidence-store discipline. Merges
origin/dev (2f09be6) INTO main (89619f0) to converge trees with ZERO durable
evidence loss for the prod-promotion baseline (OMN-12934, State A gate satisfied).

Conflict resolution:
- 56 add/add DoD receipt conflicts -> dev wins (differ only in contract_sha256 to
  match dev's newer contracts; 2 deploy-assessment receipts where dev carries the
  real adversarial gh-probe over main's free-text echo).
- 42 main-only DoD receipt files (drift/dod_receipts/OMN-12765/12856/12770/12564/
  12745/12766/12833) -> PRESERVED (auto-kept; dev lacked them).
- 8 contracts (OMN-11513/12564/12673/12745/12765/12770/12833/12856) -> 3-way UNION
  of dod_evidence blocks: dev's newer contract metadata + dev blocks, with 41
  main-only promotion/release/backmerge evidence blocks appended (no dev block
  dropped). 323/323 receipt references resolve; 0 duplicate ids.
- allowlists/omniclaude.yaml -> 5 OMN-12564 imperative-guard baseline entries
  PRESERVED (main-additive, auto-kept).
- allowlists/omnimemory.yaml, evidence/OMN-11513/EVIDENCE_MANIFEST.md,
  pyproject.toml, uv.lock -> dev wins (dev newer; adopts core rev f325e75/0.44.0).

main-target-guard, required_linear_history temporarily relaxed for this
user-authorized merge (OMN-12934, 2026-06-11), restored immediately after.

Backups: backup/main-pre-omn12934-20260611, backup/dev-pre-omn12934-20260611.
…ergence merge

dev advanced by one additive evidence commit (dc7a5f4, OMN-12949 context-ROI
battery orchestrator OCC contract + receipts) during the convergence operation.
Clean additive merge, no conflicts. Keeps merge-base(main,dev) == dev HEAD.
* evidence(OMN-12939): promote OCC contract + receipts to main

Promotes the OMN-12939 delegation FSM termination-guard contract and PASS receipts (merged to
OCC dev via PR #2456) onto main, so the omnimarket deploy-gate (checks out OCC contracts at
ref:main) resolves contracts/OMN-12939.yaml with its deploy DoD evidence.

Adds dod-occ-pr-2462 self-binding receipt for this promote PR (per OMN-12856 promote pattern).
All 4 receipt check_value greps PASS locally; contract schema-valid; pre-commit clean.
contract_sha256 pinned (sha256:c25510e4).

Evidence-Ticket: OMN-12939

* chore(OMN-12939): yamlfmt-normalize 8 contracts drifted by dev→main convergence

The OMN-12934 dev→main convergence merges (e24cd6a/41a2bcd21) landed 8 contracts on main in
a pre-yamlfmt shape, so the CI pre-commit job (uv run pre-commit run --all-files, a CI Summary
dependency) fails yamlfmt for every main-targeting PR. Reflow them (whitespace/doc-start only;
no semantic change) so CI Summary passes. OMN-12939 contract + receipts are unchanged.

Affected: OMN-11513, OMN-12564, OMN-12673, OMN-12745, OMN-12765, OMN-12770, OMN-12833, OMN-12856.

Evidence-Ticket: OMN-12939
* evidence(OMN-12950): promote OCC contract + receipts to main

OCC PR #2464 squash-merged the OMN-12950 reducer runtime-profile ownership
contract + dod receipts to OCC dev only. omnimarket PR #1164 (target dev,
receipt-gate policy=legacy) validates Evidence-Source against OCC main, where
contracts/OMN-12950.yaml was absent -> merge_group Receipt Gate failure.

Promotes contracts/OMN-12950.yaml and drift/dod_receipts/OMN-12950/* to OCC
main so PR #1164 Evidence-Source resolves to an OCC main ancestor.

Same promotion pattern as OMN-12939 (#2462).

* ci(OMN-12950): retrigger checks with main base context

* evidence(OMN-12950): add self-binding OCC eligibility receipt for promote PR #2466

OCC preflight eligibility (reason pr_ticket_mismatch) requires a PASS receipt
binding to the promote PR itself. Mirrors OMN-12939 dod-occ-pr-2462.

* evidence(OMN-12950): declare dod-occ-pr-2466 self-receipt + resync contract_sha256

OCC eligibility iterates receipts declared in the contract dod_evidence list and
binds them to the PR by pr_number/commit_sha. The promote PR #2466 needs a
self-binding receipt DECLARED in the contract (not just on disk). Adds the
dod-occ-pr-2466 evidence entry and resyncs contract_sha256 across all four
receipts to the new contract digest b8d8667f. Mirrors OMN-12939 dod-occ-pr-2462.
Promotes contracts/OMN-12962.yaml (with dod-deploy-assessment + dod-occ-pr-2480
items added) and all dod receipts from dev (merged in #2473) to OCC main, so the
two code PRs' Receipt-Gate resolves Evidence-Source against an ancestor of OCC main
(OMN-10419) and the omnimarket deploy-gate finds a deploy-assessment dod_evidence item.

hotfix-evidence: OCC-2473
backmerge: #2473
Evidence-Ticket: OMN-12962
Evidence-Source: OCC#2473
…sweep + typed watchdog events (#2489) (#2494)

OCC eligibility + dod_evidence receipts for omnimarket PR #1170 (head b0246319).
Watchdog topic literals live in omnimarket.events.topics (allowlisted registry);
events/watchdog.py imports them and exposes the typed EnumWatchdogEventType authority.
Stranded-workflow Phase-4 audit in NodeRuntimeSweep + watchdog-topic-authority CI guard
(pre-commit + CI). Compute + CI-gate change only; no live-lane mutation.
…2131 (main) (#3235)

* receipt(OMN-13670): bind crypto floor receipts to omnibase_infra PR #2130 (main)

Adds OMN-13670 contract + DoD receipts to onex_change_control main:
- contracts/OMN-13670.yaml: full contract covering all OMN-13670 hotfix phases
- dod-001: pyjwt/python-multipart/starlette pyproject.toml floors (PR #2128)
- dod-002: entrypoint stamp tolerance primary/secondary policy (PR #2128)
- dod-003: 7 entrypoint stamp tolerance tests pass (PR #2128)
- dod-004: cryptography>=48.0.1 Dockerfile floor — clears GHSA-537c-gmf6-5ccf (PR #2130)
- dod-deploy-assessment: no live deploy or cluster mutation in either PR
- dod-occ-self: self-binding receipt for this OCC PR

This OCC merge commit SHA is used as Evidence-Source in omnibase_infra PR #2130.

* fix(OMN-13670): update dod-004 receipt with correct PR #2131 ref

* fix(OMN-13670): suppress pre-existing agent_routing_decisions migration conflict in omnibase_infra main

* chore(OMN-13670): retrigger required main checks

* fix(OMN-13670): repair crypto floor OCC binding

* chore(OMN-13670): refresh hotfix OCC checks

* fix(OMN-13670): refresh migration inventory
…2134 (main) (#3241)

* receipt(OMN-13687): bind ECR push-retry evidence to omnibase_infra PR #2134 (main)

* receipt(OMN-13687): bind dod-occ-self to OCC PR #3241 for merge-eligibility
* fix(OMN-13701): repair main boundary parity action

* chore(OMN-13701): refresh boundary parity CI
#3444)

* evidence(OMN-13437): promote prod-promotion grant trust anchor to main

Promotes the OMN-13437 (Phase 2a trust anchor) + OMN-13424 (single-use
lifecycle) OCC contracts, dod receipts, and their supporting files from
dev (PR #2877, PR #3134) onto main:

- grants/prod_promotion_grants.yaml at rest (entries: [])
- .github/CODEOWNERS: dedicated @OmniNode-ai/platform-leads rule for the
  grants file
- .github/workflows/validate-prod-promotion-grants.yml: schema + lifecycle
  validation workflow
- tests/test_prod_promotion_grants.py (18 tests)

This is a governance-registry promotion only. It does not add a grant
entry (that remains a human CODEOWNERS action) and does not touch any
runtime lane. Until this file exists at @main, no ModelProdPromotionGrant
can resolve there — this PR makes the registry resolvable.

* evidence(OMN-13437): self-bind promotion PR #3444 for OCC eligibility

The receipt-gate / occ-preflight eligibility check requires at least one
PASS receipt whose pr_number matches the promotion PR itself (or one of
its commit SHAs) for every ticket cited in the PR title/body. Add
dod-occ-pr-3444 (contract entry + receipt) following the established
hotfix/omn-XXXXX-occ-main-promote pattern (c.f. OMN-12959 PR #2494), and
re-stamp the existing dod-001..006 receipts with the recomputed
contract_sha256 now that the contract carries the new entry.

* chore: refresh expired db-boundary-exception review_by dates

Pre-commit's check-db-boundary-registry hook fails main's required CI
Summary job because 3 review_by: "2026-06" entries expired against
today's date (2026-07-01/02). These are pre-existing LEGACY_MIGRATION
exceptions (jonah-owned) whose planned migrations remain unresolved --
bump review_by to "2026-07" to reopen the review window. No status or
justification change; this is a housekeeping date refresh only,
discovered as a side effect of landing the OMN-13437 grants-registry
promotion PR, not a scope change to that promotion.

* chore(OMN-13437): suppress known swarm_runs migration duplicate
…3595)

* evidence(OMN-13915): promote runner listener deploy evidence to main

* evidence(OMN-13915): bind OCC main promotion PR

* evidence(OMN-13915): stamp receipt contract hashes

* evidence(OMN-13915): bind hotfix promotion PR

* evidence(OMN-13915): use independent receipt verifier

* style(OMN-13915): apply OCC yaml formatting

* evidence(OMN-13915): list tenant credentials migration
* evidence(OMN-13915): expose deploy gate token

* evidence(OMN-13915): bind deploy token hotfix PR

* evidence(OMN-13915): refresh consuming PR head

* evidence(OMN-13915): correct consuming PR head
@coderabbitai

coderabbitai Bot commented Jul 6, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 13 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fc2dd1cb-516b-4eb0-b3ad-c6e7a4c6c2e8

📥 Commits

Reviewing files that changed from the base of the PR and between 6436731 and 7a72d8a.

📒 Files selected for processing (6)
  • contracts/OMN-14060.yaml
  • drift/dod_receipts/OMN-14060/dod-lint-typecheck-precommit/command.yaml
  • drift/dod_receipts/OMN-14060/dod-no-runtime-deploy/command.yaml
  • drift/dod_receipts/OMN-14060/dod-occ-self/command.yaml
  • drift/dod_receipts/OMN-14060/dod-omnibase-infra-pr-2223/command.yaml
  • drift/dod_receipts/OMN-14060/dod-tests/command.yaml
📝 Walkthrough

Walkthrough

Adds a new drift contract file contracts/OMN-14060.yaml defining evidence requirements and dod_evidence grep checks for the OMN-14060 ticket, plus five new command.yaml receipt files under drift/dod_receipts/OMN-14060/ recording PASS execution evidence for tests, lint/typecheck, occ-self, no-runtime-deploy, and PR #2223 checks.

Changes

OMN-14060 Contract and Evidence

Layer / File(s) Summary
Contract definition and evidence requirements
contracts/OMN-14060.yaml
Adds contract metadata, seam/interface flags, evidence_requirements with grep-based command checks, an emergency_bypass block, and dod_evidence entries mapping to receipt checks.
Command receipt evidence files
drift/dod_receipts/OMN-14060/dod-tests/command.yaml, drift/dod_receipts/OMN-14060/dod-lint-typecheck-precommit/command.yaml, drift/dod_receipts/OMN-14060/dod-no-runtime-deploy/command.yaml, drift/dod_receipts/OMN-14060/dod-occ-self/command.yaml, drift/dod_receipts/OMN-14060/dod-omnibase-infra-pr-2223/command.yaml
Adds new receipt YAMLs recording schema/check metadata, probe commands, PASS status/exit codes, timestamps, commit/branch/PR context, contract SHA256, and captured stdout/actual output for each evidence item.

Estimated code review effort: 2 (Simple) | ~10 minutes

Related PRs: None found.

Suggested labels: documentation, drift-evidence, infra

Suggested reviewers: None identified.

🐰

   OMN-14060, locked and PASSed,
   Receipts stacked, evidence amassed,
   Grep checks whisper "all is well",
   No live deploy, no drift to tell,
   A carrot-shaped contract, built to last.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the PR’s main change: binding OMN-14060 to the infra venv drift guard evidence and receipts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-14060-occ-infra-venv-drift-guard

Comment @coderabbitai help to get the list of available commands.

@jonahgabriel
jonahgabriel enabled auto-merge (squash) July 6, 2026 21:47
@jonahgabriel
jonahgabriel changed the base branch from main to dev July 7, 2026 02:38
…fra-venv-drift-guard

# Conflicts:
#	contracts/OMN-12939.yaml
#	contracts/OMN-12950.yaml
#	contracts/OMN-12959.yaml
#	contracts/OMN-12962.yaml
#	contracts/OMN-13437.yaml
#	contracts/OMN-13670.yaml
#	contracts/OMN-13687.yaml
#	contracts/OMN-13915.yaml
#	drift/dod_receipts/OMN-12939/dod-deploy-assessment/command.yaml
#	drift/dod_receipts/OMN-12939/dod-occ-pr-2456/command.yaml
#	drift/dod_receipts/OMN-12939/dod-omnimarket-pr-1158/command.yaml
#	drift/dod_receipts/OMN-12950/dod-deploy-assessment/command.yaml
#	drift/dod_receipts/OMN-12950/dod-occ-pr-2464/command.yaml
#	drift/dod_receipts/OMN-12950/dod-omnimarket-pr-1164/command.yaml
#	drift/dod_receipts/OMN-12959/dod-deploy-assessment/command.yaml
#	drift/dod_receipts/OMN-12959/dod-occ-pr-2489/command.yaml
#	drift/dod_receipts/OMN-12959/dod-omnimarket-pr-1170/command.yaml
#	drift/dod_receipts/OMN-12962/dod-deploy-assessment/command.yaml
#	drift/dod_receipts/OMN-12962/dod-infra-pr-1937/command.yaml
#	drift/dod_receipts/OMN-12962/dod-occ-pr/command.yaml
#	drift/dod_receipts/OMN-12962/dod-omnimarket-pr-1166/command.yaml
#	drift/dod_receipts/OMN-13437/dod-001/command.yaml
#	drift/dod_receipts/OMN-13437/dod-002/command.yaml
#	drift/dod_receipts/OMN-13437/dod-003/command.yaml
#	drift/dod_receipts/OMN-13437/dod-004/command.yaml
#	drift/dod_receipts/OMN-13437/dod-005/command.yaml
#	drift/dod_receipts/OMN-13437/dod-006/command.yaml
#	drift/dod_receipts/OMN-13670/dod-001/command.yaml
#	drift/dod_receipts/OMN-13670/dod-002/command.yaml
#	drift/dod_receipts/OMN-13670/dod-003/command.yaml
#	drift/dod_receipts/OMN-13670/dod-deploy-assessment/command.yaml
#	drift/dod_receipts/OMN-13670/dod-occ-self/command.yaml
#	drift/dod_receipts/OMN-13701/dod-001/command.yaml
#	drift/dod_receipts/OMN-13701/dod-boundary-registry/command.yaml
#	drift/dod_receipts/OMN-13915/dod-omnibase_infra-pr-2194/command.yaml
#	migration_conflict_suppressions.yaml
#	registry/db-boundary-exceptions.yaml

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
drift/dod_receipts/OMN-14060/dod-no-runtime-deploy/command.yaml (1)

6-6: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

check_value is prose, not the runnable command it should mirror.

Unlike the sibling receipts where check_value exactly matches probe_command, here check_value is a human-readable sentence ("deploy gate reviewed: ...") while probe_command (Line 13) is the actual gh pr view command. For check_type: command self-attesting entries with no assertable external state, the established convention is to wrap the rationale in printf (as documented for dod-deploy/dod-occ-self) rather than leaving raw prose in check_value.

♻️ Suggested alignment with sibling receipts
-check_value: "deploy gate reviewed: no live deploy required for local omnimarket venv drift guard; runtime paths are CLI/script guard code only"
+check_value: "printf 'deploy gate reviewed: no live deploy required for local omnimarket venv drift guard; runtime paths are CLI/script guard code only'"

Based on learnings, "allow printf to be used as the check_value for dod_evidence blocks" for self-attesting DoD items where "no external state can be asserted".

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@drift/dod_receipts/OMN-14060/dod-no-runtime-deploy/command.yaml` at line 6,
The `check_value` in the receipt is prose instead of a runnable command, so
align it with the command-based convention used by sibling DoD receipts. Update
the `check_value` field in the command entry to use a self-attesting
`printf`-style command that mirrors the rationale for the `probe_command`,
keeping the `command` check_type consistent and making the evidence mechanically
verifiable. Reference the `check_value` and `probe_command` fields in
`command.yaml` when making the change.

Source: Learnings

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@drift/dod_receipts/OMN-14060/dod-no-runtime-deploy/command.yaml`:
- Line 6: The `check_value` in the receipt is prose instead of a runnable
command, so align it with the command-based convention used by sibling DoD
receipts. Update the `check_value` field in the command entry to use a
self-attesting `printf`-style command that mirrors the rationale for the
`probe_command`, keeping the `command` check_type consistent and making the
evidence mechanically verifiable. Reference the `check_value` and
`probe_command` fields in `command.yaml` when making the change.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a1af9988-0415-4b60-95ba-32be874aa420

📥 Commits

Reviewing files that changed from the base of the PR and between 3dd9ebe and 6436731.

📒 Files selected for processing (6)
  • contracts/OMN-14060.yaml
  • drift/dod_receipts/OMN-14060/dod-lint-typecheck-precommit/command.yaml
  • drift/dod_receipts/OMN-14060/dod-no-runtime-deploy/command.yaml
  • drift/dod_receipts/OMN-14060/dod-occ-self/command.yaml
  • drift/dod_receipts/OMN-14060/dod-omnibase-infra-pr-2223/command.yaml
  • drift/dod_receipts/OMN-14060/dod-tests/command.yaml

@jonahgabriel
jonahgabriel merged commit c9b8a1a into dev Jul 7, 2026
42 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-14060-occ-infra-venv-drift-guard branch July 7, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant