Skip to content

fix(ci): add fix@local to AUTHOR_MAP for Tranquil-Flow - #31982

Open
talwayh1 wants to merge 1 commit into
NousResearch:mainfrom
talwayh1:ci-fix/attribution-map-fix-local
Open

fix(ci): add fix@local to AUTHOR_MAP for Tranquil-Flow#31982
talwayh1 wants to merge 1 commit into
NousResearch:mainfrom
talwayh1:ci-fix/attribution-map-fix-local

Conversation

@talwayh1

Copy link
Copy Markdown

What

Add fix@localTranquil-Flow mapping to scripts/release.py AUTHOR_MAP.

Root Cause

PR #22105 (fix/21589-discord-goal-slash-command) has a commit authored with email fix@local (display name "Fix Bot"). This email is not in AUTHOR_MAP, causing the Contributor Attribution Check CI workflow to fail.

The PR author is Tranquil-Flow, so the email maps to that GitHub username.

Fix

Added "fix@local": "Tranquil-Flow" to the manual mapping section in scripts/release.py AUTHOR_MAP.

Related

Fixes Contributor Attribution Check failure on PR NousResearch#22105.
The commit was authored with email fix@local (Fix Bot), mapped to
GitHub user Tranquil-Flow who authored the PR.
@alt-glitch alt-glitch added type/refactor Code restructuring, no behavior change P3 Low — cosmetic, nice to have labels May 25, 2026

@teknium1 teknium1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the targeted attribution fix. The mapping itself matches the current resolver: scripts/release.py:2147-2165 checks AUTHOR_MAP by exact email before falling back to the git display name.

Problems

  • The reported failure was for #22105, but GitHub currently reports that PR as closed and unmerged (merged=false; source commit 9ae4b0890aa4c1570f26e0b2d6fa3ee5fddbc992). The CI workflow evaluates only commits in the PR under test's merge-base..HEAD range (.github/workflows/contributor-check.yml:19-44), so this change does not address a verified current-main CI failure.

Suggested changes

  • Please identify an active commit/PR that still introduces fix@local, or re-scope this mapping to that live use case.

Automated hermes-sweeper review.

Comment thread scripts/release.py
"shannon@nousresearch.com": "shannonsands",
"abdi.moya@gmail.com": "AxDSan",
"eri@plasticlabs.ai": "Erosika",
"fix@local": "Tranquil-Flow",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cited source, #22105, is currently closed and unmerged. Because the attribution workflow checks only the current PR's commit range (.github/workflows/contributor-check.yml:19-44), please identify a live commit or PR authored as fix@local before adding this mapping.

@teknium1 teknium1 added sweeper:risk-automation Sweeper risk: may affect CI, automerge, label sync, or maintainer automation sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users labels Jul 13, 2026

@GottZ GottZ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was generated by AI during triage.

Summary

Twenty-four PRs address the same contributor-attribution mechanism, but almost all map different email identities and therefore do not fix #31982's reported fix@local case. The target diff adds the correct exact-email lookup entry, yet its only cited consumer, #22105, is closed and unmerged; the other diffs are independent mappings, already-landed references, superseded duplicates, or unrelated bundled changes.

Related pull requests

  • #9758 [closed] related — (+1/-0) — no action: Adds a MestreY0d4-Uninter noreply alias, not fix@local; it remains relevant as a closed attribution-map precedent after the contributor reported the identity coverage had been absorbed into main.
  • #11682 [closed] related — (+1/-0) — implemented elsewhere: Adds the numeric briandevans noreply alias, not the target identity; it was closed after a contributor verified the exact entry already existed on main.
  • #14447 [closed] related — (+3/-1) — implemented elsewhere: Adds the Bartok9 Gmail alias while relocating the existing numeric noreply entry; it was closed after both requested mappings were verified on main.
  • #17613 [closed] related — (+2/-0) — withdrawn: Adds dusterbloom's Gmail alias rather than fix@local, and the stale diff also contains an unresolved conflict marker; the author closed it after rewriting affected commits to use the accepted numeric noreply identity.
  • #18779 [closed] related — (+2/-0) — implemented elsewhere: Adds two liuhao1024 aliases unrelated to the target email; it remains relevant because both entries were later verified on main, making the closed PR redundant.
  • #25308 [closed] related — (+2/-0) — salvaged: Adds two simpolism aliases, one already present and one subsequently landed through #25440; the closed PR is relevant as the source whose authorship was preserved by that salvage.
  • #26026 [closed] related — (+1/-0) — redundant: Adds bartokmagic@proton.me for Bartok9, not fix@local; the author closed it after confirming the alias was already on main.
  • #26110 [closed] related — (+1/-0) — implemented elsewhere: Adds the lowercase Bartok9 noreply variant; it was closed after a contributor traced the same mapping on main to an earlier salvage commit.
  • #26295 [closed] related — (+0/-0) — no remaining diff: Intended to map the plain zccyman noreply address, but the cached diff is empty and a contributor verified the mapping was already on main; the requested-conflict review therefore has no unresolved code change to preserve.
  • #26319 [merged] related — (+1/-0) — merged reference implementation: Maps brian@dralth.com to btorresgil through the same exact-email resolver, demonstrating the narrow one-line pattern but not addressing fix@local.
  • #26608 [closed] related — (+1/-0) — duplicate: Adds the same cypres0099 plain-noreply mapping as #28897; it was closed explicitly in favor of #28897.
  • #28897 [closed] related — (+1/-0) — superseded by current coverage: Adds the same cypres0099 mapping as #26608. Despite the earlier keep_open review on #28897, the later contributor check showed the live dependent commit uses an already-mapped numeric noreply address accepted by the workflow, so this closed plain-address addition is no longer required.
  • #31982 related — (+1/-0) — close unless a live consumer is supplied: The diff correctly maps fix@local to Tranquil-Flow, but its sole cited consumer #22105 is closed and unmerged, so it does not repair an active attribution failure. Despite the keep_open review on #31982, that review itself records the missing live-use evidence and asks for an active commit or PR before salvage.
  • #31991 related — (+1/-0) — close unless a live consumer is supplied: Adds the distinct hermes-ci-bot@nousresearch.com mapping and would satisfy the historical exact-email failure, but the cited branch no longer exists. Despite the keep_open review on #31991, the review explicitly found no current-main or local-ref commit using that email and conditioned salvage on confirming a live branch.
  • #37121 [merged] related — (+1/-0) — merged reference implementation: Maps wasdhkzk@gmail.com to whyhkzk for a documented dependent PR; it is relevant as a successful one-line mapping backed by a live consumer, but it does not overlap #31982.
  • #44290 [closed] related — (+3/-0) — separate closed mapping batch: Adds three carrier-reported aliases for konsisumer, BROCCOLO1D, and claw3649; it remains relevant as evidence of the same exact-email failure class, but none of its entries addresses fix@local.
  • #44773 [closed] related — (+4/-0) — separate closed mapping batch: Adds three AIalliAI aliases and one plcunha alias for then-failing PRs; it remains a historical example of consolidating repeated attribution failures, not a diff duplicate of #31982.
  • #48299 [merged] related — (+1/-0) — merged reference implementation: Maps infinitycrew39@gmail.com for preserved salvage authorship, providing a landed example with a concrete consumer but no overlap with fix@local.
  • #50520 [closed] related — (+7/-1) — withdrawn and mixed-scope: Includes the fix@bot.dev mapping plus an unrelated plugin-toolset validation change, rather than #31982's fix@local mapping. Although a non-contributor approved the code, the identified owner later stated that fix@bot.dev was not their identity and amended the commits, so the closed PR should not be revived.
  • #57007 [merged] related — (+1/-0) — merged reference implementation: Maps ai-lab@foxmail.com to CrazyBoyM for preserved authorship in #55828; it demonstrates a substantiated attribution fix but is independent of #31982.
  • #59910 [closed] related — (+1/-0) — obsolete duplicate: Repeats the fix@bot.dev to indigokarasu mapping from #50520 and #59916, not the target's fix@local identity; the later owner correction on #50520 removes the stated attribution basis.
  • #59916 [closed] related — (+2326/-1) — reject as bundled duplicate: Repeats the same fix@bot.dev mapping while carrying a full Genie skill and an unrelated executor change; the contributor discussion correctly recommends isolating the valuable delegation fix instead of merging this branch. Its closed state remains relevant because it exposes why the one-line attribution change must not justify the 18-file payload.
  • #63560 related — (+1/-0) — merge independently: Adds the missing jethachan@gmail.com alias for jethac, with a live commit association, dependent PRs, and a passing attribution check. The keep_open review supports a narrow salvage, but this mapping is independent of #31982.
  • #71783 related — (+1/-0) — merge independently: Adds sophia@hermes.local to the current per-file contributor mapping mechanism, with passing CI and multiple reported live dependents. It addresses the same failure class through the repository's newer format but does not resolve fix@local.

Duplicates

#26608 and #28897 propose the same cypres0099 plain-noreply mapping. #50520, #59910, and the attribution hunk of #59916 repeat the same fix@bot.devindigokarasu mapping, although #50520 and #59916 contain substantial additional scope; fix@bot.dev is distinct from #31982's fix@local.

Suggested consolidation

Do not merge #31982 without a current commit or open PR that actually introduces fix@local; close it as lacking a live consumer, despite its keep_open review, because the diff only remedies closed-unmerged #22105. Merge #63560 and #71783 independently for their verified live identities; close or keep closed #26608/#28897 as duplicates/superseded coverage and #50520/#59910/#59916 as obsolete or improperly bundled fix@bot.dev variants.

Cross-PR triage: Reviewed 24 pull requests and 0 issues in this complex. Each diff was read against this issue; Assessment working set: 123 kB of PR diffs, 23 kB of issue/PR text, 17 kB of discussion (36 comments), 4 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users sweeper:risk-automation Sweeper risk: may affect CI, automerge, label sync, or maintainer automation type/refactor Code restructuring, no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants