Skip to content

chore(release): map jethachan@gmail.com to jethac in AUTHOR_MAP - #63560

Closed
jethac wants to merge 1 commit into
NousResearch:mainfrom
jethac:chore/author-map-jethac
Closed

chore(release): map jethachan@gmail.com to jethac in AUTHOR_MAP#63560
jethac wants to merge 1 commit into
NousResearch:mainfrom
jethac:chore/author-map-jethac

Conversation

@jethac

@jethac jethac commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Adds jethachan@gmail.com → jethac to AUTHOR_MAP in scripts/release.py.

The check contributors / check-attribution job validates that every commit-author
email in a PR is mapped in AUTHOR_MAP. Commits authored by jethachan@gmail.com
currently fail that check on any branch off main, because the mapping only exists
inside the in-flight multi-agent PR (#62944) rather than on main.

Splitting it into this standalone one-liner so it can land independently and unblock
attribution for all the related PRs. #62944, #63522, and #63523 depend on this.

This was referenced Jul 13, 2026
Closed
Closed
Open
@alt-glitch alt-glitch added type/refactor Code restructuring, no behavior change P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard sweeper:risk-automation Sweeper risk: may affect CI, automerge, label sync, or maintainer automation labels Jul 13, 2026
@jethac
jethac force-pushed the chore/author-map-jethac branch from 9bc036d to bba9c94 Compare July 14, 2026 08:39
@teknium1

teknium1 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Thanks for isolating the attribution fix.

Current main has the prior jetha@google.com → jethac entry at scripts/release.py:791, but no jethachan@gmail.com entry. resolve_author() uses the exact AUTHOR_MAP lookup at scripts/release.py:2171; unresolved values are recorded as unknown at scripts/contributor_audit.py:185-192, and strict mode fails newly introduced unknown commit emails at scripts/contributor_audit.py:419-449.

GitHub associates commit bba9c94582d1's author email with @jethac, and the PR's Check contributors / check-attribution job passes with this one-line mapping. The change matches the repository's existing attribution-map pattern and is suitable for a clean, narrow salvage.

Automated hermes-sweeper review.

@teknium1 teknium1 added the sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users label Jul 16, 2026
@jethac
jethac force-pushed the chore/author-map-jethac branch from bba9c94 to 0e772ca Compare July 18, 2026 02:02
@jethac jethac mentioned this pull request Jul 19, 2026
Open
jethac added a commit to jethac/hermes-agent that referenced this pull request Jul 22, 2026
@jethac @claude
Restore jetha@google.com author-map entry dropped by PR NousResearch#…
d524fa5 
…35785 itself

Bisected commit-by-commit: this line survives cleanly through the
author-map/flake-fix/multi-agent merges and disappears exactly at merging
fix/line-media-adapter. Confirmed via diff against that PR branch's own
merge-base that the deletion is baked into the PR's own commit history
(unrelated to its actual LINE-media-caching purpose -- almost certainly
incidental collateral from however that PR's author-map commit was
originally assembled), not an artifact of this merge. No PR has any
legitimate reason to remove this mapping, so restoring it here.

(The duplicate "jethachan@gmail.com" entry, by contrast, is harmless: two
of jethac's own PRs -- NousResearch#63560 and NousResearch#35785 -- each independently add the
identical line/comment, consistent with ~75 other pre-existing duplicate
keys already in this file on upstream/main. Left as-is.)

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@GottZ GottZ mentioned this pull request Jul 28, 2026
Open
@jethac
jethac force-pushed the chore/author-map-jethac branch from 0e772ca to a6ce43e Compare July 29, 2026 05:54
@jethac @claude
chore(release): map jethachan@gmail.com to jethac in AUTHOR_MAP
df880e1 
My commits on this PR use my personal email (no longer at Google). Add it to
AUTHOR_MAP alongside the existing jetha@google.com entry (which still attributes
an earlier commit) — both resolve to the same GitHub user. Fixes check-attribution.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@jethac
jethac force-pushed the chore/author-map-jethac branch from a6ce43e to df880e1 Compare July 30, 2026 01:56
@teknium1

teknium1 commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Thanks @jethac — this mapping now exists on main as contributors/emails/jethachan@gmail.com (the AUTHOR_MAP dict this PR targets is frozen; per-email files under contributors/emails/ are the current mechanism, and #77116 added scripts/audit_pr_attribution.py --fix to generate them automatically). Your email is mapped, so the attribution check will pass for your branches. Closing as resolved.

@teknium1 teknium1 closed this Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users sweeper:risk-automation Sweeper risk: may affect CI, automerge, label sync, or maintainer automation type/refactor Code restructuring, no behavior change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jethac @teknium1 @alt-glitch