Skip to content

chore(release): add lowercase bartok9 noreply email to AUTHOR_MAP - #26110

Closed
Bartok9 wants to merge 1 commit into
NousResearch:mainfrom
Bartok9:fix/author-map-lowercase-noreply
Closed

chore(release): add lowercase bartok9 noreply email to AUTHOR_MAP#26110
Bartok9 wants to merge 1 commit into
NousResearch:mainfrom
Bartok9:fix/author-map-lowercase-noreply

Conversation

@Bartok9

@Bartok9 Bartok9 commented May 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds the lowercase noreply form bartok9@users.noreply.github.com to scripts/release.py AUTHOR_MAP so the contributor-attribution gate stops failing on PRs that contain older commits from this account.

Context

Older commits from Bartok9 used the lowercase noreply email form (bartok9@users.noreply.github.com). AUTHOR_MAP currently has the canonical capital-B form (Bartok9@users.noreply.github.com) but the gate's email comparison is case-sensitive, so those older commits fail the check.

This affects e.g. #23061 (rebased earlier tonight; one of the cherry-picked commits carries that older author shape).

Change

One line added next to the existing canonical entry:

"bartok9@users.noreply.github.com": "Bartok9",  # lowercase form (older commits)

Test plan

🎻

@alt-glitch alt-glitch added type/refactor Code restructuring, no behavior change P3 Low — cosmetic, nice to have labels May 15, 2026
@Bartok9

Bartok9 commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

Closing to stay within contributor PR limit. Will resubmit with fresh rebase if the issue remains open in main.

@Bartok9 Bartok9 closed this May 27, 2026
@Bartok9 Bartok9 reopened this May 27, 2026
Older commits from this account used the lowercase noreply form
'bartok9@users.noreply.github.com'. AUTHOR_MAP currently only contains
the canonical 'Bartok9@users.noreply.github.com' (capital B) and the
case-sensitive comparison means those commits fail check-attribution
even though the canonical mapping is present.

Adds the lowercase variant so check-attribution stops failing on PRs
that contain older commits (e.g. NousResearch#23061).
@Bartok9
Bartok9 force-pushed the fix/author-map-lowercase-noreply branch from c0a31a6 to 53c8cd4 Compare May 27, 2026 20:39
@teknium1

Copy link
Copy Markdown
Contributor

This looks implemented on current main already.

Automated hermes-sweeper review evidence:

  • scripts/release.py:334 already contains "bartok9@users.noreply.github.com": "Bartok9", matching this PR's requested one-line change.
  • scripts/release.py:1706 resolves authors through AUTHOR_MAP.get(email), so this exact lowercase email now resolves through the attribution gate.
  • git blame attributes the current mapping line to 785993bcae8f677c6dbcebfc66b76392db91d407 (chore(release): map bartok9 noreply for PR #24879 salvage).

Thanks for calling out the older lowercase noreply form; main now has the mapping.

@teknium1 teknium1 closed this Jun 12, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have sweeper:implemented-on-main Sweeper: behavior already present on current main type/refactor Code restructuring, no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants